Re: [PATCH v2] crypto: omap-sham: kmap SG pages before appending

2014-03-04 Thread Herbert Xu
On Wed, Mar 05, 2014 at 04:18:12AM +, Fernandes, Joel wrote: > > > > On Mar 4, 2014, at 8:00 PM, "Herbert Xu" > > wrote: > > > >> On Tue, Mar 04, 2014 at 12:30:54PM -0600, Joel Fernandes wrote: > >> HIGHMEM pages may not be mapped so we must kmap them before accessing. > >> This resolves a

Re: [PATCH v2] crypto: omap-sham: kmap SG pages before appending

2014-03-04 Thread Fernandes, Joel
> On Mar 4, 2014, at 8:00 PM, "Herbert Xu" wrote: > >> On Tue, Mar 04, 2014 at 12:30:54PM -0600, Joel Fernandes wrote: >> HIGHMEM pages may not be mapped so we must kmap them before accessing. >> This resolves a random OOPs error that was showing up during OpenSSL SHA >> tests. >> >> Signed-o

Re: [PATCH v2] crypto: omap-sham: kmap SG pages before appending

2014-03-04 Thread Herbert Xu
On Tue, Mar 04, 2014 at 12:30:54PM -0600, Joel Fernandes wrote: > HIGHMEM pages may not be mapped so we must kmap them before accessing. > This resolves a random OOPs error that was showing up during OpenSSL SHA > tests. > > Signed-off-by: Joel Fernandes > Cc: Herbert Xu > --- > v2 changes: >

Re: [PATCH][RESEND 3] hwrng: add randomness to system from rng sources

2014-03-04 Thread Matt Mackall
On Tue, 2014-03-04 at 11:59 -0800, Kees Cook wrote: > On Tue, Mar 4, 2014 at 11:53 AM, Jason Cooper wrote: > > On Tue, Mar 04, 2014 at 11:01:49AM -0800, Kees Cook wrote: > >> On Tue, Mar 4, 2014 at 7:38 AM, Jason Cooper wrote: > >> > Kees, Ted, > >> > > >> > On Mon, Mar 03, 2014 at 03:51:48PM -08

Re: [PATCH][RESEND 3] hwrng: add randomness to system from rng sources

2014-03-04 Thread Kees Cook
On Tue, Mar 4, 2014 at 11:53 AM, Jason Cooper wrote: > On Tue, Mar 04, 2014 at 11:01:49AM -0800, Kees Cook wrote: >> On Tue, Mar 4, 2014 at 7:38 AM, Jason Cooper wrote: >> > Kees, Ted, >> > >> > On Mon, Mar 03, 2014 at 03:51:48PM -0800, Kees Cook wrote: >> >> When bringing a new RNG source online

Re: [PATCH][RESEND 3] hwrng: add randomness to system from rng sources

2014-03-04 Thread Jason Cooper
On Tue, Mar 04, 2014 at 11:01:49AM -0800, Kees Cook wrote: > On Tue, Mar 4, 2014 at 7:38 AM, Jason Cooper wrote: > > Kees, Ted, > > > > On Mon, Mar 03, 2014 at 03:51:48PM -0800, Kees Cook wrote: > >> When bringing a new RNG source online, it seems like it would make sense > >> to use some of its b

Re: [PATCH][RESEND 3] hwrng: add randomness to system from rng sources

2014-03-04 Thread Kees Cook
On Tue, Mar 4, 2014 at 7:38 AM, Jason Cooper wrote: > Kees, Ted, > > On Mon, Mar 03, 2014 at 03:51:48PM -0800, Kees Cook wrote: >> When bringing a new RNG source online, it seems like it would make sense >> to use some of its bytes to make the system entropy pool more random, >> as done with all s

[PATCH v2] crypto: omap-sham: kmap SG pages before appending

2014-03-04 Thread Joel Fernandes
HIGHMEM pages may not be mapped so we must kmap them before accessing. This resolves a random OOPs error that was showing up during OpenSSL SHA tests. Signed-off-by: Joel Fernandes Cc: Herbert Xu --- v2 changes: - don't check for HIGHMEM, kmap/kunmap do them anyway (Thanks Herbert). dr

Re: [PATCH][RESEND 3] hwrng: add randomness to system from rng sources

2014-03-04 Thread Jason Cooper
Kees, Ted, On Mon, Mar 03, 2014 at 03:51:48PM -0800, Kees Cook wrote: > When bringing a new RNG source online, it seems like it would make sense > to use some of its bytes to make the system entropy pool more random, > as done with all sorts of other devices that contain per-device or > per-boot d