Re: [PATCH RESEND] padata: make the sequence counter an atomic_t

2013-10-29 Thread Herbert Xu
On Fri, Oct 25, 2013 at 12:14:15PM +0200, Mathias Krause wrote: > Using a spinlock to atomically increase a counter sounds wrong -- we've > atomic_t for this! > > Also move 'seq_nr' to a different cache line than 'lock' to reduce cache > line trashing. This has the nice side effect of decreasing t

Re: [PATCH] crypto: omap-aes: Fix CTR mode counter length

2013-10-29 Thread Herbert Xu
On Tue, Oct 29, 2013 at 05:37:38PM -0500, Joel Fernandes wrote: > NIST vectors for CTR mode in testmgr.h assume the entire IV as the counter. To > get correct results that match the output of these vectors, we need to set the > counter length correctly. > > Signed-off-by: Joel Fernandes Patch ap

Re: [PATCH] CRYPTO: omap-sham: Add missing modalias

2013-10-29 Thread Herbert Xu
On Sat, Oct 26, 2013 at 11:00:41PM +0200, Pali Rohár wrote: > From: Joni Lapilainen > > Signed-off-by: Joni Lapilainen Patch applied. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list:

Re: [PATCH 1/3] crypto: caam - Add Platform driver for Job Ring

2013-10-29 Thread Herbert Xu
On Fri, Oct 25, 2013 at 12:01:01PM +0530, Ruchika Gupta wrote: > The SEC Job Rings are now available as individual devices. > This would enable sharing of job rings between kernel and > user space. Job Rings can now be dynamically bound/unbound > from kernel. > > Changes are made in the following

Re: [RFC] Unaligned CTR mode tests in crypto/testmgr.h

2013-10-29 Thread Herbert Xu
Joel Fernandes wrote: > Hi, > > Some tests such as test 5 in AES CTR mode in crypto/testmgr.h have a unaligned > input buffer size such as 499 which is not aligned to any > 0 power of 2. > > Due to this, omap-aes driver, and I think atmel-aes too error out when > encryption is requested for thes

[RFC] Unaligned CTR mode tests in crypto/testmgr.h

2013-10-29 Thread Joel Fernandes
Hi, Some tests such as test 5 in AES CTR mode in crypto/testmgr.h have a unaligned input buffer size such as 499 which is not aligned to any > 0 power of 2. Due to this, omap-aes driver, and I think atmel-aes too error out when encryption is requested for these buffers. pr_err("request size is n

[PATCH] crypto: omap-aes: Fix CTR mode counter length

2013-10-29 Thread Joel Fernandes
NIST vectors for CTR mode in testmgr.h assume the entire IV as the counter. To get correct results that match the output of these vectors, we need to set the counter length correctly. Signed-off-by: Joel Fernandes --- drivers/crypto/omap-aes.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-

Re: [PATCH] CPU Jitter RNG: inclusion into kernel crypto API and /dev/random

2013-10-29 Thread Stephan Mueller
Am Dienstag, 29. Oktober 2013, 15:00:31 schrieb Stephan Mueller: Hi Ted, >Am Dienstag, 29. Oktober 2013, 09:24:48 schrieb Theodore Ts'o: > >Hi Theodore, > >>On Tue, Oct 29, 2013 at 09:42:30AM +0100, Stephan Mueller wrote: >>> Based on this suggestion, I now added the tests in Appendix F.46.8 >>>

Re: [PATCH] CPU Jitter RNG: inclusion into kernel crypto API and /dev/random

2013-10-29 Thread Stephan Mueller
Am Dienstag, 29. Oktober 2013, 09:24:48 schrieb Theodore Ts'o: Hi Theodore, >On Tue, Oct 29, 2013 at 09:42:30AM +0100, Stephan Mueller wrote: >> Based on this suggestion, I now added the tests in Appendix F.46.8 >> where I disable the caches and the tests in Appendix F.46.9 where I >> disable the

Re: [PATCH] CPU Jitter RNG: inclusion into kernel crypto API and /dev/random

2013-10-29 Thread Theodore Ts'o
On Tue, Oct 29, 2013 at 09:42:30AM +0100, Stephan Mueller wrote: > Based on this suggestion, I now added the tests in Appendix F.46.8 where > I disable the caches and the tests in Appendix F.46.9 where I disable > the caches and interrupts. What you've added in F.46 is a good start, but as a sug

Re: [PATCH] CPU Jitter RNG: inclusion into kernel crypto API and /dev/random

2013-10-29 Thread Stephan Mueller
Am Montag, 28. Oktober 2013, 17:45:49 schrieb Theodore Ts'o: Hi Theodore, first of all, thank you for your thoughts. And, before we continue any discussion, please consider that all the big testing that is done to analyze the jitter so far did (a) not include any whitening schema (cryptographi