[PATCH] crypto: dcp: Check the return value from devm_ioremap_resource()

2013-09-23 Thread Fabio Estevam
From: Fabio Estevam devm_ioremap_resource() may fail, so better check its return value and propagate it in the case of error. Signed-off-by: Fabio Estevam --- drivers/crypto/dcp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/crypto/dcp.c b/drivers/crypto/dcp.c index 7b77c84..2

Re: [PATCH 1/3] crypto: dcp - Use devm_ioremap_resource()

2013-09-23 Thread Herbert Xu
On Sun, Sep 22, 2013 at 02:42:25PM -0300, Fabio Estevam wrote: > From: Fabio Estevam > > Using devm_ioremap_resource() can make the code simpler and smaller. > > When devm_ioremap_resource() is used there is no need to explicitely check > the > error returned by platform_get_resource(). > > S

Re: [PATCH v3 0/2] crypto: move ablk_helper out of arch/x86

2013-09-23 Thread Herbert Xu
On Fri, Sep 20, 2013 at 09:55:39AM +0200, Ard Biesheuvel wrote: > v3: > - added generic and x86 versions of containing may_use_simd(), > and > use it to decide whether to take the sync or the async path > > v2: > - whitespace fix > - split into two patches so that the first one applies cleanly

Re: [PATCH] ansi_cprng: Fix off by one error in non-block size request

2013-09-23 Thread Herbert Xu
On Tue, Sep 17, 2013 at 08:33:11AM -0400, Neil Horman wrote: > Stephan Mueller reported to me recently a error in random number generation in > the ansi cprng. If several small requests are made that are less than the > instances block size, the remainder for loop code doesn't increment > rand_data

Re: [PATCH v2] crypto: caam - map src buffer before access

2013-09-23 Thread Herbert Xu
On Wed, Sep 11, 2013 at 07:24:06PM +, Yashpal Dutta wrote: > KMap the buffers before copying trailing bytes during hmac into a session > temporary buffer. This is required if pinned buffer from user-space is send > during hmac and is safe even if hmac request is generated from within kernel. >

Re: [PATCH 1/3] crypto: mv_cesa - Staticize local symbols

2013-09-23 Thread Herbert Xu
On Fri, Sep 13, 2013 at 05:06:45PM +0530, Sachin Kamat wrote: > Local symbols used only in this file are made static. > > Signed-off-by: Sachin Kamat > Cc: Sebastian Andrzej Siewior All applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gond

Re: [PATCH] ARM: tegra: remove tegra_chip_uid()

2013-09-23 Thread Herbert Xu
On Mon, Sep 16, 2013 at 09:34:19AM -0600, Stephen Warren wrote: > From: Stephen Warren > > Following commit f5b38c5 "crypto: tegra - use kernel entropy instead > of ad-hoc", this function is no longer used. It's also only accurate > for Tegra20 and not later SoCs. So, remove it. > > Signed-off-b

Re: [PATCH 1/2] crypto: tegra-aes - Fix NULL pointer dereference

2013-09-23 Thread Herbert Xu
On Mon, Sep 16, 2013 at 09:01:10AM +0530, Sachin Kamat wrote: > 'dd' is tested for NULL. However, it is derefenced in the error > message print. Change the print to pr_err to avoid this. > > Signed-off-by: Sachin Kamat Both patches applied. -- Email: Herbert Xu Home Page: http://gondor.apana.o

Re: [PATCH 36/51] DMA-API: usb: use dma_set_coherent_mask()

2013-09-23 Thread Russell King - ARM Linux
On Mon, Sep 23, 2013 at 02:27:39PM -0400, Alan Stern wrote: > On Thu, 19 Sep 2013, Russell King wrote: > > > The correct way for a driver to specify the coherent DMA mask is > > not to directly access the field in the struct device, but to use > > dma_set_coherent_mask(). Only arch and bus code s

Re: [PATCH v4] crypto: caam - map src buffer before access

2013-09-23 Thread Kim Phillips
On Sat, 21 Sep 2013 14:26:35 +0530 Yashpal Dutta wrote: > KMap the buffers before copying trailing bytes during hmac into a session > temporary buffer. This is required if pinned buffer from user-space is send > during hmac and is safe even if hmac request is generated from within kernel. it may

Re: [PATCH V4 02/15] asymmetric keys: implement EMSA_PKCS1-v1_5-ENCODE in rsa

2013-09-23 Thread Phil Carmody
On Sun, Sep 15, 2013 at 08:56:48AM +0800, Lee, Chun-Yi wrote: > Implement EMSA_PKCS1-v1_5-ENCODE [RFC3447 sec 9.2] in rsa.c. It's the > first step of signature generation operation (RSASSA-PKCS1-v1_5-SIGN). > > This patch is temporary set emLen to pks->k, and temporary set EM to > pks->S for debug

Re: Asymmetric cryptography HW offloading

2013-09-23 Thread Nikos Mavrogiannopoulos
On 09/23/2013 02:31 PM, Horia Geantă wrote: > Hi, > > CAAM crypto engine (drivers/crypto/caam/*) is capable of asymmetric > operations, like: modular exponentiation, RSA > sign/verify/encrypt/decrypt, (EC)DSA sign etc. > I would appreciate some design guidelines on how to harness these > capabilit

Re: [PATCH 37/51] DMA-API: usb: use new dma_coerce_mask_and_coherent()

2013-09-23 Thread Nicolas Ferre
On 20/09/2013 00:02, Russell King : Signed-off-by: Russell King --- drivers/usb/chipidea/ci_hdrc_imx.c |4 +--- drivers/usb/dwc3/dwc3-exynos.c |4 +--- drivers/usb/host/ehci-atmel.c |4 +--- For Atmel driver: Acked-by: Nicolas Ferre [..] diff --git a/drivers/usb/ho

Asymmetric cryptography HW offloading

2013-09-23 Thread Horia Geantă
Hi, CAAM crypto engine (drivers/crypto/caam/*) is capable of asymmetric operations, like: modular exponentiation, RSA sign/verify/encrypt/decrypt, (EC)DSA sign etc. I would appreciate some design guidelines on how to harness these capabilities, for crypto engines in general. 1. In-kernel int

Re: [PATCH 36/51] DMA-API: usb: use dma_set_coherent_mask()

2013-09-23 Thread Nicolas Ferre
On 20/09/2013 00:01, Russell King : The correct way for a driver to specify the coherent DMA mask is not to directly access the field in the struct device, but to use dma_set_coherent_mask(). Only arch and bus code should access this member directly. Convert all direct write accesses to using t

Re: [alsa-devel] [PATCH 43/51] DMA-API: dma: edma.c: no need to explicitly initialize DMA masks

2013-09-23 Thread Russell King - ARM Linux
On Mon, Sep 23, 2013 at 03:55:33PM +0530, Vinod Koul wrote: > On Fri, Sep 20, 2013 at 12:15:39AM +0100, Russell King wrote: > > register_platform_device_full() can setup the DMA mask provided the > > appropriate member is set in struct platform_device_info. So lets > > make that be the case. This

Re: [alsa-devel] [PATCH 24/51] DMA-API: dma: pl330: add dma_set_mask_and_coherent() call

2013-09-23 Thread Vinod Koul
On Sat, Sep 21, 2013 at 09:00:00PM +0100, Russell King - ARM Linux wrote: > On Fri, Sep 20, 2013 at 07:26:27PM +0200, Heiko Stübner wrote: > > Am Donnerstag, 19. September 2013, 23:49:01 schrieb Russell King: > > > The DMA API requires drivers to call the appropriate dma_set_mask() > > > functions

Re: [alsa-devel] [PATCH 43/51] DMA-API: dma: edma.c: no need to explicitly initialize DMA masks

2013-09-23 Thread Vinod Koul
On Fri, Sep 20, 2013 at 12:15:39AM +0100, Russell King wrote: > register_platform_device_full() can setup the DMA mask provided the > appropriate member is set in struct platform_device_info. So lets > make that be the case. This avoids a direct reference to the DMA > masks by this driver. > > S

Re: [alsa-devel] [PATCH 23/51] DMA-API: dma: pl08x: add dma_set_mask_and_coherent() call

2013-09-23 Thread Vinod Koul
On Thu, Sep 19, 2013 at 10:48:01PM +0100, Russell King wrote: > The DMA API requires drivers to call the appropriate dma_set_mask() > functions before doing any DMA mapping. Add this required call to > the AMBA PL08x driver. > > Signed-off-by: Russell King Acked-by: Vinod Koul ~Vinod > --- >

Re: [PATCH 4/4] ARM: add support for bit sliced AES using NEON instructions

2013-09-23 Thread Ard Biesheuvel
On 22 September 2013 13:12, Jussi Kivilinna wrote: [...] > Decryption can probably be made faster by implementing InvMixColumns slightly > differently. Instead of implementing inverse MixColumns matrix directly, use > preprocessing step, followed by MixColumns as described in section "4.1.3 > De