Re: Questions about the Crypto API

2013-08-09 Thread Herbert Xu
On Sat, Aug 10, 2013 at 02:15:10AM +, Hsieh, Che-Min wrote: > > >> . IOW we don't currently provide a kill mechanism to the user. > > Good. Tcrypt.c and Testmgr is only a bad example? Right, they can't really do anything other than waiting so they're not a realistic example. For a good exam

RE: Questions about the Crypto API

2013-08-09 Thread Hsieh, Che-Min
Thanks for Herbert response to my burning questions. Please see my follow on comments. Please correct me if my comments are not correct. >> You should use your own list element This is the conclusion I reached when I looked into our problem. I looked at other drivers and tailtos driver. I beli

Re: Questions about the Crypto API

2013-08-09 Thread Herbert Xu
On Thu, Aug 08, 2013 at 02:04:05PM +, Hsieh, Che-Min wrote: > Thanks for Marcelo and Herbert for the questions and answers. > I have a few more questions related to the same subject of API. > > 1. In the crypto_async_request, is the list element available to the driver > to use? I see most

Re: Questions about the Crypto API

2013-08-09 Thread Herbert Xu
On Fri, Aug 09, 2013 at 01:09:12PM +, Hsieh, Che-Min wrote: > Marcelo/Herbert: > > I believe It is. Herbert, please correct me if I am wrong. > A single tfm is used as a user context to crypto, so to speak. But a user is > not a thread. > Let us use ipsec as example. > For each security assoc

Re: [PATCH 2/4] crypto: omap-sham: Add OMAP5/AM43XX SHAM Support

2013-08-09 Thread Mark Rutland
On Fri, Jul 26, 2013 at 07:59:15AM +0100, Lokesh Vutla wrote: > Add support for the OMAP5 version of the SHAM module > that is present on OMAP5 and AM43xx SoCs. > > This module is very simialar to OMAP4 version of SHAM module, > and adds SHA384 SHA512 hardware-accelerated hash functions to it. > T

Re: Questions about the Crypto API

2013-08-09 Thread Marcelo Cerri
On Thu, Aug 08, 2013 at 02:50:41PM +, Garg Vakul-B16394 wrote: > Hi Herbert > > > > -Original Message- > > From: linux-crypto-ow...@vger.kernel.org [mailto:linux-crypto- > > ow...@vger.kernel.org] On Behalf Of Herbert Xu > > Sent: Tuesday, August 06, 2013 12:30 PM > > To: Marcelo Cerr

[PATCH 2/2] crypto: crypto4xx - Staticize local symbols

2013-08-09 Thread Jingoo Han
These local symbols are used only in this file. Fix the following sparse warnings: drivers/crypto/amcc/crypto4xx_alg.c:35:6: warning: symbol 'set_dynamic_sa_command_0' was not declared. Should it be static? drivers/crypto/amcc/crypto4xx_alg.c:55:6: warning: symbol 'set_dynamic_sa_command_1' was

[PATCH 1/2] crypto: sahara - Staticize local symbol

2013-08-09 Thread Jingoo Han
This local symbol is used only in this file. Fix the following sparse warnings: drivers/crypto/sahara.c:420:6: warning: symbol 'sahara_watchdog' was not declared. Should it be static? Signed-off-by: Jingoo Han --- drivers/crypto/sahara.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-)