Re: [PATCH v2] drivers/crypto/nx: saves chaining value from co-processor

2013-08-08 Thread Herbert Xu
On Wed, Aug 07, 2013 at 06:15:50PM -0500, Fionnuala Gunter wrote: > This patch fixes a bug that is triggered when cts(cbc(aes)) is used with > nx-crypto driver on input larger than 32 bytes. > > The chaining value from co-processor was not being saved. This value is > needed because it is used as

Re: [PATCH 0/6] hwrng: OMAP: Updates for OMAP RNG module

2013-08-08 Thread Herbert Xu
On Mon, Aug 05, 2013 at 08:17:17PM +0530, Lokesh Vutla wrote: > This patch series adds support for OMAP4 version of RNG module. > This module produce a 64 bit random number and also allows to > de tune FROs when repeated pattern is coming out of FROs. > This series also has few fixes for the driver

Re: [PATCH v2 0/2] drivers/crypto/nx: fixes when input data is too large

2013-08-08 Thread Herbert Xu
On Fri, Aug 02, 2013 at 12:09:50PM +, Marcelo Cerri wrote: > This series of patches fixes two bugs that are triggered when the input data > is > too large. The first one is caused by the miscalculation of physical addresses > and the second one by some limits that the co-processor has to the i

Re: [PATCH v2] drivers/crypto/nx: saves chaining value from co-processor

2013-08-08 Thread Herbert Xu
On Fri, Aug 09, 2013 at 04:25:04PM +1000, Benjamin Herrenschmidt wrote: > On Wed, 2013-08-07 at 18:15 -0500, Fionnuala Gunter wrote: > > This patch fixes a bug that is triggered when cts(cbc(aes)) is used with > > nx-crypto driver on input larger than 32 bytes. > > > > The chaining value from co-p

Re: [PATCH v2] drivers/crypto/nx: saves chaining value from co-processor

2013-08-08 Thread Benjamin Herrenschmidt
On Wed, 2013-08-07 at 18:15 -0500, Fionnuala Gunter wrote: > This patch fixes a bug that is triggered when cts(cbc(aes)) is used with > nx-crypto driver on input larger than 32 bytes. > > The chaining value from co-processor was not being saved. This value is > needed because it is used as the IV

Re: [PATCH 0/3] ARM: dts: mxs: dcp cleanup patches

2013-08-08 Thread Kumar Gala
On Aug 8, 2013, at 8:30 AM, Lothar Waßmann wrote: > This patch series does the following: > > - let the driver be "disabled" by default in imx28.dtsi > - coding style cleanups in drivers/crypto/dcp.c > - use the "official" 'fsl,' prefix in the 'compatible' property > > The last patch adds a new

Re: [PATCH 3/3] crypto: dcp: rename 'compatible' property to 'fsl,dcp'

2013-08-08 Thread Sergei Shtylyov
Hello. On 08/08/2013 05:30 PM, Lothar Waßmann wrote: Leave the old 'fsl-dcp' value in place with an appropriate comment until external users have updated their DTBs. Signed-off-by: Lothar Waßmann --- arch/arm/boot/dts/imx28.dtsi |2 +- drivers/crypto/dcp.c |2 ++ 2 files

RE: Questions about the Crypto API

2013-08-08 Thread Garg Vakul-B16394
Hi Herbert > -Original Message- > From: linux-crypto-ow...@vger.kernel.org [mailto:linux-crypto- > ow...@vger.kernel.org] On Behalf Of Herbert Xu > Sent: Tuesday, August 06, 2013 12:30 PM > To: Marcelo Cerri > Cc: linux-crypto@vger.kernel.org > Subject: Re: Questions about the Crypto API

[PATCH 3/3] crypto: dcp: rename 'compatible' property to 'fsl,dcp'

2013-08-08 Thread Lothar Waßmann
Leave the old 'fsl-dcp' value in place with an appropriate comment until external users have updated their DTBs. Signed-off-by: Lothar Waßmann --- arch/arm/boot/dts/imx28.dtsi |2 +- drivers/crypto/dcp.c |2 ++ 2 files changed, 3 insertions(+), 1 deletions(-) diff --git a/arch/a

[PATCH 0/3] ARM: dts: mxs: dcp cleanup patches

2013-08-08 Thread Lothar Waßmann
This patch series does the following: - let the driver be "disabled" by default in imx28.dtsi - coding style cleanups in drivers/crypto/dcp.c - use the "official" 'fsl,' prefix in the 'compatible' property The last patch adds a new entry to the of_match_table of the driver, so that current DT blo

RE: Questions about the Crypto API

2013-08-08 Thread Hsieh, Che-Min
Thanks for Marcelo and Herbert for the questions and answers. I have a few more questions related to the same subject of API. 1. In the crypto_async_request, is the list element available to the driver to use? I see most of drivers do "crypto_enqueue_request()" to keep track of the outstandin

[PATCH 1/3] ARM: dts: mxs: set dcp to "disabled" by default

2013-08-08 Thread Lothar Waßmann
Reintroduce 'status = "disabled"' for the dcp node that was dropped by commit 519d8b1a "Added support for Freescale's DCP co-processor". Explicitly enable it in imx28-evk which is referenced in the commit message of that commit. Signed-off-by: Lothar Waßmann --- arch/arm/boot/dts/imx28-evk.dts

[PATCH 2/3] crypto: dcp - cleanup: commas at end of struct initializers where appropriate

2013-08-08 Thread Lothar Waßmann
Signed-off-by: Lothar Waßmann --- drivers/crypto/dcp.c | 11 +-- 1 files changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/crypto/dcp.c b/drivers/crypto/dcp.c index a8a7dd4..6a2495e 100644 --- a/drivers/crypto/dcp.c +++ b/drivers/crypto/dcp.c @@ -651,8 +651,7 @@ static str

Re: [PATCH v2] drivers/crypto/nx: saves chaining value from co-processor

2013-08-08 Thread Michael Ellerman
Hi Fin, I don't know anything about crypto so I can only critique you on your patch submission technique :) ... On Wed, Aug 07, 2013 at 06:15:50PM -0500, Fionnuala Gunter wrote: > This patch fixes a bug that is triggered when cts(cbc(aes)) is used with > nx-crypto driver on input larger than 32