RE: [PATCH] crypto: remove double execution of the same test suite

2013-07-18 Thread Gupta Ruchika-R66431
Reviewed-by: Ruchika Gupta > -Original Message- > From: linux-crypto-ow...@vger.kernel.org [mailto:linux-crypto- > ow...@vger.kernel.org] On Behalf Of Cristian Stoica > Sent: Thursday, July 18, 2013 9:27 PM > To: herb...@gondor.hengli.com.au > Cc: da...@davemloft.net; linux-crypto@vger.ke

Re: [PATCH] crypto: remove double execution of the same test suite

2013-07-18 Thread Horia Geantă
On 7/18/2013 6:57 PM, Cristian Stoica wrote: This patch removes redundant execution of the same test suite in cases where alg and driver variables are the same (e.g. when alg_test is called from tcrypt_test) Signed-off-by: Cristian Stoica Reviewed-by: Horia Geanta --- crypto/testmgr.c |

Re: [PATCH 3.11-rc1] crypto: Fix boot failure due to module dependency.

2013-07-18 Thread H. Peter Anvin
On 07/18/2013 03:17 PM, Rafael J. Wysocki wrote: >> >> alias x86cpu:vendor:*:family:*:model:*:feature:*0081* crct10dif_pclmul >> >> This should cause udev to load the crct10dif_pclml module when cpu >> support the PCLMULQDQ (feature code 0081). I did my testing during >> development on 3.10 and th

Re: [PATCH 3.11-rc1] crypto: Fix boot failure due to module dependency.

2013-07-18 Thread Tim Chen
On Fri, 2013-07-19 at 00:17 +0200, Rafael J. Wysocki wrote: > On 7/18/2013 11:00 PM, Tim Chen wrote: > > On Thu, 2013-07-18 at 12:47 +0900, Tetsuo Handa wrote: > >> Tim Chen wrote: > > Your approach is quite complicated. I think something simpler like the > > following will work: > We

Re: [PATCH 3.11-rc1] crypto: Fix boot failure due to module dependency.

2013-07-18 Thread Rafael J. Wysocki
On 7/18/2013 11:00 PM, Tim Chen wrote: On Thu, 2013-07-18 at 12:47 +0900, Tetsuo Handa wrote: Tim Chen wrote: Your approach is quite complicated. I think something simpler like the following will work: We cannot benefit from PCLMULQDQ. Is it acceptable for you? The following code in crct10d

Re: [PATCH 3.11-rc1] crypto: Fix boot failure due to module dependency.

2013-07-18 Thread Tim Chen
On Thu, 2013-07-18 at 12:47 +0900, Tetsuo Handa wrote: > Tim Chen wrote: > > > > Your approach is quite complicated. I think something simpler like the > > > > following will work: > > > > > > We cannot benefit from PCLMULQDQ. Is it acceptable for you? > > > > > > The following code in crct10dif

[PATCH] crypto: remove double execution of the same test suite

2013-07-18 Thread Cristian Stoica
This patch removes redundant execution of the same test suite in cases where alg and driver variables are the same (e.g. when alg_test is called from tcrypt_test) Signed-off-by: Cristian Stoica --- crypto/testmgr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crypto/testmg