Re: [PATCH 2/3 v2] Optimize CRC32C calculation with PCLMULQDQ instruction

2013-02-26 Thread Herbert Xu
On Tue, Feb 26, 2013 at 08:57:41AM -0800, Tim Chen wrote: > > BTW, Herbert, I've also sent you a patch a few days ago to update the > link to the whitepaper on the CRC32C algorithm in the code. Wonder if > you have received it. Thanks. Tim it's in my queue. Cheers, -- Email: Herbert Xu Home P

Re: [PATCH v3 2/2] omap-aes: Use pm_runtime_put instead of pm_runtime_put_sync in tasklet

2013-02-26 Thread Mark A. Greer
On Tue, Feb 26, 2013 at 10:04:32AM -0600, agnel.j...@gmail.com wrote: > From: Joel A Fernandes > > After DMA is complete, the omap_aes_finish_req function is called as > a part of the done_task tasklet. During this its atomic and any calls > to pm functions should not assume they wont sleep. > >

Re: [PATCH v3 1/2] omap-sham: Use pm_runtime_put instead of pm_runtime_put_sync in tasklet

2013-02-26 Thread Mark A. Greer
On Tue, Feb 26, 2013 at 10:04:31AM -0600, agnel.j...@gmail.com wrote: > From: Joel A Fernandes > > After DMA is complete, the omap_sham_finish_req function is called as > a part of the done_task tasklet. During this its atomic and any calls > to pm functions should not assume they wont sleep. >

ahash and crc32c

2013-02-26 Thread Zeev Zilberman
Hi, I'm working on an ahash driver that supports CRC32C. I saw that all existing CRC32C implementations (except blackfin) are implementing shash interface, but ahash seems to be the correct choice in our case. On the other hand I saw that CRC32C test in testmgr.c tries to create shash tfm for CRC3

Re: [PATCH 2/3 v2] Optimize CRC32C calculation with PCLMULQDQ instruction

2013-02-26 Thread Tim Chen
On Tue, 2013-02-26 at 17:54 +0800, Herbert Xu wrote: > On Thu, Sep 27, 2012 at 03:44:22PM -0700, Tim Chen wrote: > > This patch adds the crc_pcl function that calculates CRC32C checksum using > > the > > PCLMULQDQ instruction on processors that support this feature. This will > > provide speedup o

[PATCH v3 2/2] omap-aes: Use pm_runtime_put instead of pm_runtime_put_sync in tasklet

2013-02-26 Thread agnel . joel
From: Joel A Fernandes After DMA is complete, the omap_aes_finish_req function is called as a part of the done_task tasklet. During this its atomic and any calls to pm functions should not assume they wont sleep. The patch replaces a call to pm_runtime_put_sync (which can sleep) with pm_runtime_

[PATCH v3 1/2] omap-sham: Use pm_runtime_put instead of pm_runtime_put_sync in tasklet

2013-02-26 Thread agnel . joel
From: Joel A Fernandes After DMA is complete, the omap_sham_finish_req function is called as a part of the done_task tasklet. During this its atomic and any calls to pm functions should not assume they wont sleep. The patch replaces a call to pm_runtime_put_sync (which can sleep) with pm_runtime

Re: [PATCH 2/3] crypto: sahara: Add driver for SAHARA2 accelerator.

2013-02-26 Thread javier Martin
Hi Arnaud, thank you for your feedback. Sorry, I always forget to test my drivers as modules. I'll address the issues you pointed out, as well as the improvements suggested by Arnd, for v2. Regards. On 23 February 2013 21:16, Arnaud Patard wrote: > Javier Martin writes: > > Hi, > >> SAHARA2 HW

Re: [PATCH 2/3 v2] Optimize CRC32C calculation with PCLMULQDQ instruction

2013-02-26 Thread Herbert Xu
On Thu, Sep 27, 2012 at 03:44:22PM -0700, Tim Chen wrote: > This patch adds the crc_pcl function that calculates CRC32C checksum using the > PCLMULQDQ instruction on processors that support this feature. This will > provide speedup over using CRC32 instruction only. > The usage of PCLMULQDQ necessi