Re: [PATCH] crypto: fix FTBFS with ARM SHA1-asm and THUMB2_KERNEL

2013-01-21 Thread Jussi Kivilinna
Quoting Jussi Kivilinna : Quoting Matt Sealey : This question is to the implementor/committer (Dave McCullough), how exactly did you measure the benchmark and can we reproduce it on some other ARM box? If it's long and laborious and not so important to test the IPsec tunnel use-case, what wou

Re: [PATCH] crypto: fix FTBFS with ARM SHA1-asm and THUMB2_KERNEL

2013-01-21 Thread Jussi Kivilinna
Quoting Matt Sealey : This question is to the implementor/committer (Dave McCullough), how exactly did you measure the benchmark and can we reproduce it on some other ARM box? If it's long and laborious and not so important to test the IPsec tunnel use-case, what would be the simplest possible

Re: [PATCH] crypto: fix FTBFS with ARM SHA1-asm and THUMB2_KERNEL

2013-01-21 Thread Matt Sealey
On Mon, Jan 21, 2013 at 4:46 PM, Nicolas Pitre wrote: > On Mon, 21 Jan 2013, Matt Sealey wrote: > >> The optimized assembler SHA1 code for ARM does not conform to Thumb2 >> register usage requirements, so it cannot be built when the kernel is >> configured with THUMB2_KERNEL. >> >> Fix the FTBFS f

Re: [PATCH] crypto: fix FTBFS with ARM SHA1-asm and THUMB2_KERNEL

2013-01-21 Thread Nicolas Pitre
On Mon, 21 Jan 2013, Matt Sealey wrote: > The optimized assembler SHA1 code for ARM does not conform to Thumb2 > register usage requirements, so it cannot be built when the kernel is > configured with THUMB2_KERNEL. > > Fix the FTBFS for now by preventing misconfigurations of the kernel. > > Sig

Re: [PATCH 7/15] drivers/crypto/atmel-aes.c: adjust duplicate test

2013-01-21 Thread David Miller
From: Julia Lawall Date: Mon, 21 Jan 2013 14:02:51 +0100 > From: Julia Lawall > > Delete successive tests to the same location. The code tested the result > of a previous allocation, that itself was already tested. It is changed to > test the result of the most recent allocation. > > A simpl

Re: [PATCH] CMAC support for CryptoAPI, fixed patch issues, indent, and testmgr build issues

2013-01-21 Thread David Dillow
I hesitate to reward the squeaky wheel, but in the community spirit, here goes... Please fix the subject for future submissions. The subject should be a short, one line description of the patch. It helps if the subject includes the section of the code you are affecting. Also, if you are resending

[PATCH] crypto: fix FTBFS with ARM SHA1-asm and THUMB2_KERNEL

2013-01-21 Thread Matt Sealey
The optimized assembler SHA1 code for ARM does not conform to Thumb2 register usage requirements, so it cannot be built when the kernel is configured with THUMB2_KERNEL. Fix the FTBFS for now by preventing misconfigurations of the kernel. Signed-off-by: Matt Sealey --- crypto/Kconfig |2 +-

Re: [PATCH] CMAC support for CryptoAPI, fixed patch issues, indent, and testmgr build issues

2013-01-21 Thread David Dillow
[Apologies for the dupe, fixing stupid typo for netdev address... -ENOCAFFEINE] I hesitate to reward the squeaky wheel, but in the community spirit, here goes... Please fix the subject for future submissions. The subject should be a short, one line description of the patch. It helps if the subjec

[PATCH] CMAC support for CryptoAPI, fixed patch issues, indent, and testmgr build issues

2013-01-21 Thread Tom St Denis
Hey all, Here's an updated patch which addresses a couple of build issues and coding style complaints. I still can't get it to run via testmgr I get [ 162.407807] alg: No test for cmac(aes) (cmac(aes-generic)) Despite the fact I have an entry for cmac(aes) (much like xcbc(aes)...). Here's

[PATCH 7/15] drivers/crypto/atmel-aes.c: adjust duplicate test

2013-01-21 Thread Julia Lawall
From: Julia Lawall Delete successive tests to the same location. The code tested the result of a previous allocation, that itself was already tested. It is changed to test the result of the most recent allocation. A simplified version of the semantic match that finds this problem is as follows