Re: [PATCH v4 7/8] crypto: omap-sham: Add code to use dmaengine API

2012-11-20 Thread Tony Lindgren
* Mark A. Greer [121119 10:58]: > @@ -27,6 +29,10 @@ > #include > #include > #include > +#ifndef OMAP_SHAM_DMA_PRIVATE > +#include > +#include > +#endif > #include > #include > #include I think you should be able to drop the OMAP_SHAM_DMA_PRIVATE from the include after I'll post one

Re: [PATCH 4/7] crypto: omap-aes: Remove cpu_is/omap_type check from driver

2012-11-20 Thread Tony Lindgren
* Mark A. Greer [121119 11:06]: > From: "Mark A. Greer" > > The omap-aes driver should not check the CPU class or the > type of OMAP device its on. The platform code should do > that instead. Similar patch for this one too should be queued already. Regards, Tony > Signed-off-by: Mark A. Gr

Re: [PATCH v4 5/8] crypto: omap-sham: Remove cpu_is/omap_type check from driver

2012-11-20 Thread Tony Lindgren
* Mark A. Greer [121119 10:58]: > From: "Mark A. Greer" > > The omap-sham driver should not check the CPU class or the > type of OMAP device its on. The platform code should do > that instead. I think I already have a similar patch queued in linux next. Regards, Tony > CC: Paul Walmsley >

[PATCH] crypto: testmgr - remove superfluous initializers for xts(aes)

2012-11-20 Thread Mathias Krause
The test vectors for 'xts(aes)' contain superfluous initializers. Remove them. Signed-off-by: Mathias Krause Cc: Jarod Wilson --- crypto/testmgr.h |4 1 file changed, 4 deletions(-) diff --git a/crypto/testmgr.h b/crypto/testmgr.h index 17db4a9..b5667a4 100644 --- a/crypto/testmgr.h +

Tcrypt hmac(crc32) test can work only on Blackfin

2012-11-20 Thread Milan Broz
Hi, commit a482b081a2d4d74d16bc9ea8779f9f6055f95852 Author: Sonic Zhang Date: Fri May 25 17:54:13 2012 +0800 crypto: testmgr - Add new test cases for Blackfin CRC crypto driver added tcrypt mode=110 test for hmac(crc32) It seems, that this mode is only directly implemented by Blackfin dri

Re: [PATCH 0/7] crypto: omap-aes updates

2012-11-20 Thread Kasatkin, Dmitry
Great. You also worked on AES... Will take a loos asap. On Mon, Nov 19, 2012 at 9:03 PM, Mark A. Greer wrote: > From: "Mark A. Greer" > > This series updates the crypto omap-aes driver and supporting > infrastructure. > > Notes: > > a) Based on omap-sham patches recently submitted, XXX > > b) Si