Re: [PATCH v2 5/7] crypto: omap-sham: Convert to use pm_runtime API

2012-10-25 Thread Kevin Hilman
Hi Mark, "Mark A. Greer" writes: > From: "Mark A. Greer" > > Convert the omap-sham crypto driver to use the > pm_runtime API instead of the clk API. > > CC: Kevin Hilman > CC: Paul Walmsley > CC: Dmitry Kasatkin > Signed-off-by: Mark A. Greer I can't pretend to fully understand this driver

[PATCH] crypto: tegra-aes - fix error-valued pointer dereference

2012-10-25 Thread Wei Yongjun
From: Wei Yongjun clk_put(dd->aes_clk) will dereference an error-valued pointer since the dd->aes_clk is a ERR_PTR() value. The correct check is call clk_put() if !IS_ERR(dd->aes_clk). dpatch engine is used to auto generate this patch. (https://github.com/weiyj/dpatch) Signed-off-by: Wei Yongju

Re: [PATCH] crypto - ablk_helper: add module parameter to allow testing cryptd redirection of requests

2012-10-25 Thread Jussi Kivilinna
Quoting Herbert Xu : On Sun, Oct 21, 2012 at 08:45:29PM +0300, Jussi Kivilinna wrote: Add module parameter to allow forcing redirection of crypto requests to cryptd worker threads. This allows these code paths to be actually tested (easier). Signed-off-by: Jussi Kivilinna Wouldn't this be a