Re: [PATCH] crypto - ablk_helper: add module parameter to allow testing cryptd redirection of requests

2012-10-24 Thread Herbert Xu
On Sun, Oct 21, 2012 at 08:45:29PM +0300, Jussi Kivilinna wrote: > Add module parameter to allow forcing redirection of crypto requests to > cryptd worker threads. This allows these code paths to be actually tested > (easier). > > Signed-off-by: Jussi Kivilinna Wouldn't this be applicable in oth

Re: [PATCH] [v2] crypto: cryptd - disable softirqs in cryptd_queue_worker to prevent data corruption

2012-10-24 Thread Herbert Xu
On Sun, Oct 21, 2012 at 08:42:28PM +0300, Jussi Kivilinna wrote: > cryptd_queue_worker attempts to prevent simultaneous accesses to crypto > workqueue by cryptd_enqueue_request using preempt_disable/preempt_enable. > However cryptd_enqueue_request might be called from softirq context, > so add loca

Re: [PATCH] crypto: fix missing unlock on error case

2012-10-24 Thread Herbert Xu
On Sun, Oct 21, 2012 at 07:56:42PM +0800, Wei Yongjun wrote: > From: Wei Yongjun > > Add the missing unlock on the error handling path in function > tegra_aes_get_random() and tegra_aes_rng_reset(). > > Signed-off-by: Wei Yongjun Patch applied. Thanks. -- Email: Herbert Xu Home Page: http:/

Re: [PATCH 0/5] Avoid stack buffers in glue code of AVX implementations

2012-10-24 Thread Herbert Xu
On Sat, Oct 20, 2012 at 03:06:31PM +0300, Jussi Kivilinna wrote: > Patches modify AVX implementations so that they avoid using extra > stack memory. Stack is not needed since implementation store > blocks in registers. All applied to cryptodev. -- Email: Herbert Xu Home Page: http://gondor.apana

Re: [PATCH 0/6] New test vectors for camellia, blowfish, serpent, aes, des and des3_ede

2012-10-24 Thread Herbert Xu
On Sat, Oct 20, 2012 at 01:51:10PM -0400, David Miller wrote: > From: Jussi Kivilinna > Date: Sat, 20 Oct 2012 14:52:41 +0300 > > > Test vectors for camellia, blowfish and serpent are expanded for future > > implementations. > > > > New test vectors for aes, des and des3_ede are added to test ex

Re: [PATCH 2/3] crypto: camellia-x86_64 - share common functions and move structures and function definitions to header file

2012-10-24 Thread Jussi Kivilinna
I guess yesterday was one of those days, when nothing goes right. Obviously this patch is missing the header file that was split from camellia_glue.c. On top of that I managed to overwrite the not-commited header file when rebasing AVX2 patchset on top of these. So after remaking this patch, I ne