Re: [patch v3 02/11] inet_diag: pass inet_diag module to netlink_dump_start

2012-10-03 Thread Eric Dumazet
On Thu, 2012-10-04 at 12:41 +0800, Gao feng wrote: > set netlink_dump_control.module to avoid panic. > > Signed-off-by: Gao feng > --- > net/ipv4/inet_diag.c |2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/net/ipv4/inet_diag.c b/net/ipv4/inet_diag.c > index 535584

[patch v3 02/11] inet_diag: pass inet_diag module to netlink_dump_start

2012-10-03 Thread Gao feng
set netlink_dump_control.module to avoid panic. Signed-off-by: Gao feng --- net/ipv4/inet_diag.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/net/ipv4/inet_diag.c b/net/ipv4/inet_diag.c index 535584c..5ffd7bc 100644 --- a/net/ipv4/inet_diag.c +++ b/net/ipv4/inet_diag

[patch v3 03/11] unix_diag: pass unix_diag module to netlink_dump_start

2012-10-03 Thread Gao feng
set netlink_dump_control.module to avoid panic. Signed-off-by: Gao feng --- net/unix/diag.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/net/unix/diag.c b/net/unix/diag.c index 06748f1..e1cd31f 100644 --- a/net/unix/diag.c +++ b/net/unix/diag.c @@ -299,6 +299,7 @@ sta

[patch v3 05/11] nfnetlink_acct: pass nfnetlink_acct module to netlink_dump_start

2012-10-03 Thread Gao feng
set netlink_dump_control.module to avoid panic. Signed-off-by: Gao feng --- net/netfilter/nfnetlink_acct.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/net/netfilter/nfnetlink_acct.c b/net/netfilter/nfnetlink_acct.c index 589d686..8acf8b8 100644 --- a/net/netfilter/nf

[patch v3 09/11] xfrm: pass xfrm_user module to netlink_dump_start

2012-10-03 Thread Gao feng
set netlink_dump_control.module to avoid panic. Signed-off-by: Gao feng --- net/xfrm/xfrm_user.c |8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/net/xfrm/xfrm_user.c b/net/xfrm/xfrm_user.c index 421f984..3d909f7 100644 --- a/net/xfrm/xfrm_user.c +++ b/net/xfrm/xfr

[patch v3 10/11] ipset: pass ipset module to netlink_dump_start

2012-10-03 Thread Gao feng
set netlink_dump_control.module to avoid panic. Signed-off-by: Gao feng Cc: Jozsef Kadlecsik --- net/netfilter/ipset/ip_set_core.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/net/netfilter/ipset/ip_set_core.c b/net/netfilter/ipset/ip_set_core.c index 778465f..6f2b5

[patch v3 11/11] infiniband: pass rdma_cm module to netlink_dump_start

2012-10-03 Thread Gao feng
set netlink_dump_control.module to avoid panic. Signed-off-by: Gao feng Cc: Roland Dreier Cc: Sean Hefty --- drivers/infiniband/core/cma.c |3 ++- drivers/infiniband/core/netlink.c |1 + include/rdma/rdma_netlink.h |1 + 3 files changed, 4 insertions(+), 1 deletions(-) d

[patch v3 08/11] crypto: pass crypto_user module to netlink_dump_start

2012-10-03 Thread Gao feng
set netlink_dump_control.done to avoid panic. Signed-off-by: Gao feng Cc: Herbert Xu --- crypto/crypto_user.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/crypto/crypto_user.c b/crypto/crypto_user.c index 6bba414..f08297b 100644 --- a/crypto/crypto_user.c +++ b/c

[patch v3 04/11] nf_conntrack_netlink: pass nf_conntrack_netlink module to netlink_dump_start

2012-10-03 Thread Gao feng
set netlink_dump_control.module to avoid panic. Signed-off-by: Gao feng --- net/netfilter/nf_conntrack_netlink.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/net/netfilter/nf_conntrack_netlink.c b/net/netfilter/nf_conntrack_netlink.c index 7bbfb3d..20af287 100644

[patch v3 01/11] netlink: add reference of module in netlink_dump_start

2012-10-03 Thread Gao feng
I get a panic when I use ss -a and rmmod inet_diag at the same time. it's because netlink_dump use inet_diag_dump witch function belongs to module inet_diag. I search the codes and find many modules have the same problem. We need add reference of the module witch the cb->dump belongs to. Thanks

[patch v3 06/11] nfnetlink_cthelper: pass nfnetlink_cthelper module to netlink_dump_start

2012-10-03 Thread Gao feng
set netlink_dump_control.module to avoid panic. Signed-off-by: Gao feng --- net/netfilter/nfnetlink_cthelper.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/net/netfilter/nfnetlink_cthelper.c b/net/netfilter/nfnetlink_cthelper.c index 945950a..2bcd2d8 100644 --- a/net

[patch v3 07/11] nfnetlink_cttimeout: pass nfnetlink_cttimeout module to netlink_dump_start

2012-10-03 Thread Gao feng
set netlink_dump_control.module to avoid panic. Signed-off-by: Gao feng --- net/netfilter/nfnetlink_cttimeout.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/net/netfilter/nfnetlink_cttimeout.c b/net/netfilter/nfnetlink_cttimeout.c index 8847b4d..e0ab57c 100644 --- a/

Re: [PATCH -next] asymmetric keys: fix printk format warning

2012-10-03 Thread Rusty Russell
Stephen Rothwell writes: > [Lets also cc Rusty who committed the patch ...] > > On Wed, 03 Oct 2012 16:04:46 -0700 Randy Dunlap wrote: >> >> From: Randy Dunlap >> >> Fix printk format warning in x509_cert_parser.c: >> >> crypto/asymmetric_keys/x509_cert_parser.c: In function 'x509_note_OID':

Re: [GIT PULL] Asymmetric keys and module signing

2012-10-03 Thread Rusty Russell
David Howells writes: > Rusty Russell wrote: > >> Right. I think we need to use different names for generated vs supplied >> files > > The problem with supplied files is people who do allyesconfig, allmodconfig > and randconfig just to test things finding that their builds break. The > kernel

Re: [PATCH -next] asymmetric keys: fix printk format warning

2012-10-03 Thread Stephen Rothwell
Cc: Herbert Xu > Cc: linux-crypto@vger.kernel.org > --- > crypto/asymmetric_keys/x509_cert_parser.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- linux-next-20121003.orig/crypto/asymmetric_keys/x509_cert_parser.c > +++ linux-next-20121003/crypto/asymmetric_keys/x50

[PATCH -next] asymmetric keys: fix printk format warning

2012-10-03 Thread Randy Dunlap
;long unsigned int' Builds cleanly on i386 and x86_64. Signed-off-by: Randy Dunlap Cc: David Howells Cc: Herbert Xu Cc: linux-crypto@vger.kernel.org --- crypto/asymmetric_keys/x509_cert_parser.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next-20121003.orig/c

[patch] MODSIGN: Fix build error with strict typechecking

2012-10-03 Thread David Rientjes
"MODSIGN: Provide module signing public keys to the kernel" causes a build error when CONFIG_UIDGID_STRICT_TYPE_CHECKS is enabled: kernel/modsign_pubkey.c: In function 'module_verify_init': kernel/modsign_pubkey.c:47: error: incompatible type for argument 3 of 'key_alloc' include/linux/key.h:195

Re: [PATCH v0] Add SHA-3 hash algorithm

2012-10-03 Thread Jeff Garzik
On 10/03/2012 03:11 AM, Herbert Xu wrote: On Wed, Oct 03, 2012 at 02:53:27AM -0400, Jeff Garzik wrote: Maybe my patch is the best we can do in the current kernel, if dynamic digest size is not currently possible. Register "sha3_224", "sha3_256", ... as you describe, and wait for actual users to

Re: [PATCH v0] Add SHA-3 hash algorithm

2012-10-03 Thread Herbert Xu
On Wed, Oct 03, 2012 at 02:53:27AM -0400, Jeff Garzik wrote: > > Maybe my patch is the best we can do in the current kernel, if > dynamic digest size is not currently possible. Register "sha3_224", > "sha3_256", ... as you describe, and wait for actual users to appear > with unsupported digest size