Re: [PATCH 0/3] Optimize CRC32C calculation using PCLMULQDQ in crc32c-intel module

2012-09-26 Thread Herbert Xu
On Tue, Sep 25, 2012 at 02:50:08PM -0700, Tim Chen wrote: > This patch series optimized CRC32C calculations with PCLMULQDQ > instruction for crc32c-intel module. It speeds up the original > implementation by 1.6x for 1K buffer and by 3x for buffer 4k or > more. The tcrypt module was enhanced for

Re: [PATCH] crypto: tcrypt - add missing tests for camellia and ghash

2012-09-26 Thread Herbert Xu
On Fri, Sep 21, 2012 at 12:12:04PM -0400, David Miller wrote: > From: Jussi Kivilinna > Date: Fri, 21 Sep 2012 10:27:10 +0300 > > > Add missing tests for ctr(camellia), lrw(camellia), xts(camellia) and ghash, > > as these have test vectors available. > > > > Signed-off-by: Jussi Kivilinna > >

Re: [PATCH 2/2] crypto: testmgr - make test_aead also test 'dst != src' code paths

2012-09-26 Thread Herbert Xu
On Fri, Sep 21, 2012 at 12:11:58PM -0400, David Miller wrote: > From: Jussi Kivilinna > Date: Fri, 21 Sep 2012 10:26:52 +0300 > > > Currrently test_aead uses same buffer for destination and source. However > > in any places, 'dst != src' take different path than 'dst == src' case. > > > > Theref

Re: [PATCH] crypto: cast5/avx - fix storing of new IV in CBC encryption

2012-09-26 Thread Herbert Xu
On Wed, Sep 19, 2012 at 02:24:57PM +0300, Jussi Kivilinna wrote: > cast5/avx incorrectly XORs new IV over old IV at end of CBC encryption > function when it should store. This causes CBC encryption to give > incorrect output on multi-page encryption requests. > > Signed-off-by: Jussi Kivilinna P

Re: [PATCH 1/3] crypto: testmgr - allow non-multi page and multi page skcipher tests from same test template

2012-09-26 Thread Herbert Xu
On Wed, Sep 19, 2012 at 09:42:49AM +0300, Jussi Kivilinna wrote: > Allow non-multi page and multi page skcipher tests to be run on same test > template, to avoid > duplicating data. > > Signed-off-by: Jussi Kivilinna All three patches applied. Thanks! -- Email: Herbert Xu Home Page: http://g

Re: [PATCH] crypto: caam - increase TRNG clocks per sample

2012-09-26 Thread Herbert Xu
On Mon, Sep 17, 2012 at 06:21:55PM -0500, Kim Phillips wrote: > we need to configure the TRNG to use more clocks per sample > to handle the two back-to-back 64KiB random descriptor requests > on higher frequency P5040s. > > Signed-off-by: Kim Phillips Patch applied. Thanks! -- Email: Herbert X

Re: [PATCH 1/4] drivers/crypto/ux500/cryp/cryp_core.c: fix error return code

2012-09-26 Thread Herbert Xu
On Mon, Sep 17, 2012 at 07:28:25PM +0200, Peter Senna Tschudin wrote: > From: Peter Senna Tschudin > > Convert a nonnegative error return code to a negative one, as returned > elsewhere in the function. > > A simplified version of the semantic match that finds this problem is as > follows: (http

Re: [PATCH] crypto: caam - fix error IDs for SEC v5.x RNG4

2012-09-26 Thread Herbert Xu
On Sat, Sep 15, 2012 at 03:33:54AM +0300, Horia Geanta wrote: > According to SEC v5.0-v5.3 reference manuals. > > Signed-off-by: Horia Geanta > Acked-by: Kim Phillips Patch applied. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbe

Re: [PATCH] crypto: x86/glue_helper - fix storing of new IV in CBC encryption

2012-09-26 Thread Herbert Xu
On Wed, Sep 19, 2012 at 09:40:30AM +0300, Jussi Kivilinna wrote: > Glue_helper incorrectly XORs new IV over old IV at end of CBC encryption > function when it should store. This causes CBC encryption to give > incorrect output on multi-page encryption requests. > > Signed-off-by: Jussi Kivilinna

Re: [PATCH 0/3] crypto: talitos fixes for 3.6-rc7

2012-09-26 Thread Herbert Xu
On Wed, Sep 19, 2012 at 09:53:37PM +0300, Horia Geanta wrote: > Hi Herbert, > > I know these patches come late and might not be included in 3.6. > But two of them are already sitting in cryptodev tree for some time. > (Don't know where my head was :/). I'm hesitant to put these patches in at this

Re: [GIT PULL] Asymmetric keys and module signing

2012-09-26 Thread Mimi Zohar
On Wed, 2012-09-26 at 13:16 +0930, Rusty Russell wrote: > David Howells writes: > > The module signing patches provide: > > > > - Some fixes to Rusty's patch. Also an additional patch to extend the > > policy > >handling for modules signed with an unknown key and to handle FIPS mode. > > O

Re: [GIT PULL] Asymmetric keys and module signing

2012-09-26 Thread Rusty Russell
David Howells writes: > Rusty Russell wrote: > >> We do a very simple search for a particular string appended to the module >> (which is cache-hot and about to be SHA'd anyway). There's both a config >> option and a boot parameter which control whether we accept (and taint) or >> fail with unsi

Re: [patch v2 04/11] nf_conntrack_netlink: pass nf_conntrack_netlink module to netlink_dump_start

2012-09-26 Thread Gao feng
于 2012年09月26日 23:04, Pablo Neira Ayuso 写道: > On Wed, Sep 26, 2012 at 08:35:53PM +0800, Gao feng wrote: >> 于 2012年09月26日 17:58, Pablo Neira Ayuso 写道: >>> On Wed, Sep 26, 2012 at 05:42:31PM +0800, Gao feng wrote: Hi Pablo: 于 2012年09月26日 17:26, Pablo Neira Ayuso 写道: > On Wed, Sep 26

Re: [PATCH 02/11] inet_diag: pass inet_diag module to netlink_dump_start

2012-09-26 Thread Pablo Neira Ayuso
On Wed, Sep 26, 2012 at 09:07:14AM -0700, Stephen Hemminger wrote: > On Wed, 26 Sep 2012 12:52:11 +0800 > Gao feng wrote: > > > struct netlink_dump_control c = { > > .dump = inet_diag_dump_compat, > > + .done = netlink_dump

Re: [PATCH 0/3] Optimize CRC32C calculation using PCLMULQDQ in crc32c-intel module

2012-09-26 Thread David Miller
From: Tim Chen Date: Tue, 25 Sep 2012 14:50:08 -0700 > This patch series optimized CRC32C calculations with PCLMULQDQ > instruction for crc32c-intel module. It speeds up the original > implementation by 1.6x for 1K buffer and by 3x for buffer 4k or > more. The tcrypt module was enhanced for doi

Re: [PATCH 02/11] inet_diag: pass inet_diag module to netlink_dump_start

2012-09-26 Thread Stephen Hemminger
On Wed, 26 Sep 2012 12:52:11 +0800 Gao feng wrote: > struct netlink_dump_control c = { > .dump = inet_diag_dump_compat, > + .done = netlink_dump_done, > + .module = THIS_MODULE, >

Re: [patch v2 04/11] nf_conntrack_netlink: pass nf_conntrack_netlink module to netlink_dump_start

2012-09-26 Thread Pablo Neira Ayuso
On Wed, Sep 26, 2012 at 08:35:53PM +0800, Gao feng wrote: > 于 2012年09月26日 17:58, Pablo Neira Ayuso 写道: > > On Wed, Sep 26, 2012 at 05:42:31PM +0800, Gao feng wrote: > >> Hi Pablo: > >> > >> 于 2012年09月26日 17:26, Pablo Neira Ayuso 写道: > >>> On Wed, Sep 26, 2012 at 04:41:21PM +0800, Gao feng wrote: >

Re: [patch v2 04/11] nf_conntrack_netlink: pass nf_conntrack_netlink module to netlink_dump_start

2012-09-26 Thread Gao feng
于 2012年09月26日 17:58, Pablo Neira Ayuso 写道: > On Wed, Sep 26, 2012 at 05:42:31PM +0800, Gao feng wrote: >> Hi Pablo: >> >> 于 2012年09月26日 17:26, Pablo Neira Ayuso 写道: >>> On Wed, Sep 26, 2012 at 04:41:21PM +0800, Gao feng wrote: use proper netlink_dump_control.done and .module to avoid panic. >>

Re: [patch v2 04/11] nf_conntrack_netlink: pass nf_conntrack_netlink module to netlink_dump_start

2012-09-26 Thread Pablo Neira Ayuso
On Wed, Sep 26, 2012 at 05:42:31PM +0800, Gao feng wrote: > Hi Pablo: > > 于 2012年09月26日 17:26, Pablo Neira Ayuso 写道: > > On Wed, Sep 26, 2012 at 04:41:21PM +0800, Gao feng wrote: > >> use proper netlink_dump_control.done and .module to avoid panic. > >> > >> Signed-off-by: Gao feng > >> --- > >>

Re: [patch v2 04/11] nf_conntrack_netlink: pass nf_conntrack_netlink module to netlink_dump_start

2012-09-26 Thread Gao feng
Hi Pablo: 于 2012年09月26日 17:26, Pablo Neira Ayuso 写道: > On Wed, Sep 26, 2012 at 04:41:21PM +0800, Gao feng wrote: >> use proper netlink_dump_control.done and .module to avoid panic. >> >> Signed-off-by: Gao feng >> --- >> net/netfilter/nf_conntrack_netlink.c |8 >> 1 files changed, 8

Re: [patch v2 04/11] nf_conntrack_netlink: pass nf_conntrack_netlink module to netlink_dump_start

2012-09-26 Thread Pablo Neira Ayuso
On Wed, Sep 26, 2012 at 04:41:21PM +0800, Gao feng wrote: > use proper netlink_dump_control.done and .module to avoid panic. > > Signed-off-by: Gao feng > --- > net/netfilter/nf_conntrack_netlink.c |8 > 1 files changed, 8 insertions(+), 0 deletions(-) > > diff --git a/net/netfilte

Re: [patch v2 04/11] nf_conntrack_netlink: pass nf_conntrack_netlink module to netlink_dump_start

2012-09-26 Thread Gao feng
于 2012年09月26日 16:41, Gao feng 写道: > use proper netlink_dump_control.done and .module to avoid panic. > > Signed-off-by: Gao feng > --- > net/netfilter/nf_conntrack_netlink.c |8 > 1 files changed, 8 insertions(+), 0 deletions(-) > > diff --git a/net/netfilter/nf_conntrack_netlink.c

Re: [GIT PULL] Asymmetric keys and module signing

2012-09-26 Thread David Howells
Rusty Russell wrote: > We do a very simple search for a particular string appended to the module > (which is cache-hot and about to be SHA'd anyway). There's both a config > option and a boot parameter which control whether we accept (and taint) or > fail with unsigned modules. I've adjusted yo

[patch v2 04/11] nf_conntrack_netlink: pass nf_conntrack_netlink module to netlink_dump_start

2012-09-26 Thread Gao feng
use proper netlink_dump_control.done and .module to avoid panic. Signed-off-by: Gao feng --- net/netfilter/nf_conntrack_netlink.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/net/netfilter/nf_conntrack_netlink.c b/net/netfilter/nf_conntrack_netlink.c index 980

[patch v2 06/11] nfnetlink_cthelper: pass nfnetlink_cthelper module to netlink_dump_start

2012-09-26 Thread Gao feng
use proper netlink_dump_control.done and .module to avoid panic. Signed-off-by: Gao feng --- net/netfilter/nfnetlink_cthelper.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/net/netfilter/nfnetlink_cthelper.c b/net/netfilter/nfnetlink_cthelper.c index d683619..117343

[patch v2 02/11] inet_diag: pass inet_diag module to netlink_dump_start

2012-09-26 Thread Gao feng
set netlink_dump_control.done and .module to avoid panic. Signed-off-by: Gao feng --- net/ipv4/inet_diag.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/net/ipv4/inet_diag.c b/net/ipv4/inet_diag.c index 570e61f..36d4be5 100644 --- a/net/ipv4/inet_diag.c +++ b/net/ip

[patch v2 09/11] xfrm: pass xfrm_user module to netlink_dump_start

2012-09-26 Thread Gao feng
use proper netlink_dump_control.done and .module to avoid panic. Signed-off-by: Gao feng --- net/xfrm/xfrm_user.c | 12 1 files changed, 8 insertions(+), 4 deletions(-) diff --git a/net/xfrm/xfrm_user.c b/net/xfrm/xfrm_user.c index 289f4bf..852339d 100644 --- a/net/xfrm/xfrm_user

[patch v2 01/11] netlink: add reference of module in netlink_dump_start

2012-09-26 Thread Gao feng
I get a panic when I use ss -a and rmmod inet_diag at the same time. it's because netlink_dump use inet_diag_dump witch function belongs to module inet_diag. I search the codes and find many modules have the same problem. We need add reference of the module witch the cb->dump belongs to. Thanks

[patch v2 10/11] ipset: pass ipset module to netlink_dump_start

2012-09-26 Thread Gao feng
use proper netlink_dump_control.done and .module to avoid panic. Signed-off-by: Gao feng Cc: Jozsef Kadlecsik --- net/netfilter/ipset/ip_set_core.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/net/netfilter/ipset/ip_set_core.c b/net/netfilter/ipset/ip_set_core.c i

[patch v2 11/11] infiniband: pass rdma_cm module to netlink_dump_start

2012-09-26 Thread Gao feng
use proper netlink_dump_control.done and .module to avoid panic. Signed-off-by: Gao feng Cc: Roland Dreier Cc: Sean Hefty --- drivers/infiniband/core/cma.c |3 ++- drivers/infiniband/core/netlink.c |2 ++ include/rdma/rdma_netlink.h |1 + 3 files changed, 5 insertions(+),

[patch v2 08/11] crypto: pass crypto_user module to netlink_dump_start

2012-09-26 Thread Gao feng
use proper netlink_dump_control.done and .module to avoid panic. Signed-off-by: Gao feng Cc: Herbert Xu --- crypto/crypto_user.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/crypto/crypto_user.c b/crypto/crypto_user.c index ba2c611..a9ca2b9 100644 --- a/crypto/

[patch v2 07/11] nfnetlink_cttimeout: pass nfnetlink_cttimeout module to netlink_dump_start

2012-09-26 Thread Gao feng
use proper netlink_dump_control.done and .module to avoid panic. Signed-off-by: Gao feng --- net/netfilter/nfnetlink_cttimeout.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/net/netfilter/nfnetlink_cttimeout.c b/net/netfilter/nfnetlink_cttimeout.c index cdecbc8..bc3

[patch v2 05/11] nfnetlink_acct: pass nfnetlink_acct module to netlink_dump_start

2012-09-26 Thread Gao feng
use proper netlink_dump_control.done and .module to avoid panic. Signed-off-by: Gao feng --- net/netfilter/nfnetlink_acct.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/net/netfilter/nfnetlink_acct.c b/net/netfilter/nfnetlink_acct.c index b2e7310..1e9cb0f 100644 ---

[patch v2 03/11] unix_diag: pass unix_diag module to netlink_dump_start

2012-09-26 Thread Gao feng
set netlink_dump_control.done and .module to avoid panic. Signed-off-by: Gao feng --- net/unix/diag.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/net/unix/diag.c b/net/unix/diag.c index 750b134..5e09553 100644 --- a/net/unix/diag.c +++ b/net/unix/diag.c @@ -299,6 +2

Re: [PATCH 01/11] netlink: add reference of module in netlink_dump_start

2012-09-26 Thread Gao feng
于 2012年09月26日 15:07, Eric Dumazet 写道: > On Wed, 2012-09-26 at 12:52 +0800, Gao feng wrote: > >> +int netlink_dump_done(struct netlink_callback *cb) >> +{ >> +if (cb->module) >> +module_put(cb->module); >> +return 0; >> +} >> +EXPORT_SYMBOL(netlink_dump_done); >> + > > No need

Re: [PATCH 08/11] crypto: pass crypto_user module to netlink_dump_start

2012-09-26 Thread Gao feng
于 2012年09月26日 13:49, Steffen Klassert 写道: > On Wed, Sep 26, 2012 at 12:52:17PM +0800, Gao feng wrote: >> use proper netlink_dump_control.done and .module to avoid panic. >> >> Signed-off-by: Gao feng >> Cc: Herbert Xu >> --- >> crypto/crypto_user.c |6 +- >> 1 files changed, 5 insertions

Re: [PATCH 01/11] netlink: add reference of module in netlink_dump_start

2012-09-26 Thread Eric Dumazet
On Wed, 2012-09-26 at 12:52 +0800, Gao feng wrote: > +int netlink_dump_done(struct netlink_callback *cb) > +{ > + if (cb->module) > + module_put(cb->module); > + return 0; > +} > +EXPORT_SYMBOL(netlink_dump_done); > + No need to test cb->module being not NULL int netlink_dum