RE: [PATCH v5 5/6] fsl-dma: use spin_lock_bh to instead of spin_lock_irqsave

> -Original Message- > From: Ira W. Snyder [mailto:i...@ovro.caltech.edu] > Sent: Thursday, August 02, 2012 1:31 AM > To: Liu Qiang-B32616 > Cc: linux-crypto@vger.kernel.org; linuxppc-...@lists.ozlabs.org; linux- > ker...@vger.kernel.org; dan.j.willi...@gmail.com; Vinod Koul; Tabi Timur- >

RE: [PATCH v5 4/6] fsl-dma: move the function ahead of its invoke function

> -Original Message- > From: Ira W. Snyder [mailto:i...@ovro.caltech.edu] > Sent: Thursday, August 02, 2012 12:31 AM > To: Liu Qiang-B32616 > Cc: linux-crypto@vger.kernel.org; linuxppc-...@lists.ozlabs.org; linux- > ker...@vger.kernel.org; dan.j.willi...@gmail.com; Vinod Koul; > herb...@gon

RE: [PATCH v5 2/6] fsl-dma: remove attribute DMA_INTERRUPT of dmaengine

> -Original Message- > From: Ira W. Snyder [mailto:i...@ovro.caltech.edu] > Sent: Thursday, August 02, 2012 12:36 AM > To: Liu Qiang-B32616 > Cc: linux-crypto@vger.kernel.org; linuxppc-...@lists.ozlabs.org; linux- > ker...@vger.kernel.org; dan.j.willi...@gmail.com; Vinod Koul; > herb...@gon

Re: [PATCH v5 5/6] fsl-dma: use spin_lock_bh to instead of spin_lock_irqsave

On Wed, Aug 01, 2012 at 04:50:09PM +0800, qiang@freescale.com wrote: > From: Qiang Liu > > - use spin_lock_bh() is the right way to use async_tx api, > dma_run_dependencies() should not be protected by spin_lock_irqsave(); > - use spin_lock_bh to instead of spin_lock_irqsave for improving per

Re: [PATCH v5 6/6] fsl-dma: fix a warning of unitialized cookie

On Wed, Aug 01, 2012 at 04:50:27PM +0800, qiang@freescale.com wrote: > From: Qiang Liu > > Fix a warning of unitialized value when compile with -Wuninitialized. > Looks good to me. Acked-by: Ira W. Snyder > Cc: Dan Williams > Cc: Vinod Koul > Cc: Li Yang > Signed-off-by: Qiang Liu >

Re: [PATCH v5 3/6] fsl-dma: change release process of dma descriptor for supporting async_tx

On Wed, Aug 01, 2012 at 04:49:17PM +0800, qiang@freescale.com wrote: > From: Qiang Liu > > Fix the potential risk when enable config NET_DMA and ASYNC_TX. > Async_tx is lack of support in current release process of dma descriptor, > all descriptors will be released whatever is acked or no-ack

Re: [PATCH v5 2/6] fsl-dma: remove attribute DMA_INTERRUPT of dmaengine

On Wed, Aug 01, 2012 at 04:49:08PM +0800, qiang@freescale.com wrote: > From: Qiang Liu > > Delete attribute DMA_INTERRUPT because fsl-dma doesn't support this function, > exception will be thrown if talitos is used to offload xor at the same time. > I have no problem with this patch. Howev

Re: [PATCH v5 4/6] fsl-dma: move the function ahead of its invoke function

On Wed, Aug 01, 2012 at 04:49:43PM +0800, qiang@freescale.com wrote: > From: Qiang Liu > > Move the function fsldma_cleanup_descriptor() and fsl_chan_xfer_ld_queue() > ahead of its invoke function for avoiding redundant definition. > > Cc: Dan Williams > Cc: Vinod Koul > Cc: Li Yang > Sig

RE: [PATCH v5 3/6] fsl-dma: change release process of dma descriptor for supporting async_tx

Hi Ira, I hope we can discuss fsl-dma in this thread. In this patch I give a simple case to illustrate why I must correct the release process of finished descriptors. There is potential risk in current fsl-dma, the finished cookie value and finished async_tx descriptor should be judged by hardw

[PATCH v5 6/6] fsl-dma: fix a warning of unitialized cookie

From: Qiang Liu Fix a warning of unitialized value when compile with -Wuninitialized. Cc: Dan Williams Cc: Vinod Koul Cc: Li Yang Signed-off-by: Qiang Liu Reported-by: Kim Phillips --- drivers/dma/fsldma.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/dm

[PATCH v5 5/6] fsl-dma: use spin_lock_bh to instead of spin_lock_irqsave

From: Qiang Liu - use spin_lock_bh() is the right way to use async_tx api, dma_run_dependencies() should not be protected by spin_lock_irqsave(); - use spin_lock_bh to instead of spin_lock_irqsave for improving performance, There is not any place to access descriptor queues in fsl-dma ISR except

[PATCH v5 4/6] fsl-dma: move the function ahead of its invoke function

From: Qiang Liu Move the function fsldma_cleanup_descriptor() and fsl_chan_xfer_ld_queue() ahead of its invoke function for avoiding redundant definition. Cc: Dan Williams Cc: Vinod Koul Cc: Li Yang Signed-off-by: Qiang Liu --- drivers/dma/fsldma.c | 252 +--

[PATCH v5 3/6] fsl-dma: change release process of dma descriptor for supporting async_tx

From: Qiang Liu Fix the potential risk when enable config NET_DMA and ASYNC_TX. Async_tx is lack of support in current release process of dma descriptor, all descriptors will be released whatever is acked or no-acked by async_tx, so there is a potential race condition when dma engine is uesd by o

[PATCH v5 2/6] fsl-dma: remove attribute DMA_INTERRUPT of dmaengine

From: Qiang Liu Delete attribute DMA_INTERRUPT because fsl-dma doesn't support this function, exception will be thrown if talitos is used to offload xor at the same time. Cc: Dan Williams Cc: Vinod Koul Cc: Li Yang Signed-off-by: Qiang Liu Acked-by: Ira W. Snyder --- drivers/dma/fsldma.c |

[PATCH v5 1/6] Talitos: Support for async_tx XOR offload

From: Qiang Liu Expose Talitos's XOR functionality to be used for RAID parity calculation via the Async_tx layer. Cc: Herbert Xu Cc: David S. Miller Signed-off-by: Dipen Dudhat Signed-off-by: Maneesh Gupta Signed-off-by: Kim Phillips Signed-off-by: Vishnu Suresh Signed-off-by: Qiang Liu -

[PATCH v5 0/6] Raid: enable talitos xor offload for improving performance

Hi, The following 6 patches enabling fsl-dma and talitos offload raid operations for improving raid performance and balancing CPU load. Write performance will be improved by 25-30% tested by iozone. Write performance is improved about 2% after using spin_lock_bh replace spin_lock_irqsave. CPU loa