RE: [PATCH 5/7] fsl-dma: fix support for async_tx API

2012-07-31 Thread Liu Qiang-B32616
> -Original Message- > From: Ira W. Snyder [mailto:i...@ovro.caltech.edu] > Sent: Wednesday, August 01, 2012 7:46 AM > To: linux-crypto@vger.kernel.org > Cc: linuxppc-...@lists.ozlabs.org; Liu Qiang-B32616; Ira W. Snyder; Dan > Williams; Vinod Koul; Li Yang-R58472; Liu Qiang-B32616 > Subjec

RE: [PATCH 7/7] carma: remove unnecessary DMA_INTERRUPT capability

2012-07-31 Thread Liu Qiang-B32616
> -Original Message- > From: Ira W. Snyder [mailto:i...@ovro.caltech.edu] > Sent: Wednesday, August 01, 2012 7:46 AM > To: linux-crypto@vger.kernel.org > Cc: linuxppc-...@lists.ozlabs.org; Liu Qiang-B32616; Ira W. Snyder > Subject: [PATCH 7/7] carma: remove unnecessary DMA_INTERRUPT capabil

RE: [PATCH 0/7] fsl-dma: fixes for Freescale DMA driver

2012-07-31 Thread Liu Qiang-B32616
Hi Ira, My comments inline. > -Original Message- > From: Ira W. Snyder [mailto:i...@ovro.caltech.edu] > Sent: Wednesday, August 01, 2012 7:46 AM > To: linux-crypto@vger.kernel.org > Cc: linuxppc-...@lists.ozlabs.org; Liu Qiang-B32616; Ira W. Snyder > Subject: [PATCH 0/7] fsl-dma: fixes fo

RE: [PATCH v4 3/7] fsl-dma: change release process of dma descriptor for supporting async_tx

2012-07-31 Thread Liu Qiang-B32616
> -Original Message- > From: Ira W. Snyder [mailto:i...@ovro.caltech.edu] > Sent: Wednesday, August 01, 2012 6:14 AM > To: Liu Qiang-B32616 > Cc: linux-crypto@vger.kernel.org; linuxppc-...@lists.ozlabs.org; Phillips > Kim-R1AAHA; da...@davemloft.net; dan.j.willi...@gmail.com; Vinod Koul; Li

[PATCH 7/7] carma: remove unnecessary DMA_INTERRUPT capability

2012-07-31 Thread Ira W. Snyder
From: "Ira W. Snyder" These drivers set the DMA_INTERRUPT capability bit when requesting a DMA controller channel. This was historical, and is no longer needed. Recent changes to the drivers/dma/fsldma.c driver have removed support for this flag. This makes the carma drivers unable to find a DMA

[PATCH 6/7] fsl-dma: fix a warning of unitialized cookie

2012-07-31 Thread Ira W. Snyder
From: Qiang Liu Fix a warning of unitialized value when compile with -Wuninitialized. Cc: Dan Williams Cc: Vinod Koul Cc: Li Yang Signed-off-by: Qiang Liu Cc: Kim Phillips --- drivers/dma/fsldma.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/dma/fsldma.

[PATCH 5/7] fsl-dma: fix support for async_tx API

2012-07-31 Thread Ira W. Snyder
From: "Ira W. Snyder" The current fsldma driver does not support the async_tx API. This is due to a bug: all descriptors are released when the hardware is finished with them. The async_tx API requires that the ACK bit is set by software before descriptors are freed. This bug is easiest to reprod

[PATCH 4/7] fsl-dma: move functions to avoid forward declarations

2012-07-31 Thread Ira W. Snyder
From: "Ira W. Snyder" This function will be modified in the next patch in the series. By moving the function in a patch separate from the changes, it will make review easier. Signed-off-by: Ira W. Snyder --- drivers/dma/fsldma.c | 96 +- 1 file

[PATCH 3/7] fsl-dma: add fsl_dma_free_descriptor() to reduce code duplication

2012-07-31 Thread Ira W. Snyder
From: "Ira W. Snyder" There are several places where descriptors are freed using identical code. Put this code into a function to reduce code duplication. Signed-off-by: Ira W. Snyder --- drivers/dma/fsldma.c | 32 ++-- 1 files changed, 14 insertions(+), 18 deleti

[PATCH 2/7] fsl-dma: minimize locking overhead

2012-07-31 Thread Ira W. Snyder
From: "Ira W. Snyder" The use of spin_lock_irqsave() was a stronger locking mechanism than was actually needed in many cases. As the current code is written, spin_lock_bh() everywhere is sufficient. The next patch in this series will add some code to hardware interrupt context. This patch is in

[PATCH 1/7] fsl-dma: remove attribute DMA_INTERRUPT of dmaengine

2012-07-31 Thread Ira W. Snyder
From: Qiang Liu Delete attribute DMA_INTERRUPT because fsl-dma doesn't support this function, exception will be thrown if talitos is used to offload xor at the same time. Cc: Dan Williams Cc: Vinod Koul Cc: Li Yang Signed-off-by: Qiang Liu Acked-by: Ira W. Snyder --- drivers/dma/fsldma.c |

[PATCH 0/7] fsl-dma: fixes for Freescale DMA driver

2012-07-31 Thread Ira W. Snyder
From: "Ira W. Snyder" Hello everyone, This is my alternative (simpler) attempt at solving the problems reported by Qiang Liu with the async_tx API and MD RAID hardware offload support when using the Freescale DMA driver. The bug is caused by this driver freeing descriptors before they have been

Re: [PATCH v4 3/7] fsl-dma: change release process of dma descriptor for supporting async_tx

2012-07-31 Thread Ira W. Snyder
On Tue, Jul 31, 2012 at 04:09:28AM +, Liu Qiang-B32616 wrote: > > -Original Message- > > From: Ira W. Snyder [mailto:i...@ovro.caltech.edu] > > Sent: Tuesday, July 31, 2012 5:10 AM > > To: Liu Qiang-B32616 > > Cc: linux-crypto@vger.kernel.org; linuxppc-...@lists.ozlabs.org; Phillips > >

[PATCH] crypto: Add a MAINTAINERS entry for P7+ in-Nest crypto driver

2012-07-31 Thread Kent Yoder
Add a MAINTAINERS entry for the IBM Power in-Nest Crypto Acceleators driver. Signed-off-by: Kent Yoder --- MAINTAINERS |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index fb036a0..757fe60 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -341

Re: [PATCH 0/2] Fixes for MV_CESA with IDMA or TDMA

2012-07-31 Thread cloudy.linux
Hi Phil On 2012-7-9 20:54, Phil Sutter wrote: Hi, On Sun, Jul 08, 2012 at 01:38:47PM +0800, cloudy.linux wrote: Newest result. Still couldn't boot up. This time the source was cloned from your git repository. MV-DMA: window at bar0: target 0, attr 14, base 0, size 800 MV-DMA: window at ba