RE: [PATCH v3 3/4] fsl-dma: change release process of dma descriptor for supporting async_tx

2012-07-17 Thread Liu Qiang-B32616
Hi Ira, My comments inline. Hi Ira and Dan, Here is a introduction about my scenario of this case. My case is use async_tx API to offload raid5, Use fsl-talitos to compute parity calculation, fsl-dma to process memcpy. What bug occurred to me? Exception is thrown by BUG_ON(async_tx_ack_test(de

Re: [PATCH 13/14] crypto: drivers - remove cra_list initialization

2012-07-17 Thread Vladimir Zapolskiy
On 11.07.2012 14:20, Jussi Kivilinna wrote: Initialization of cra_list is currently mixed, most ciphers initialize this field and most shashes do not. Initialization however is not needed at all since cra_list is initialized/overwritten in __crypto_register_alg() with list_add(). Therefore perfor

Re: [PATCH v3 3/4] fsl-dma: change release process of dma descriptor for supporting async_tx

2012-07-17 Thread Ira W. Snyder
On Tue, Jul 17, 2012 at 07:06:33AM +, Liu Qiang-B32616 wrote: > > -Original Message- > > From: Ira W. Snyder [mailto:i...@ovro.caltech.edu] > > Sent: Tuesday, July 17, 2012 4:01 AM > > To: Liu Qiang-B32616 > > Cc: linux-crypto@vger.kernel.org; linuxppc-...@lists.ozlabs.org; Phillips > >

Re: [linuxppc-release] [PATCH v3 4/4] fsl-dma: use spin_lock_bh to instead of spin_lock_irqsave

2012-07-17 Thread Timur Tabi
Liu Qiang-B32616 wrote: > I attached the test result in v3 0/4, performance is improved by 2%. > For my understanding, there is not any place to access descriptor lists > in fsl-dma interrupt service handler except its tasklet, spin_lock_bh() > is born for this. Interrupts will be turned off and co

RE: [PATCH v3 3/4] fsl-dma: change release process of dma descriptor for supporting async_tx

2012-07-17 Thread Liu Qiang-B32616
> -Original Message- > From: Ira W. Snyder [mailto:i...@ovro.caltech.edu] > Sent: Tuesday, July 17, 2012 4:01 AM > To: Liu Qiang-B32616 > Cc: linux-crypto@vger.kernel.org; linuxppc-...@lists.ozlabs.org; Phillips > Kim-R1AAHA; herb...@gondor.hengli.com.au; da...@davemloft.net; Dan > Williams