RE: [PATCH v2 2/4] fsl-dma: remove attribute DMA_INTERRUPT of dmaengine

2012-07-11 Thread Liu Qiang-B32616
> -Original Message- > From: Ira W. Snyder [mailto:i...@ovro.caltech.edu] > Sent: Thursday, July 12, 2012 12:17 AM > To: Liu Qiang-B32616 > Cc: linux-crypto@vger.kernel.org; linuxppc-...@lists.ozlabs.org; Vinod > Koul; herb...@gondor.hengli.com.au; Dan Williams; da...@davemloft.net > Subjec

[PATCH 6/6] crypto: cast6 - add x86_64/avx assembler implementation

2012-07-11 Thread Johannes Goetzfried
This patch adds a x86_64/avx assembler implementation of the Cast6 block cipher. The implementation processes eight blocks in parallel (two 4 block chunk AVX operations). The table-lookups are done in general-purpose registers. For small blocksizes the functions from the generic module are called.

[PATCH 4/6] crypto: cast6 - prepare generic module for optimized implementations

2012-07-11 Thread Johannes Goetzfried
Rename cast6 module to cast6_generic to allow autoloading of optimized implementations. Generic functions and s-boxes are exported to be able to use them within optimized implementations. Signed-off-by: Johannes Goetzfried --- crypto/Makefile|2 +- crypto/cast6.c | 547

[PATCH 2/6] crypto: testmgr - add larger cast5 testvectors

2012-07-11 Thread Johannes Goetzfried
New ECB, CBC and CTR testvectors for cast5. We need larger testvectors to check parallel code paths in the optimized implementation. Tests have also been added to the tcrypt module. Signed-off-by: Johannes Goetzfried --- crypto/tcrypt.c | 32 +++ crypto/tcrypt.h |1 + crypto/testmgr.c |

[PATCH 3/6] crypto: cast5 - add x86_64/avx assembler implementation

2012-07-11 Thread Johannes Goetzfried
This patch adds a x86_64/avx assembler implementation of the Cast5 block cipher. The implementation processes sixteen blocks in parallel (four 4 block chunk AVX operations). The table-lookups are done in general-purpose registers. For small blocksizes the functions from the generic module are calle

[PATCH 0/6] crypto: add x86_64/avx assembler implementation of cast5 and cast6

2012-07-11 Thread Johannes Goetzfried
This patchset adds x86_64/avx assembler implementations of the Cast5 and the Cast6 cipher. Johannes Goetzfried (6): crypto: cast5 - prepare generic module for optimized implementations crypto: testmgr - add larger cast5 testvectors crypto: cast5 - add x86_64/avx assembler implementation cr

Re: [PATCH v2 3/4] fsl-dma: change the release process of dma descriptor

2012-07-11 Thread Ira W. Snyder
On Wed, Jul 11, 2012 at 05:01:25PM +0800, Qiang Liu wrote: > Modify the release process of dma descriptor for avoiding exception when > enable config NET_DMA, release dma descriptor from 1st to last second, the > last descriptor which is reserved in current descriptor register may not be > complete

Re: [PATCH v2 2/4] fsl-dma: remove attribute DMA_INTERRUPT of dmaengine

2012-07-11 Thread Ira W. Snyder
On Wed, Jul 11, 2012 at 05:00:53PM +0800, Qiang Liu wrote: > Delete attribute DMA_INTERRUPT because fsl-dma doesn't support this function, > exception will be thrown if talitos is used to offload xor at the same time. > Both drivers/misc/carma/carma-fpga.c and drivers/misc/carma/carma-fpga-progra

Re: [linuxppc-release] [PATCH v2 4/4] fsl-dma: use spin_lock_bh to instead of spin_lock_irqsave

2012-07-11 Thread Timur Tabi
Qiang Liu wrote: > Use spin_lock_bh to instead of spin_lock_irqsave for improving performance. Please provide some evidence that performance has improved, as well as an explanation why it's okay to use spin_lock_bh, and why it's faster. -- Timur Tabi Linux kernel developer at Freescale -- To un

[PATCH 14/14] crypto: arch/s390 - cleanup - remove unneeded cra_list initialization

2012-07-11 Thread Jussi Kivilinna
Initialization of cra_list is currently mixed, most ciphers initialize this field and most shashes do not. Initialization however is not needed at all since cra_list is initialized/overwritten in __crypto_register_alg() with list_add(). Therefore perform cleanup to remove all unneeded initializatio

[PATCH 13/14] crypto: drivers - remove cra_list initialization

2012-07-11 Thread Jussi Kivilinna
Initialization of cra_list is currently mixed, most ciphers initialize this field and most shashes do not. Initialization however is not needed at all since cra_list is initialized/overwritten in __crypto_register_alg() with list_add(). Therefore perform cleanup to remove all unneeded initializatio

[PATCH 12/14] crypto: arch/x86 - cleanup - remove unneeded crypto_alg.cra_list initializations

2012-07-11 Thread Jussi Kivilinna
Initialization of cra_list is currently mixed, most ciphers initialize this field and most shashes do not. Initialization however is not needed at all since cra_list is initialized/overwritten in __crypto_register_alg() with list_add(). Therefore perform cleanup to remove all unneeded initializatio

[PATCH 11/14] crypto: cleanup - remove unneeded crypto_alg.cra_list initializations

2012-07-11 Thread Jussi Kivilinna
Initialization of cra_list is currently mixed, most ciphers initialize this field and most shashes do not. Initialization however is not needed at all since cra_list is initialized/overwritten in __crypto_register_alg() with list_add(). Therefore perform cleanup to remove all unneeded initializatio

[PATCH 10/14] crypto: whirlpool - use crypto_[un]register_shashes

2012-07-11 Thread Jussi Kivilinna
Combine all shash algs to be registered and use new crypto_[un]register_shashes functions. This simplifies init/exit code. Signed-off-by: Jussi Kivilinna --- crypto/wp512.c | 39 ++- 1 file changed, 6 insertions(+), 33 deletions(-) diff --git a/crypto/wp512

[PATCH 09/14] crypto: sha512 - use crypto_[un]register_shashes

2012-07-11 Thread Jussi Kivilinna
Combine all shash algs to be registered and use new crypto_[un]register_shashes functions. This simplifies init/exit code. Signed-off-by: Jussi Kivilinna --- crypto/sha512_generic.c | 20 +--- 1 file changed, 5 insertions(+), 15 deletions(-) diff --git a/crypto/sha512_generic.

[PATCH 08/14] crypto: sha256 - use crypto_[un]register_shashes

2012-07-11 Thread Jussi Kivilinna
Combine all shash algs to be registered and use new crypto_[un]register_shashes functions. This simplifies init/exit code. Signed-off-by: Jussi Kivilinna --- crypto/sha256_generic.c | 25 + 1 file changed, 5 insertions(+), 20 deletions(-) diff --git a/crypto/sha256_gen

[PATCH 07/14] crypto: tiger - use crypto_[un]register_shashes

2012-07-11 Thread Jussi Kivilinna
Combine all shash algs to be registered and use new crypto_[un]register_shashes functions. This simplifies init/exit code. Signed-off-by: Jussi Kivilinna --- crypto/tgr192.c | 38 ++ 1 file changed, 6 insertions(+), 32 deletions(-) diff --git a/crypto/tgr19

[PATCH 06/14] crypto: add crypto_[un]register_shashes for [un]registering multiple shash entries at once

2012-07-11 Thread Jussi Kivilinna
Add crypto_[un]register_shashes() to allow simplifying init/exit code of shash crypto modules that register multiple algorithms. Signed-off-by: Jussi Kivilinna --- crypto/shash.c | 36 include/crypto/internal/hash.h |2 ++ 2 files change

[PATCH 05/14] crypto: ansi_cprng - use crypto_[un]register_algs

2012-07-11 Thread Jussi Kivilinna
Combine all crypto_alg to be registered and use new crypto_[un]register_algs functions. This simplifies init/exit code. Cc: Neil Horman Signed-off-by: Jussi Kivilinna --- crypto/ansi_cprng.c | 63 +++ 1 file changed, 23 insertions(+), 40 deletio

[PATCH 04/14] crypto: serpent - use crypto_[un]register_algs

2012-07-11 Thread Jussi Kivilinna
Combine all crypto_alg to be registered and use new crypto_[un]register_algs functions. This simplifies init/exit code. Signed-off-by: Jussi Kivilinna --- crypto/serpent_generic.c | 53 -- 1 file changed, 19 insertions(+), 34 deletions(-) diff --git

[PATCH 03/14] crypto: des - use crypto_[un]register_algs

2012-07-11 Thread Jussi Kivilinna
Combine all crypto_alg to be registered and use new crypto_[un]register_algs functions. This simplifies init/exit code. Signed-off-by: Jussi Kivilinna --- crypto/des_generic.c | 25 + 1 file changed, 5 insertions(+), 20 deletions(-) diff --git a/crypto/des_generic.c b/

[PATCH 02/14] crypto: crypto_null - use crypto_[un]register_algs

2012-07-11 Thread Jussi Kivilinna
Combine all crypto_alg to be registered and use new crypto_[un]register_algs functions. This simplifies init/exit code. Signed-off-by: Jussi Kivilinna --- crypto/crypto_null.c | 57 -- 1 file changed, 18 insertions(+), 39 deletions(-) diff --git

[PATCH 00/14] crypto: cleanup - alg and shash init/exit cleanups and remove unneeded cra_list initializations

2012-07-11 Thread Jussi Kivilinna
Patches 1-5 change various cipher modules to use new crypto_register_algs and crypto_unregister_algs. Patch 6 adds new crypto_register_shashes and crypto_unregister_shashes functions for registering multiple shash algorithms at same time. Patches 7-10 change various shash modules to use new crypt

[PATCH 01/14] crypto: tea - use crypto_[un]register_algs

2012-07-11 Thread Jussi Kivilinna
Combine all crypto_alg to be registered and use new crypto_[un]register_algs functions. This simplifies init/exit code. Signed-off-by: Jussi Kivilinna --- crypto/tea.c | 41 ++--- 1 file changed, 6 insertions(+), 35 deletions(-) diff --git a/crypto/tea.c b/

[PATCH v2 4/4] fsl-dma: use spin_lock_bh to instead of spin_lock_irqsave

2012-07-11 Thread Qiang Liu
Use spin_lock_bh to instead of spin_lock_irqsave for improving performance. Cc: Dan Williams Cc: Vinod Koul Cc: Li Yang Signed-off-by: Qiang Liu --- drivers/dma/fsldma.c | 30 -- 1 files changed, 12 insertions(+), 18 deletions(-) diff --git a/drivers/dma/fsldma.

[PATCH v2 3/4] fsl-dma: change the release process of dma descriptor

2012-07-11 Thread Qiang Liu
Modify the release process of dma descriptor for avoiding exception when enable config NET_DMA, release dma descriptor from 1st to last second, the last descriptor which is reserved in current descriptor register may not be completed, race condition will be raised if free current descriptor. A rac

[PATCH v2 2/4] fsl-dma: remove attribute DMA_INTERRUPT of dmaengine

2012-07-11 Thread Qiang Liu
Delete attribute DMA_INTERRUPT because fsl-dma doesn't support this function, exception will be thrown if talitos is used to offload xor at the same time. Cc: Dan Williams Cc: Vinod Koul Cc: Li Yang Signed-off-by: Qiang Liu --- drivers/dma/fsldma.c | 31 --- 1 fi

[PATCH v2 1/4] Talitos: Support for async_tx XOR offload

2012-07-11 Thread Qiang Liu
Expose Talitos's XOR functionality to be used for RAID parity calculation via the Async_tx layer. Cc: Herbert Xu Cc: David S. Miller Signed-off-by: Dipen Dudhat Signed-off-by: Maneesh Gupta Signed-off-by: Kim Phillips Signed-off-by: Vishnu Suresh Signed-off-by: Qiang Liu --- drivers/crypto

[PATCH v2 0/4] Raid: enable talitos xor offload for improving performance

2012-07-11 Thread Qiang Liu
The following 4 patches enabling fsl-dma and talitos offload raid operations for improving raid performance and balancing CPU load. Write performance will be improved by 40% tested by iozone. CPU load will be reduced by 8%. Changes in v2: - rebase onto cryptodev tree - split the p

RE: [PATCH 4/4] Talitos: fix the issue of dma memory leak

2012-07-11 Thread Liu Qiang-B32616
> -Original Message- > From: Geanta Neag Horia Ioan-B05471 > Sent: Wednesday, July 11, 2012 3:09 PM > To: Liu Qiang-B32616 > Cc: linux-crypto@vger.kernel.org; linuxppc-...@lists.ozlabs.org; Li Yang- > R58472; Phillips Kim-R1AAHA; Herbert Xu; David S. Miller > Subject: RE: [PATCH 4/4] Talito

RE: [PATCH 4/4] Talitos: fix the issue of dma memory leak

2012-07-11 Thread Geanta Neag Horia Ioan-B05471
On Tue, 10 Jul 2012 09:00:14 +0300, Qiang Liu wrote: > An error will be happened when test with mass data: > "DMA-API: device driver tries to sync DMA memory it has not allocated"; > "DMA-API: debugging out of memory - disabling" > dma mapping memory of request->desc is not released by right devic