Re: [PATCH] crypto: twofish-avx - remove useless instruction

2012-07-10 Thread Herbert Xu
On Thu, Jul 05, 2012 at 08:43:58PM +0200, Johannes Goetzfried wrote: > The register %rdx is written, but never read till the end of the encryption > routine. Therefore let's delete the useless instruction. > > Signed-off-by: Johannes Goetzfried > Patch applied. Thanks! -- Email: Herbert Xu H

Re: [PATCH 1/4] crypto: talitos - move talitos structures to header file

2012-07-10 Thread Herbert Xu
On Tue, Jul 03, 2012 at 07:16:51PM +0300, Horia Geanta wrote: > This patch moves the talitos structure definitions from c file to its > header file so that the same can be shared on need basis. > > Signed-off-by: Sandeep Malik > Signed-off-by: Kim Phillips > Signed-off-by: Horia Geanta All app

Re: [PATCH 0/5] AT91SAM9G46/M11: add crypto drivers

2012-07-10 Thread Herbert Xu
On Sun, Jul 01, 2012 at 07:19:42PM +0200, Eric Bénard wrote: > This patch serie adds the support for the crypto engine available in > the Atmel SAM9G46 http://www.atmel.com/devices/SAM9G46.aspx and SAM9M11 > http://www.atmel.com/devices/SAM9M11.aspx > > For each driver the choice between PDC/DMA o

Re: [PATCH] crypto: allow aesni-intel and ghash_clmulni-intel in fips mode

2012-07-10 Thread Herbert Xu
On Fri, Jun 29, 2012 at 10:08:09PM +0200, Milan Broz wrote: > Patch 863b557a88f8c033f7419fabafef4712a5055f85 added NULL entries > for intel accelerated drivers but did not marked these fips allowed. > This cause panic if running tests with fips=1. > > For ghash, fips_allowed flag was added in patc

Re: [PATCH] crypto: aesni-intel - fix wrong kfree pointer

2012-07-10 Thread Herbert Xu
On Thu, Jun 28, 2012 at 05:26:02PM +0200, Milan Broz wrote: > kfree(new_key_mem) in rfc4106_set_key() should be called on malloced pointer, > not on aligned one, otherwise it can cause invalid pointer on free. > > (Seen at least once when running tcrypt tests with debug kernel.) > > Signed-off-by

Re: [PATCH v2] ERA retrieval and printing for SEC device

2012-07-10 Thread Herbert Xu
On Wed, Jun 27, 2012 at 07:56:04PM +, Kim Phillips wrote: > From: Alex Porosanu > > This patch adds support for retrieving and printing of > SEC ERA information. It is useful for knowing beforehand > what features exist from the SEC point of view on a > certain SoC. Only era-s 1 to 4 are curr

Re: [PATCH] Using alloc_coherent for caam job rings

2012-07-10 Thread Herbert Xu
On Wed, Jun 27, 2012 at 07:34:11PM +, Kim Phillips wrote: > On Wed, 27 Jun 2012 10:58:32 +0530 > Bharat Bhushan wrote: > > > This resolves the Linux boot crash issue when "swiotlb=force" is set > > in bootargs on systems which have memory more than 4G. > > Acked-by: Kim Phillips Patch appl

RE: [PATCH 1/4] Talitos: move the data structure into header file

2012-07-10 Thread Liu Qiang-B32616
> -Original Message- > From: Phillips Kim-R1AAHA > Sent: Wednesday, July 11, 2012 8:11 AM > To: Liu Qiang-B32616 > Cc: linux-crypto@vger.kernel.org; linuxppc-...@lists.ozlabs.org; Li Yang- > R58472; Herbert Xu; David S. Miller; Geanta Neag Horia Ioan-B05471 > Subject: Re: [PATCH 1/4] Talito

RE: [linuxppc-release] [PATCH 4/4] Talitos: fix the issue of dma memory leak

2012-07-10 Thread Liu Qiang-B32616
> -Original Message- > From: Tabi Timur-B04825 > Sent: Wednesday, July 11, 2012 5:26 AM > To: Liu Qiang-B32616 > Cc: linux-crypto@vger.kernel.org; linuxppc-...@lists.ozlabs.org; Herbert > Xu; Li Yang-R58472; David S. Miller > Subject: Re: [linuxppc-release] [PATCH 4/4] Talitos: fix the issu

RE: [PATCH 3/4] fsl-dma: support attribute of DMA_MEMORY when async_tx enabled

2012-07-10 Thread Liu Qiang-B32616
> -Original Message- > From: Dan Williams [mailto:dan.j.willi...@intel.com] > Sent: Wednesday, July 11, 2012 3:39 AM > To: Liu Qiang-B32616 > Cc: linux-crypto@vger.kernel.org; linuxppc-...@lists.ozlabs.org; Li Yang- > R58472; Phillips Kim-R1AAHA; Vinod Koul > Subject: Re: [PATCH 3/4] fsl-dm

Re: [PATCH 1/4] Talitos: move the data structure into header file

2012-07-10 Thread Kim Phillips
On Tue, 10 Jul 2012 13:56:46 +0800 Qiang Liu wrote: > Move the declaration of talitos data structure into talitos.h. > > Cc: Herbert Xu > Cc: David S. Miller > Signed-off-by: Qiang Liu > --- this patch has already been submitted [1]. Subsequent patches in this series also don't apply cleanl

Re: [PATCH 3/6] workqueue: use @pool instead of @gcwq or @cpu where applicable

2012-07-10 Thread Tony Luck
p; > -atomic_read(get_gcwq_nr_running(gcwq->cpu))); > +atomic_read(get_pool_nr_running(pool))); > } Just had this WARN_ON_ONCE trigger on ia64 booting next-20120710. I haven't bisected ... just noticed that two patches in this series

Re: [linuxppc-release] [PATCH 4/4] Talitos: fix the issue of dma memory leak

2012-07-10 Thread Timur Tabi
Qiang Liu wrote: > An error will be happened when test with mass data: Please don't use the phrase "fix the issue" in patch summaries. It's redundant. This patch should be titled, "drivers/crypto: fix memory leak in Talitos driver" > diff --git a/drivers/crypto/talitos.c b/drivers/crypto/talit

Re: [PATCH 3/4] fsl-dma: support attribute of DMA_MEMORY when async_tx enabled

2012-07-10 Thread Dan Williams
On Mon, Jul 9, 2012 at 10:59 PM, Qiang Liu wrote: > - delete attribute of DMA_INTERRUPT because fsl-dma doesn't support > this function, exception will be thrown if talitos is used to compute xor > at the same time; > - change the release process of dma descriptor for avoiding exception when > ena