Re: [PATCH] crypto: twofish-avx - remove useless instruction

2012-07-05 Thread Johannes Goetzfried
On Thu, Jul 05, 2012 at 08:46:12PM -0300, Henrique de Moraes Holschuh wrote: > Is it useless, or is it there to harden against some side-channel > attack? When writing this implementation, I first had a different approach with more data getting read in and I just forgot to delete this instruction

Re: [PATCH] crypto: twofish-avx - remove useless instruction

2012-07-05 Thread Henrique de Moraes Holschuh
On Thu, 05 Jul 2012, Johannes Goetzfried wrote: > The register %rdx is written, but never read till the end of the encryption > routine. Therefore let's delete the useless instruction. Is it useless, or is it there to harden against some side-channel attack? -- "One disk to rule them all, One

[PATCH] crypto: twofish-avx - remove useless instruction

2012-07-05 Thread Johannes Goetzfried
The register %rdx is written, but never read till the end of the encryption routine. Therefore let's delete the useless instruction. Signed-off-by: Johannes Goetzfried --- arch/x86/crypto/twofish-avx-x86_64-asm_64.S |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/arch/x