Re: [PATCH 1/2] mach-ux500: Crypto: core support for CRYP/HASH module.

2012-05-09 Thread Andreas WESTIN
On 2012-05-09 15:47, Arnd Bergmann wrote: Yes, exactly. Ok so I assumed wrong, I will look into it. Cheers Andreas -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH 1/2] mach-ux500: Crypto: core support for CRYP/HASH module.

2012-05-09 Thread Arnd Bergmann
On Wednesday 09 May 2012, Linus Walleij wrote: > On Wed, May 9, 2012 at 2:17 PM, Arnd Bergmann wrote: > > How about using distinct identification strings for each version of the > > crypto hardware? The driver should really only care about what kind > > of device it is talking to, not which SoC it

Re: [PATCH 1/2] mach-ux500: Crypto: core support for CRYP/HASH module.

2012-05-09 Thread Andreas WESTIN
On 2012-05-09 15:09, Linus Walleij wrote: How about using distinct identification strings for each version of the crypto hardware? The driver should really only care about what kind of device it is talking to, not which SoC it is built into. Do you mean like this (from a recent pinctrl drive

Re: [PATCH 1/2] mach-ux500: Crypto: core support for CRYP/HASH module.

2012-05-09 Thread Linus Walleij
On Wed, May 9, 2012 at 2:17 PM, Arnd Bergmann wrote: > On Wednesday 09 May 2012, Andreas WESTIN wrote: >> On 2012-05-09 10:36, Linus Walleij wrote: >> >> This needs an explanation! Why do you export an internal data structure >> >> to non-GPL modules? >> > >> > This does not look like it's needed

Re: [PATCH 1/2] mach-ux500: Crypto: core support for CRYP/HASH module.

2012-05-09 Thread Arnd Bergmann
On Wednesday 09 May 2012, Andreas WESTIN wrote: > On 2012-05-09 10:36, Linus Walleij wrote: > >> This needs an explanation! Why do you export an internal data structure > >> to non-GPL modules? > > > > This does not look like it's needed at all, none of the other two patches > > use > > it. Andrea

Re: [PATCH 1/2] mach-ux500: Crypto: core support for CRYP/HASH module.

2012-05-09 Thread Andreas WESTIN
On 2012-05-09 10:36, Linus Walleij wrote: This needs an explanation! Why do you export an internal data structure to non-GPL modules? This does not look like it's needed at all, none of the other two patches use it. Andreas can you just drop this hunk of the patch? It is needed if you compi

Re: [PATCH 1/2] mach-ux500: Crypto: core support for CRYP/HASH module.

2012-05-09 Thread Linus Walleij
On Tue, May 8, 2012 at 9:37 PM, Arnd Bergmann wrote: > On Tuesday 08 May 2012, Andreas Westin wrote: >> This adds the required platform data and calls to enable >> the CRYP/HASH driver. >> >> index 15a0f63..a69db46 100644 >> --- a/arch/arm/mach-ux500/id.c >> +++ b/arch/arm/mach-ux500/id.c >> @@ -