Re: [PATCH] In crypto_add_alg(), 'exact' wants to be initialized to 0

2012-02-01 Thread Steffen Klassert
On Wed, Feb 01, 2012 at 09:21:39PM +0100, Jesper Juhl wrote: > On Wed, 1 Feb 2012, devendra.aaru wrote: > > > On Sun, Jan 29, 2012 at 5:39 PM, Jesper Juhl wrote: > > > We declare 'exact' without initializing it and then do: > > > > > > [...] > > >        if (strlen(p->cru_driver_name)) > > >    

Re: Question on __crypto_alg_lookup

2012-02-01 Thread Mark Allyn
Thanks. Truly, Mark Allyn Portland, Oregon www.allyn.com 971-563-7588 On Thu, 2 Feb 2012, Herbert Xu wrote: Mark Allyn wrote: Is dm-crypt supposed to work with ahash? Since it uses the shash interface, no. Someone will need to convert it over to ahash first, like what we have done for

Re: Question on __crypto_alg_lookup

2012-02-01 Thread Herbert Xu
Mark Allyn wrote: > > Is dm-crypt supposed to work with ahash? Since it uses the shash interface, no. Someone will need to convert it over to ahash first, like what we have done for IPsec. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apan

Re: [PATCH] In crypto_add_alg(), 'exact' wants to be initialized to 0

2012-02-01 Thread Jesper Juhl
On Wed, 1 Feb 2012, Jesper Juhl wrote: > On Wed, 1 Feb 2012, devendra.aaru wrote: > > > On Sun, Jan 29, 2012 at 5:39 PM, Jesper Juhl wrote: > > > We declare 'exact' without initializing it and then do: > > > > > > [...] > > >        if (strlen(p->cru_driver_name)) > > >                exact = 1;

Re: [PATCH] In crypto_add_alg(), 'exact' wants to be initialized to 0

2012-02-01 Thread Jesper Juhl
On Wed, 1 Feb 2012, devendra.aaru wrote: > On Sun, Jan 29, 2012 at 5:39 PM, Jesper Juhl wrote: > > We declare 'exact' without initializing it and then do: > > > > [...] > >        if (strlen(p->cru_driver_name)) > >                exact = 1; > > > >        if (priority && !exact) > >            

Re: [PATCH] In crypto_add_alg(), 'exact' wants to be initialized to 0

2012-02-01 Thread devendra.aaru
On Sun, Jan 29, 2012 at 5:39 PM, Jesper Juhl wrote: > We declare 'exact' without initializing it and then do: > > [...] >        if (strlen(p->cru_driver_name)) >                exact = 1; > >        if (priority && !exact) >                return -EINVAL; > > [...] > > If the first 'if' is not tr