Re: Crypto Fixes for 3.3

2012-01-25 Thread Linus Torvalds
On Wed, Jan 25, 2012 at 8:07 PM, Herbert Xu wrote: > > Oops, I had incorrectly applied the first patch in the thread. > > I've fixed it in the tree now. Oh well, I already pulled your tree. I just wanted to voice a few comments on it. >> We also avoid the problem with absolutely horrible gcc reg

Re: Crypto Fixes for 3.3

2012-01-25 Thread Herbert Xu
On Wed, Jan 25, 2012 at 07:35:19PM -0800, Linus Torvalds wrote: > > Ugh. This once more has the crazy signed integer modulus operator, > which can be quite expensive depending on whether the compiler can > tell whether it is always positive or not. Oops, I had incorrectly applied the first patch i

Re: Crypto Fixes for 3.3

2012-01-25 Thread Linus Torvalds
On Wed, Jan 25, 2012 at 6:43 PM, Herbert Xu wrote: > > This push fixes a race condition in sha512 that affects users > who use it in process context and softirq context concurrently, > in particular, this affects IPsec.  The result of the race is > the production of incorrect hashes, which for IPs

Crypto Fixes for 3.3

2012-01-25 Thread Herbert Xu
Hi Linus: This push fixes a race condition in sha512 that affects users who use it in process context and softirq context concurrently, in particular, this affects IPsec. The result of the race is the production of incorrect hashes, which for IPsec leands to loss of connectivity. Please pull fro

Re: [PATCH] crypto: caam - fix gcc 4.6 warning

2012-01-25 Thread Herbert Xu
On Wed, Jan 18, 2012 at 06:34:34PM -0600, Kim Phillips wrote: > On Fri, 13 Jan 2012 16:39:18 +1100 > Herbert Xu wrote: > > > On Mon, Jan 09, 2012 at 10:27:40AM -0600, Kim Phillips wrote: > > > drivers/crypto/caam/ctrl.c: In function 'caam_probe': > > > drivers/crypto/caam/ctrl.c:49:6: warning: un

Re: [PATCH] crypto: Add bulk algorithm registration interface

2012-01-25 Thread Herbert Xu
On Tue, Jan 17, 2012 at 11:34:26PM +, Mark Brown wrote: > Hardware crypto engines frequently need to register a selection of > different algorithms with the core. Simplify their code slightly, > especially the error handling, by providing functions to register a > number of algorithms in a sing

Re: [PATCH 4/3] sha512: reduce stack usage even on i386

2012-01-25 Thread Herbert Xu
On Wed, Jan 18, 2012 at 09:02:10PM +0300, Alexey Dobriyan wrote: > Fix still excessive stack usage on i386. > > There is too much loop unrolling going on, despite W[16] being used, > gcc screws up this for some reason. So, don't be smart, use simple code > from SHA-512 definition, this keeps code