Re: sha512: make it work, undo percpu message schedule

2012-01-12 Thread Herbert Xu
On Fri, Jan 13, 2012 at 02:55:14AM +0300, Alexey Dobriyan wrote: > > Herbert, I couldn't come up with a single scenario. :-( > But the bug is easy to reproduce. OK, does this patch work for you? commit 31f4e55c09c1170f8b813c14b1299b70f50db414 Author: Herbert Xu Date: Fri Jan 13 18:06:50 2012 +

Re: sha512: make it work, undo percpu message schedule

2012-01-12 Thread Herbert Xu
On Fri, Jan 13, 2012 at 07:48:38AM +0100, Eric Dumazet wrote: > > Another solution is using two blocks, one used from interrupt context. > > static DEFINE_PER_CPU(u64[80], msg_schedule); > static DEFINE_PER_CPU(u64[80], msg_schedule_irq); > > (Like we do for SNMP mibs on !x86 arches) Yes that so

Re: sha512: make it work, undo percpu message schedule

2012-01-12 Thread Eric Dumazet
Le vendredi 13 janvier 2012 à 07:22 +0100, Steffen Klassert a écrit : > On Wed, Jan 11, 2012 at 11:36:11AM +1100, Herbert Xu wrote: > > On Wed, Jan 11, 2012 at 03:00:40AM +0300, Alexey Dobriyan wrote: > > > commit f9e2bca6c22d75a289a349f869701214d63b5060 > > > aka "crypto: sha512 - Move message sch

Re: sha512: make it work, undo percpu message schedule

2012-01-12 Thread Herbert Xu
On Fri, Jan 13, 2012 at 07:22:56AM +0100, Steffen Klassert wrote: > > I did not try to reproduce, but this looks like a race of the 'local out' > and the receive packet path. On 'lokal out' bottom halves are enabled, > so could be interrupted by the NET_RX_SOFTIRQ while doing a sha512_update. > The

Re: sha512: make it work, undo percpu message schedule

2012-01-12 Thread Steffen Klassert
On Wed, Jan 11, 2012 at 11:36:11AM +1100, Herbert Xu wrote: > On Wed, Jan 11, 2012 at 03:00:40AM +0300, Alexey Dobriyan wrote: > > commit f9e2bca6c22d75a289a349f869701214d63b5060 > > aka "crypto: sha512 - Move message schedule W[80] to static percpu area" > > created global message schedule area. >

Re: [PATCH] crypto: caam - fix gcc 4.6 warning

2012-01-12 Thread Herbert Xu
On Mon, Jan 09, 2012 at 10:27:40AM -0600, Kim Phillips wrote: > drivers/crypto/caam/ctrl.c: In function 'caam_probe': > drivers/crypto/caam/ctrl.c:49:6: warning: unused variable 'd' > [-Wunused-variable] > > Signed-off-by: Kim Phillips Both patches applied. Thanks! -- Email: Herbert Xu Home

Re: [PATCH 3/4] drivers/crypto/ixp4xx_crypto.c: convert GFP_KERNEL to GFP_ATOMIC

2012-01-12 Thread Herbert Xu
On Mon, Jan 09, 2012 at 10:40:49AM +0100, Julia Lawall wrote: > From: Julia Lawall > > The function is called with locks held and thus should not use GFP_KERNEL. > > The semantic patch that makes this report is available > in scripts/coccinelle/locks/call_kern.cocci. > > More information about

Re: [PATCH v8 0/2] crypto: driver for Tegra AES hardware

2012-01-12 Thread Varun Wadekar
On Friday 13 January 2012 11:05 AM, Herbert Xu wrote: On Fri, Dec 16, 2011 at 11:25:53AM +, Varun Wadekar wrote: The tegra crypto driver uses the tegra_chip_uid API for the RNG calculation. If one wants to build tegra-aes as a module, then tegra_chip_uid needs to be exported. Both patches a

Re: [PATCH 1/1] Added CRYPTO_ALG_KERN_DRIVER_ONLY flag (4rd attempt)

2012-01-12 Thread Herbert Xu
On Fri, Jan 06, 2012 at 10:24:50PM +0100, Nikos Mavrogiannopoulos wrote: > This patch is the same as the previous but without the inline function. Patch applied. Thanks! -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto - serpent-sse2: change transpose_4x4 to only use integer instructions

2012-01-12 Thread Herbert Xu
On Tue, Dec 20, 2011 at 12:58:06PM +0200, Jussi Kivilinna wrote: > Matrix transpose macro in serpent-sse2 uses mix of SSE2 integer and SSE > floating > point instructions, which might cause performance penality on some CPUs. > > This patch replaces transpose_4x4 macro with version that uses only

Re: [PATCH 1/2] crypto: twofish-x86_64-3way - blacklist pentium4 and atom

2012-01-12 Thread Herbert Xu
On Tue, Dec 20, 2011 at 12:20:16PM +0200, Jussi Kivilinna wrote: > Performance of twofish-x86_64-3way on Intel Pentium 4 and Atom is lower than > of twofish-x86_64 module. So blacklist these CPUs. > > Signed-off-by: Jussi Kivilinna Both patches applied. Thanks! -- Email: Herbert Xu Home Page:

Re: [PATCH v8 0/2] crypto: driver for Tegra AES hardware

2012-01-12 Thread Herbert Xu
On Fri, Dec 16, 2011 at 11:25:53AM +, Varun Wadekar wrote: > The tegra crypto driver uses the tegra_chip_uid API for the RNG > calculation. If one wants to build tegra-aes as a module, then > tegra_chip_uid needs to be exported. Both patches applied. Thanks! -- Email: Herbert Xu Home Page:

Re: sha512: make it work, undo percpu message schedule

2012-01-12 Thread Herbert Xu
On Fri, Jan 13, 2012 at 02:55:14AM +0300, Alexey Dobriyan wrote: > > Herbert, I couldn't come up with a single scenario. :-( > But the bug is easy to reproduce. OK, I'll try to reproduce it here. Thanks! -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor

Re: sha512: make it work, undo percpu message schedule

2012-01-12 Thread Alexey Dobriyan
On Wed, Jan 11, 2012 at 11:36:11AM +1100, Herbert Xu wrote: > On Wed, Jan 11, 2012 at 03:00:40AM +0300, Alexey Dobriyan wrote: > > commit f9e2bca6c22d75a289a349f869701214d63b5060 > > aka "crypto: sha512 - Move message schedule W[80] to static percpu area" > > created global message schedule area. >

Re: [PATCH v8 2/2] crypto: driver for Tegra AES hardware

2012-01-12 Thread Varun Wadekar
Add Herbert and David On Friday 16 December 2011 04:55 PM, Varun Wadekar wrote: driver supports ecb/cbc/ofb/ansi_x9.31rng modes, 128, 192 and 256-bit key sizes Signed-off-by: Varun Wadekar --- drivers/crypto/Kconfig | 11 + drivers/crypto/Makefile|1 + drivers/crypto/tegra-aes

Re: [PATCH v8 1/2] arm: tegra: export tegra_chip_uid

2012-01-12 Thread Varun Wadekar
Add Herbert and David On Friday 16 December 2011 04:55 PM, Varun Wadekar wrote: From: Henning Heinold The crypto driver will need this api to use it in the RNG calculations. In order to build the crypto driver as a module, tegra_chip_uid has to be exported. Acked-by: Olof Johansson Signed-off-