[PATCH 1/1] Added CRYPTO_ALG_KERN_DRIVER_ONLY flag (3rd attempt)

The added CRYPTO_ALG_KERN_DRIVER_ONLY indicates whether a cipher is only available via a kernel driver. If the cipher implementation might be available by using an instruction set or by porting the kernel code, then it must not be set. In addition it provides crypto_tfm_alg_flags() to obtain this

Re: [PATCH 14/14] crc32: Select an algorithm via kconfig

On Tue, Dec 13, 2011 at 09:27:10AM +0100, Joakim Tjernlund wrote: > "Darrick J. Wong" wrote on 2011/12/13 07:32:28: > > > > On Mon, Dec 12, 2011 at 05:10:45PM -0600, Bob Pearson wrote: > > > That choice was for Joakim who measured better performance on his 32 bit > > > PPC > > > platform with "by

Re: [PATCH 1/1] Added CRYPTO_ALG_KERN_DRIVER_ONLY flag (2nd attempt)

On Tue, 13 Dec 2011 09:53:52 +0100 Nikos Mavrogiannopoulos wrote: Niko, caam is ok. For talitos, either this way: > diff --git a/drivers/crypto/talitos.c b/drivers/crypto/talitos.c > index 230509e..5620788 100644 > --- a/drivers/crypto/talitos.c > +++ b/drivers/crypto/talitos.c > @@ -2007,7 +2

Re: drivers/media/video/s5p-fimc/fimc-capture.c: boolean and / or confusion

On 12/13/2011 12:55 AM, Joe Perches wrote: > On Tue, 2011-12-13 at 00:06 +0100, roel wrote: >> The test not [val1] or not [val2] always evaluates to true > > Hello > > Looking at drivers with: > > $ grep -rP --include=*.[ch] > "(\b[\w\[\]\>\._\-]+)\s*\!\=\s*[\w\[\]\>\._\-]+\s*\|\|\s*\1\s*\!\="

[PATCH 7/7] crypto - gf128mul: remove leftover "(EXPERIMENTAL)" in Kconfig

CRYPTO_GF128MUL does not select EXPERIMENTAL anymore so remove the "(EXPERIMENTAL)" from its name. Signed-off-by: Jussi Kivilinna --- crypto/Kconfig |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/crypto/Kconfig b/crypto/Kconfig index d7d4d4e..7ae0d0f 100644 --- a/crypt

[PATCH 6/7] crypto - serpent-sse2: remove unneeded LRW/XTS #ifdefs

Since LRW & XTS are selected by serpent-sse2, we don't need these #ifdefs anymore. Signed-off-by: Jussi Kivilinna --- arch/x86/crypto/serpent_sse2_glue.c | 40 --- 1 files changed, 0 insertions(+), 40 deletions(-) diff --git a/arch/x86/crypto/serpent_sse2_glue.

[PATCH 4/7] crypto - twofish-x86_64-3way: remove unneeded LRW/XTS #ifdefs

Since LRW & XTS are selected by twofish-x86_64-3way, we don't need these #ifdefs anymore. Signed-off-by: Jussi Kivilinna --- arch/x86/crypto/twofish_glue_3way.c | 32 1 files changed, 0 insertions(+), 32 deletions(-) diff --git a/arch/x86/crypto/twofish_glue_3

[PATCH 5/7] crypto - serpent-sse2: select LRW and XTS

serpent-sse2 uses functions from LRW and XTS modules, so selecting would appear to be better option than using #ifdefs in serpent_sse2_glue.c to enable/disable LRW and XTS features. This also fixes build problem when serpent-sse2 would be build into kernel but XTS/LRW are build as modules. Signed

[PATCH 3/7] crypto - twofish-x86_64-3way: select LRW and XTS

twofish-x86_64-3way uses functions from LRW and XTS modules, so selecting would appear to be better option than using #ifdefs in twofish_glue_3way.c to enable/disable LRW and XTS features. This also fixes build problem when twofish-x86_64-3way would be build into kernel but XTS/LRW are build as mo

[PATCH 2/7] crypto - xts: remove dependency on EXPERIMENTAL

XTS has been EXPERIMENTAL since it was introduced in 2007. I'd say by now it has seen enough testing to justify removal of EXPERIMENTAL tag. CC: Rik Snel Signed-off-by: Jussi Kivilinna --- crypto/Kconfig |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/crypto/Kconfig b

[PATCH 1/7] crypto - lrw: remove dependency on EXPERIMENTAL

LRW has been EXPERIMENTAL since it was introduced in 2006. I'd say by now it has seen enough testing to justify removal of EXPERIMENTAL tag. CC: Rik Snel Signed-off-by: Jussi Kivilinna --- crypto/Kconfig |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/crypto/Kconfig b

[PATCH] crypto: picoxcell: fix boolean and / or confusion

The AES engine only supports 128 and 256 bit keys so we should correctly test for that. Cc: Herbert Xu Reported-by: Joe Perches Signed-off-by: Jamie Iles --- drivers/crypto/picoxcell_crypto.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/picoxcell_c

Re: drivers/crypto/picoxcell_crypto.c: boolean and / or confusion

Hi Joe, On Mon, Dec 12, 2011 at 03:44:53PM -0800, Joe Perches wrote: > On Tue, 2011-12-13 at 00:06 +0100, roel wrote: > > The test not [val1] or not [val2] always evaluates to true > > Hey Jamie and Roel > > Looking at drivers with: > > $ grep -rP --include=*.[ch] > "(\b[\w\[\]\>\._\-]+)\s*\!\

Re: [PATCH 1/1] Added CRYPTO_ALG_KERN_DRIVER_ONLY flag.

On 12/12/2011 09:43 PM, Kim Phillips wrote: > This appears to be based on an older version of the current master > of Herbert's cryptodev tree on github [1] - it's missing the hmac > algorithms introduced in commit 79b3a41 "crypto: talitos - add hmac > algorithms", and a caam entry is missing (it

[PATCH 1/1] Added CRYPTO_ALG_KERN_DRIVER_ONLY flag (2nd attempt)

The added CRYPTO_ALG_KERN_DRIVER_ONLY indicates whether a cipher is only available via a kernel driver. If the cipher implementation might be available by using an instruction set or by porting the kernel code, then it must not be set. In addition it provides crypto_tfm_alg_flags() to obtain this

Re: [PATCH 14/14] crc32: Select an algorithm via kconfig

"Darrick J. Wong" wrote on 2011/12/13 07:32:28: > > On Mon, Dec 12, 2011 at 05:10:45PM -0600, Bob Pearson wrote: > > That choice was for Joakim who measured better performance on his 32 bit PPC > > platform with "by 4". > > Ok. On my 1.33GHz PowerBook I get ~255MB/s with slice by 4 and ~270MB/s w