Re: [PATCH 14/14] crc32: Select an algorithm via kconfig

2011-12-12 Thread Darrick J. Wong
On Mon, Dec 12, 2011 at 05:10:45PM -0600, Bob Pearson wrote: > That choice was for Joakim who measured better performance on his 32 bit PPC > platform with "by 4". Ok. On my 1.33GHz PowerBook I get ~255MB/s with slice by 4 and ~270MB/s with slice by 8. I think it's a PPC 7447, and definitely 32-

drivers/media/video/s5p-fimc/fimc-capture.c: boolean and / or confusion

2011-12-12 Thread Joe Perches
On Tue, 2011-12-13 at 00:06 +0100, roel wrote: > The test not [val1] or not [val2] always evaluates to true Hello Looking at drivers with: $ grep -rP --include=*.[ch] "(\b[\w\[\]\>\._\-]+)\s*\!\=\s*[\w\[\]\>\._\-]+\s*\|\|\s*\1\s*\!\=" drivers drivers/media/video/s5p-fimc/fimc-capture.c:

drivers/crypto/picoxcell_crypto.c: boolean and / or confusion

2011-12-12 Thread Joe Perches
On Tue, 2011-12-13 at 00:06 +0100, roel wrote: > The test not [val1] or not [val2] always evaluates to true Hey Jamie and Roel Looking at drivers with: $ grep -rP --include=*.[ch] "(\b[\w\[\]\>\._\-]+)\s*\!\=\s*[\w\[\]\>\._\-]+\s*\|\|\s*\1\s*\!\=" drivers drivers/crypto/picoxcell_crypto.c:

RE: [PATCH 14/14] crc32: Select an algorithm via kconfig

2011-12-12 Thread Bob Pearson
That choice was for Joakim who measured better performance on his 32 bit PPC platform with "by 4". > -Original Message- > From: Darrick J. Wong [mailto:djw...@us.ibm.com] > Sent: Monday, December 12, 2011 4:59 PM > To: Herbert Xu; Bob Pearson > Cc: Andrew Morton; Theodore Tso; Joakim Tjern

Re: [PATCH 14/14] crc32: Select an algorithm via kconfig

2011-12-12 Thread Darrick J. Wong
On Fri, Dec 02, 2011 at 06:36:46PM -0800, Darrick J. Wong wrote: > On Fri, Dec 02, 2011 at 08:25:05AM +0800, Herbert Xu wrote: > > On Thu, Dec 01, 2011 at 12:15:17PM -0800, Darrick J. Wong wrote: > > > Allow the kernel builder to choose a crc32* algorithm for the kernel. > > > > > > Signed-off-by:

[PATCH 5/7] crypto: caam - more desc.h cleanups

2011-12-12 Thread Kim Phillips
manual removal of double-spaces - no non-whitespace changes. Signed-off-by: Kim Phillips --- drivers/crypto/caam/desc.h | 335 ++-- 1 files changed, 167 insertions(+), 168 deletions(-) diff --git a/drivers/crypto/caam/desc.h b/drivers/crypto/caam/desc.h

[PATCH 2/7] crypto: talitos - remove NO_IRQ references

2011-12-12 Thread Kim Phillips
As prescribed by Linus: https://lkml.org/lkml/2011/12/2/290 Signed-off-by: Kim Phillips --- drivers/crypto/talitos.c | 18 +- 1 files changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/crypto/talitos.c b/drivers/crypto/talitos.c index d376cc7..503d0d8 100644 --- a/

[PATCH 6/7] crypto: caam - fix polarity of "propagate error" logic

2011-12-12 Thread Kim Phillips
the polarity of the definition for error propagation was reverse in the initial desc.h. Fix desc.h and its users. Signed-off-by: Kim Phillips --- drivers/crypto/caam/caamalg.c | 10 +- drivers/crypto/caam/desc.h|4 ++-- drivers/crypto/caam/desc_constr.h |7 ---

[PATCH 0/7] crypto: talitos/caam: SEC h/w v2.0 fix and cleanups

2011-12-12 Thread Kim Phillips
The first patch in the series fixes a boottime oops on SEC h/w v.2.0. The rest are minor cleanups. The fourth - "crypto: caam - desc.h - convert spaces to tabs" - is the result of running unexpand -a on desc.h, and may exceed list message quota limits. If this is the case, please execute unexpand

[PATCH 3/7] crypto: talitos - convert talitos_error to struct device

2011-12-12 Thread Kim Phillips
SEC2/3 h/w doesn't have a dedicated interrupt for errors, and the only callsite for talitos_error has already done the type conversion, so simplify talitos_error to take a pointer to a struct device. Signed-off-by: Kim Phillips --- drivers/crypto/talitos.c |5 ++--- 1 files changed, 2 insert

[PATCH 7/7] crypto: caam - remove DECO access initialization code

2011-12-12 Thread Kim Phillips
Access to the SEC4 DECOs (DEscriptor COntrollers) (for debug purposes) isn't supported or used, and its register access initialization code erroneously makes illegal i/o accesses that show up as errors when run under simulation. Remove it until proper support (via DECORR) is added. Signed-off-by:

[PATCH 1/7] crypto: talitos - fix bad kfree

2011-12-12 Thread Kim Phillips
Fix a kfree to an invalid address which causes an oops when running on SEC v2.0 h/w (introduced in commit 702331b "crypto: talitos - add hmac algorithms"). Signed-off-by: Kim Phillips --- drivers/crypto/talitos.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/dri

Re: [PATCH 1/1] Added CRYPTO_ALG_KERN_DRIVER_ONLY flag.

2011-12-12 Thread Kim Phillips
On Sun, 11 Dec 2011 13:26:26 +0100 Nikos Mavrogiannopoulos wrote: > The added CRYPTO_ALG_KERN_DRIVER_ONLY flag indicates whether a cipher > is only available via a kernel driver. If the cipher implementation > might be available by using an instruction set or by porting the > kernel code, then it

Re: [PATCH 21/21] MODSIGN: Apply signature checking to modules on module load [ver #3]

2011-12-12 Thread David Howells
Rusty Russell wrote: > OK, then you need to generate stripped modules as part of the build, > too. It's a bit of a pain, sure, but hardly a showstopper. They'd have to be maximally stripped so that mkinitrd doesn't do anything to them, but you'd then get the debuginfo from them into the packagi

Re: [PATCH 21/21] MODSIGN: Apply signature checking to modules on module load [ver #3]

2011-12-12 Thread Rusty Russell
On Mon, 12 Dec 2011 01:21:40 +, David Howells wrote: > Rusty Russell wrote: > > > I think you misunderstand, I'm talking about the modinfo command, not > > the .modinfo section. > > Sorry, yes. But why do you need to enhance modinfo? I was suggesting that you want it to print the signatur