Re: [PATCH 1/4] crc32: Bolt on crc32c

2011-10-21 Thread Herbert Xu
On Fri, Oct 21, 2011 at 09:57:03AM -0700, Darrick J. Wong wrote: > > My patchset builds upon Bob Pearson's crc32 patchset from early September. Do > my patches fail to apply after applying his patchset? > > Or, to speed things along, should I simply repost both Bob's and my patches as > one big

Re: [PATCH 1/4] crc32: Bolt on crc32c

2011-10-21 Thread Darrick J. Wong
On Fri, Oct 21, 2011 at 02:28:03PM +0200, Herbert Xu wrote: > On Tue, Oct 04, 2011 at 04:54:03PM -0700, Darrick J. Wong wrote: > > Reuse the existing crc32 code to stamp out a crc32c implementation. > > > > Signed-off-by: Darrick J. Wong > > Did you want this to go through my tree? If so then th

Re: Hardware acceleration indication in af_alg

2011-10-21 Thread Matthias-Christian Ott
On Fri, Oct 21, 2011 at 04:15:41PM +0200, Matthias-Christian Ott wrote: > On Fri, Oct 21, 2011 at 03:23:36PM +0200, Herbert Xu wrote: > > Matthias-Christian Ott wrote: > > > I did some experiments with af_alg and noticed that to be really > > > useful, it should indicate whether a certain algorith

Re: Hardware acceleration indication in af_alg

2011-10-21 Thread Matthias-Christian Ott
On Fri, Oct 21, 2011 at 03:23:36PM +0200, Herbert Xu wrote: > Matthias-Christian Ott wrote: > > I did some experiments with af_alg and noticed that to be really > > useful, it should indicate whether a certain algorithm is hardware > > accelerated. I guess this has to be inferred by the priority o

Re: [PATCH 3/3] Add snappy interface to crypto API

2011-10-21 Thread Herbert Xu
Andi Kleen wrote: > From: Andi Kleen > > Mainly so that ubifs can use it. > > Snappy is a better compressor in the same niche as LZO. > > Only lightly tested so far. Experiences welcome. > > Cc: herb...@gondor.apana.org.au > Cc: dedeki...@gmail.com > Cc: adrian.hun...@intel.com > Signed-off-b

Re: Hardware acceleration indication in af_alg

2011-10-21 Thread Herbert Xu
Matthias-Christian Ott wrote: > I did some experiments with af_alg and noticed that to be really > useful, it should indicate whether a certain algorithm is hardware > accelerated. I guess this has to be inferred by the priority of the > algorithm could be made available via a read-only socket opt

Re: [PATCH] crypto: testmgr: add twofish tests

2011-10-21 Thread Herbert Xu
On Mon, Oct 10, 2011 at 11:03:12PM +0300, Jussi Kivilinna wrote: > Add tests for parallel twofish-x86_64-3way code paths. > > Signed-off-by: Jussi Kivilinna Both patches applied. Thanks! -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~

Re: [PATCH] crypto: Make hifn_795x build depend on !ARCH_DMA_ADDR_T_64BIT

2011-10-21 Thread Herbert Xu
On Mon, Oct 10, 2011 at 12:55:41PM +0200, Richard Weinberger wrote: > hifn_795x works only on 32 bit, remove the detection while loading > the module and catch non-32 bit systems at build time. > > Signed-off-by: Richard Weinberger Patch applied. Thanks! -- Email: Herbert Xu Home Page: http:/

Re: [PATCH] crypto: twofish-x86_64-3way: fix ctr blocksize to 1

2011-10-21 Thread Herbert Xu
On Mon, Oct 10, 2011 at 12:33:02PM +0300, Jussi Kivilinna wrote: > Signed-off-by: Jussi Kivilinna Applied. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe li

Re: [PATCH] crypto: blowfish-x86_64: fix ctr blocksize to 1

2011-10-21 Thread Herbert Xu
On Mon, Oct 10, 2011 at 12:32:15PM +0300, Jussi Kivilinna wrote: > Signed-off-by: Jussi Kivilinna Applied. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe li

Re: [PATCH] whirlpool: count rounds from 0

2011-10-21 Thread Herbert Xu
On Tue, Sep 27, 2011 at 08:26:24AM +0300, Alexey Dobriyan wrote: > rc[0] is unused because rounds are counted from 1. > Save an u64! > > Signed-off-by: Alexey Dobriyan Patch applied. Thanks! -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.

Re: [PATCH v4 00/17] crypto user configuration api

2011-10-21 Thread Herbert Xu
On Tue, Sep 27, 2011 at 07:20:50AM +0200, Steffen Klassert wrote: > This patchset adds a netlink based user configuration API for the crypto > layer, similar to the configuration API of xfrm. All applied to cryptodev. Thanks! I added this little fix on top: commit e6ea64ece7f4c14294b2fce5403b1e

Re: [PATCH 3/3] crypto: twofish: add 3-way parallel x86_64 assembler implemention

2011-10-21 Thread Herbert Xu
On Mon, Sep 26, 2011 at 04:47:25PM +0300, Jussi Kivilinna wrote: > Patch adds 3-way parallel x86_64 assembly implementation of twofish as new > module. New assembler functions crypt data in three blocks chunks, improving > cipher performance on out-of-order CPUs. All three patches applied. Thanks

Re: [PATCH 2/2] crypto: blowfish-x86_64: add credits

2011-10-21 Thread Herbert Xu
On Fri, Sep 23, 2011 at 07:51:00PM +0300, Jussi Kivilinna wrote: > Signed-off-by: Jussi Kivilinna Both patches applied. Thanks! -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send th

Re: [PATCH 1/4] crc32: Bolt on crc32c

2011-10-21 Thread Herbert Xu
On Tue, Oct 04, 2011 at 04:54:03PM -0700, Darrick J. Wong wrote: > Reuse the existing crc32 code to stamp out a crc32c implementation. > > Signed-off-by: Darrick J. Wong Did you want this to go through my tree? If so then there is a problem since it doesn't apply at all. Cheers, -- Email: Herb

Re: [PATCH] crypto: blowfish-x86_64: fix ctr blocksize to 1

2011-10-21 Thread Herbert Xu
On Fri, Oct 21, 2011 at 02:17:49PM +0200, Herbert Xu wrote: > On Mon, Oct 10, 2011 at 12:32:15PM +0300, Jussi Kivilinna wrote: > > Signed-off-by: Jussi Kivilinna > > What is the rationale for this? Blowfish is not a stream cipher. Scratch that, I missed the bit about ctr. Thanks, -- Email: Her

Re: [PATCH] crypto: blowfish-x86_64: fix ctr blocksize to 1

2011-10-21 Thread Herbert Xu
On Mon, Oct 10, 2011 at 12:32:15PM +0300, Jussi Kivilinna wrote: > Signed-off-by: Jussi Kivilinna What is the rationale for this? Blowfish is not a stream cipher. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.tx

Re: Crypto Fixes for 3.1

2011-10-21 Thread Herbert Xu
On Fri, Oct 21, 2011 at 02:41:54AM -0700, David Rientjes wrote: > On Fri, 21 Oct 2011, Herbert Xu wrote: > > > Hi Linus: > > > > This push fixes a NULL-pointer dereference that can be triggered > > from user-space. > > > > Please pull from > > > > git://github.com/herbertx/crypto.git > > > >

Re: Crypto Fixes for 3.1

2011-10-21 Thread David Rientjes
On Fri, 21 Oct 2011, Herbert Xu wrote: > Hi Linus: > > This push fixes a NULL-pointer dereference that can be triggered > from user-space. > > Please pull from > > git://github.com/herbertx/crypto.git > Hi Herbert, When I pull from this, I also get commit 9c129165af0225c63c37d1896ac9b0d34e

Crypto Fixes for 3.1

2011-10-21 Thread Herbert Xu
Hi Linus: This push fixes a NULL-pointer dereference that can be triggered from user-space. Please pull from git://github.com/herbertx/crypto.git Nick Bowler (1): crypto: ghash - Avoid null pointer dereference if no key is set crypto/ghash-generic.c |6 ++ 1 files changed, 6 in

Re: cryptodev tree on github

2011-10-21 Thread Herbert Xu
On Sun, Sep 25, 2011 at 02:50:23PM +1000, Herbert Xu wrote: > Stephen Rothwell wrote: > > > Are you also going to move crypto-curent? > > I'll create that soon. I'll let you know when it happens. Hi Stephen: The crypto-current tree is now up at git://github.com/herbertx/crypto.git T