Re: [PATCH] talitos: handle descriptor not found in error path

2011-10-18 Thread Kim Phillips
On Tue, 18 Oct 2011 09:36:18 +0200 Herbert Xu wrote: > Kim Phillips wrote: > > The CDPR (Current Descriptor Pointer Register) can be unreliable > > when trying to locate an offending descriptor. Handle that case by > > (a) not OOPSing, and (b) reverting to the machine internal copy of > > the d

Hardware acceleration indication in af_alg

2011-10-18 Thread Matthias-Christian Ott
I did some experiments with af_alg and noticed that to be really useful, it should indicate whether a certain algorithm is hardware accelerated. I guess this has to be inferred by the priority of the algorithm could be made available via a read-only socket option. Any thoughts on this? I can imagi

[PATCH 18/18] crypto: twofish-x86_64-3way: add xts support

2011-10-18 Thread Jussi Kivilinna
Patch adds XTS support for twofish-x86_64-3way by using xts_crypt(). Patch has been tested with tcrypt and automated filesystem tests. Tcrypt benchmarks results (twofish-3way/twofish-asm speed ratios): Intel Celeron T1600 (fam:6, model:15, step:13): sizexts-enc xts-dec 16B 0.98x 1.00x

[PATCH 16/18] crypto: testmgr: add xts(twofish) test vectors

2011-10-18 Thread Jussi Kivilinna
Add test vectors for xts(twofish). These are generated from xts(twofish) test vectors. Signed-off-by: Jussi Kivilinna --- crypto/testmgr.c | 15 + crypto/testmgr.h | 681 ++ 2 files changed, 696 insertions(+), 0 deletions(-) diff --git a/c

[PATCH 17/18] crypto: tcrypt: add xts(twofish) tests

2011-10-18 Thread Jussi Kivilinna
Signed-off-by: Jussi Kivilinna --- crypto/tcrypt.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/crypto/tcrypt.c b/crypto/tcrypt.c index a664595..7736a9f 100644 --- a/crypto/tcrypt.c +++ b/crypto/tcrypt.c @@ -991,6 +991,7 @@ static int do_test(int m)

[PATCH 14/18] crypto: tcrypt: add xts(serpent) tests

2011-10-18 Thread Jussi Kivilinna
Signed-off-by: Jussi Kivilinna --- crypto/tcrypt.c |9 + crypto/tcrypt.h |1 + 2 files changed, 10 insertions(+), 0 deletions(-) diff --git a/crypto/tcrypt.c b/crypto/tcrypt.c index 0120383..a664595 100644 --- a/crypto/tcrypt.c +++ b/crypto/tcrypt.c @@ -998,6 +998,7 @@ static int

[PATCH 15/18] crypto: serpent-sse2: add xts support

2011-10-18 Thread Jussi Kivilinna
Patch adds XTS support for serpent-sse2 by using xts_crypt(). Patch has been tested with tcrypt and automated filesystem tests. Tcrypt benchmarks results (serpent-sse2/serpent_generic speed ratios): Intel Celeron T1600 (x86_64) (fam:6, model:15, step:13): sizexts-enc xts-dec 16B 0.98x

[PATCH 12/18] crypto: xts: add interface for parallelized cipher implementations

2011-10-18 Thread Jussi Kivilinna
Add xts_crypt() function that can be used by cipher implementations that can benefit from parallelized cipher operations. Signed-off-by: Jussi Kivilinna --- crypto/xts.c | 74 +- include/crypto/xts.h | 27 ++ 2 files cha

[PATCH 13/18] crypto: testmgr: add xts(serpent) test vectors

2011-10-18 Thread Jussi Kivilinna
Add test vectors for xts(serpent). These are generated from xts(aes) test vectors. Signed-off-by: Jussi Kivilinna --- crypto/testmgr.c | 15 + crypto/testmgr.h | 682 ++ 2 files changed, 697 insertions(+), 0 deletions(-) diff --git a/crypt

[PATCH 11/18] crypto: xts: use blocksize constant

2011-10-18 Thread Jussi Kivilinna
XTS has fixed blocksize of 16. Define XTS_BLOCK_SIZE and use in place of crypto_cipher_blocksize(). Signed-off-by: Jussi Kivilinna --- crypto/xts.c |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/crypto/xts.c b/crypto/xts.c index 8517054..96f3f88 100644 --- a/cryp

[PATCH 10/18] crypto: twofish-x86_64-3way: add lrw support

2011-10-18 Thread Jussi Kivilinna
Patch adds LRW support for twofish-x86_64-3way by using lrw_crypt(). Patch has been tested with tcrypt and automated filesystem tests. Tcrypt benchmarks results (twofish-3way/twofish-asm speed ratios): Intel Celeron T1600 (fam:6, model:15, step:13): sizelrw-enc lrw-dec 16B 0.99x 1.00x

[PATCH 09/18] crypto: tcrypt: add lrw(twofish) tests

2011-10-18 Thread Jussi Kivilinna
Signed-off-by: Jussi Kivilinna --- crypto/tcrypt.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/crypto/tcrypt.c b/crypto/tcrypt.c index 9a9e170..0120383 100644 --- a/crypto/tcrypt.c +++ b/crypto/tcrypt.c @@ -990,6 +990,7 @@ static int do_test(int m)

[PATCH 08/18] crypto: testmgr: add lrw(twofish) test vectors

2011-10-18 Thread Jussi Kivilinna
Add test vectors for lrw(twofish). These are generated from lrw(aes) test vectors. Signed-off-by: Jussi Kivilinna --- crypto/testmgr.c | 15 ++ crypto/testmgr.h | 501 ++ 2 files changed, 516 insertions(+), 0 deletions(-) diff --git a/cryp

[PATCH 07/18] crypto: serpent-sse2: add lrw support

2011-10-18 Thread Jussi Kivilinna
Patch adds LRW support for serpent-sse2 by using lrw_crypt(). Patch has been tested with tcrypt and automated filesystem tests. Tcrypt benchmarks results (serpent-sse2/serpent_generic speed ratios): Benchmark results with tcrypt: Intel Celeron T1600 (x86_64) (fam:6, model:15, step:13): size

[PATCH 06/18] crypto: tcrypt: add lrw(serpent) tests

2011-10-18 Thread Jussi Kivilinna
Signed-off-by: Jussi Kivilinna --- crypto/tcrypt.c |9 + crypto/tcrypt.h |1 + 2 files changed, 10 insertions(+), 0 deletions(-) diff --git a/crypto/tcrypt.c b/crypto/tcrypt.c index 5526065..9a9e170 100644 --- a/crypto/tcrypt.c +++ b/crypto/tcrypt.c @@ -996,6 +996,7 @@ static int

[PATCH 05/18] crypto: testmgr: add lrw(serpent) test vectors

2011-10-18 Thread Jussi Kivilinna
Add test vectors for lrw(serpent). These are generated from lrw(aes) test vectors. Signed-off-by: Jussi Kivilinna --- crypto/testmgr.c | 15 ++ crypto/testmgr.h | 502 ++ 2 files changed, 517 insertions(+), 0 deletions(-) diff --git a/cryp

[PATCH 04/18] crypto: lrw: add interface for parallelized cipher implementions

2011-10-18 Thread Jussi Kivilinna
Export gf128mul table initialization routines and add lrw_crypt() function that can be used by cipher implementations that can benefit from parallelized cipher operations. Signed-off-by: Jussi Kivilinna --- crypto/lrw.c | 105 -- include/c

[PATCH 03/18] crypto: lrw: split gf128mul table initialization from setkey

2011-10-18 Thread Jussi Kivilinna
Split gf128mul initialization from setkey so that it can be used outside lrw-module. Signed-off-by: Jussi Kivilinna --- crypto/lrw.c | 61 ++ 1 files changed, 40 insertions(+), 21 deletions(-) diff --git a/crypto/lrw.c b/crypto/lrw.c ind

[PATCH 02/18] crypto: lrw: use blocksize constant

2011-10-18 Thread Jussi Kivilinna
LRW has fixed blocksize of 16. Define LRW_BLOCK_SIZE and use in place of crypto_cipher_blocksize(). Signed-off-by: Jussi Kivilinna --- crypto/lrw.c |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/crypto/lrw.c b/crypto/lrw.c index fca3246..bee6022 100644 --- a/cryp

[PATCH 01/18] crypto: lrw: fix memleak

2011-10-18 Thread Jussi Kivilinna
LRW module leaks child cipher memory when init_tfm() fails because of child block size not being 16. Signed-off-by: Jussi Kivilinna --- crypto/lrw.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/crypto/lrw.c b/crypto/lrw.c index 358f80b..fca3246 100644 --- a/crypto/lrw

[PATCH 00/18] crypto: Add helper functions for parallelized LRW and XTS modes

2011-10-18 Thread Jussi Kivilinna
This series adds lrw_crypt() and xts_crypt() functions for cipher implementations that can benefit from parallel cipher block operations. To make interface flexible, caller is reponsible of allocating buffer large enough to store temporary cipher blocks. This buffer size should be as large as siz

Re: [PATCH] talitos: handle descriptor not found in error path

2011-10-18 Thread Herbert Xu
Kim Phillips wrote: > The CDPR (Current Descriptor Pointer Register) can be unreliable > when trying to locate an offending descriptor. Handle that case by > (a) not OOPSing, and (b) reverting to the machine internal copy of > the descriptor header in order to report the correct execution unit >