Re: [PATCH v4] crc32c: Implement CRC32c with slicing-by-8 algorithm

2011-10-04 Thread Darrick J. Wong
On Tue, Oct 04, 2011 at 07:59:53AM +0100, Herbert Xu wrote: > On Mon, Oct 03, 2011 at 05:55:10PM -0700, Darrick J. Wong wrote: > > > > So what I think I'm hearing is... > > > > 1. Apply Bob's slice-by-8 algorithm patch to regular crc32. > > 2. Adapt crc32's build code to generate crc32c as well. >

[PATCH 4/4] crc32: Select an algorithm via kconfig

2011-10-04 Thread Darrick J. Wong
Allow the kernel builder to choose a crc32* algorithm for the kernel. Signed-off-by: Darrick J. Wong --- lib/Kconfig | 35 +++ lib/crc32defs.h | 18 ++ 2 files changed, 53 insertions(+), 0 deletions(-) diff --git a/lib/Kconfig b/lib/Kconf

[PATCH 3/4] crc32: Add self-test code for crc32c

2011-10-04 Thread Darrick J. Wong
Add self-test code for crc32c. Signed-off-by: Darrick J. Wong --- lib/crc32.c | 363 ++- 1 files changed, 261 insertions(+), 102 deletions(-) diff --git a/lib/crc32.c b/lib/crc32.c index 8df9561..382fa76 100644 --- a/lib/crc32.c +++ b/li

[PATCH 2/4] crypto: crc32c should use library implementation

2011-10-04 Thread Darrick J. Wong
Since lib/crc32.c now provides crc32c, remove the software implementation here and call the library function instead. Signed-off-by: Darrick J. Wong --- crypto/Kconfig |1 + crypto/crc32c.c | 94 ++- 2 files changed, 4 insertions(+), 91

[PATCH 1/4] crc32: Bolt on crc32c

2011-10-04 Thread Darrick J. Wong
Reuse the existing crc32 code to stamp out a crc32c implementation. Signed-off-by: Darrick J. Wong --- include/linux/crc32.h |2 ++ lib/Kconfig |8 +++--- lib/crc32.c | 62 +++-- lib/crc32defs.h |7 ++ lib/ge

[PATCH v5 0/4] crc32c: Add faster algorithm and self-test code

2011-10-04 Thread Darrick J. Wong
Hi all, This patchset (re)uses Bob Pearson's crc32 slice-by-8 code to stamp out a software crc32c implementation. It requires that all ten of his patches (at least the ones dated 31 Aug 2011) be applied. It removes the crc32c implementation in crypto/ in favor of using the stamped-out one in lib

Re: [RFC v2.1 0/6] evm: digital signature verification extension

2011-10-04 Thread Herbert Xu
On Thu, Sep 29, 2011 at 10:42:46AM +1000, James Morris wrote: > On Thu, 29 Sep 2011, Herbert Xu wrote: > > > Well if James is OK with adding the user for this then I'm fine > > with adding the necessary infrastructure. > > Are you happy with the API? As there is only one user, we can add whateve

Re: Fwd: crypto accelerator driver problems

2011-10-04 Thread Steffen Klassert
On Sat, Oct 01, 2011 at 12:38:19PM +0330, Hamid Nassiby wrote: > > And my_cbc_encrypt function as PSEUDO/real code (for simplicity of > representation) is as: > > static int > my_cbc_encrypt(struct blkcipher_desc *desc, > struct scatterlist *dst, struct scatterlist *src, >

Re: [PATCH v4] crc32c: Implement CRC32c with slicing-by-8 algorithm

2011-10-04 Thread Herbert Xu
On Mon, Oct 03, 2011 at 05:55:10PM -0700, Darrick J. Wong wrote: > > So what I think I'm hearing is... > > 1. Apply Bob's slice-by-8 algorithm patch to regular crc32. > 2. Adapt crc32's build code to generate crc32c as well. > 3. Remove crypto/crc32c.c's implementation and have it wrap the code ge