Re: [PATCH 01/16] crypto: authenc - Don't multiply priorities

2011-08-16 Thread Steffen Klassert
On Tue, Aug 16, 2011 at 08:30:51PM +0800, Herbert Xu wrote: > > We don't want to automatically update a value that the user may > have previously set. So I think updating instances on mass won't > work anyway. > > Besides, an instance may depend on an algorithm which should not > influence its p

Re: [PATCH] crypto: aesni-intel - Add ivsize to ablk_ecb_alg

2011-08-16 Thread Herbert Xu
On Mon, Aug 15, 2011 at 07:50:39AM -0400, Josh Boyer wrote: > > Well, yes, it does in this code: > > if (!((alg->cra_flags & CRYPTO_ALG_TYPE_MASK) == > CRYPTO_ALG_TYPE_BLKCIPHER ? alg->cra_blkcipher.ivsize : > alg->cra_ablkcipher.ivsize)) {

Re: [PATCH 01/16] crypto: authenc - Don't multiply priorities

2011-08-16 Thread Herbert Xu
On Mon, Aug 15, 2011 at 12:08:06PM +0200, Steffen Klassert wrote: > > I think the only value of the priority update is, if we can do it > without removing existing transforms. If this is not possible > it is much easier to just delete the algorithm in question and > to build a new one with the upda