Re: [PATCH] hwrng: ppc4xx - add support for ppc4xx TRNG

2011-06-21 Thread Matt Mackall
On Tue, 2011-06-21 at 11:38 -0500, Kim Phillips wrote: > [adding linux-crypto] > > On Tue, 21 Jun 2011 10:56:02 -0500 > Matt Mackall wrote: > > > On Tue, 2011-06-21 at 08:19 -0400, Josh Boyer wrote: > > > +static struct hwrng ppc4xx_rng = { > > > + .name = MODULE_NAME, > > > + .data_present = pp

Re: [PATCH] hwrng: ppc4xx - add support for ppc4xx TRNG

2011-06-21 Thread Kim Phillips
[adding linux-crypto] On Tue, 21 Jun 2011 10:56:02 -0500 Matt Mackall wrote: > On Tue, 2011-06-21 at 08:19 -0400, Josh Boyer wrote: > > +static struct hwrng ppc4xx_rng = { > > + .name = MODULE_NAME, > > + .data_present = ppc4xx_rng_data_present, > > + .data_read = ppc4xx_rng_data_read, > >

[PATCH] crypto: crypto4xx - Perform read/modify/write on device control register

2011-06-21 Thread Josh Boyer
The Security function on the AMCC SoCs has multiple engines within a single MMIO range. The crypto driver currently enables the 3DES functionality by doing a blind write to the device control register. This can unintentionally disable other functions like the PKA or TRNG when the driver is loaded.