Re: [PATCH 4/8] s390: add System z hardware support for CTR mode

2011-04-27 Thread Herbert Xu
On Wed, Apr 27, 2011 at 12:37:20PM +0200, Jan Glauber wrote: > On Tue, 2011-04-26 at 16:34 +1000, Herbert Xu wrote: > > On Tue, Apr 19, 2011 at 09:29:17PM +0200, j...@linux.vnet.ibm.com wrote: > > > > > > @@ -664,11 +784,6 @@ static int __init aes_s390_init(void) > > > if (ret) > > > go

Re: [PATCH 4/8] s390: add System z hardware support for CTR mode

2011-04-27 Thread Jan Glauber
On Tue, 2011-04-26 at 16:34 +1000, Herbert Xu wrote: > On Tue, Apr 19, 2011 at 09:29:17PM +0200, j...@linux.vnet.ibm.com wrote: > > > > @@ -664,11 +784,6 @@ static int __init aes_s390_init(void) > > if (ret) > > goto cbc_aes_err; > > > > - /* skip XTS if MSA-4 is not available *

Re: shash_alg size fields and stomping memory

2011-04-27 Thread Herbert Xu
Kent Borg wrote: > > My most recent discovery is that if I want to do an shash_desc_ctx() and > use the result, cra_ctxsize doesn't seem to mean a thing. Rather, > unless I set descsize, memory will be stomped. descsize specifies the size of shash_desc_ctx. ctxsize is the size of crypto_shas