Re: [PATCH 1/4] crypto: caam - handle interrupt lines shared across rings

2011-04-15 Thread Herbert Xu
On Mon, Apr 11, 2011 at 07:15:16PM -0500, Kim Phillips wrote: > - add IRQF_SHARED to request_irq flags to support parts such as > the p1023 that has one IRQ line per couple of rings. > > - resetting a job ring triggers an interrupt, so move request_irq > prior to jr_reset to avoid 'got IRQ but nob

Re: aead: driver side documentation

2011-04-15 Thread Herbert Xu
On Fri, Apr 08, 2011 at 03:44:01PM -0500, Kim Phillips wrote: > the following conditions in a driver setkey fail: > > if (!RTA_OK(rta, keylen)) > goto badkey; > > if (rta->rta_type != CRYPTO_AUTHENC_KEYA_PARAM) > goto badkey; > > because testmgr ke