Re: aead: driver side documentation

2011-04-08 Thread Kim Phillips
On Fri, 8 Apr 2011 08:55:33 +0800 Herbert Xu wrote: > Kim Phillips wrote: > > > > I started to add test vectors from [1] to crypto/testmgr.c, but it > > required that drivers not assume associated data, iv, and cipher data > > were contiguous in memory, and since some of them do, I don't know if

Re: [PATCH] crypto: blowfish: Fixed a multi line macro issue

2011-04-08 Thread David Miller
From: Aditya Shevade Date: Fri, 8 Apr 2011 10:46:57 -0700 > Oh, I see the problem. I forgot a semicolon in the commit file. Making > the change. I think it's even more important that you are submitting patches you aren't even build testing. -- To unsubscribe from this list: send the line "unsubs

Re: [PATCH] crypto: blowfish: Fixed a multi line macro issue

2011-04-08 Thread Aditya Shevade
On Fri, Apr 8, 2011 at 5:45 AM, Herbert Xu wrote: > > On Wed, Apr 06, 2011 at 11:49:20PM -0700, Aditya Shevade wrote: > > Fixed a multi line macro with do-while loop. > > Fixed some other minor tab related issues. > > > > Signed-off-by: Aditya Shevade > > Your patch doesn't even build! > -- > Ema

Re: [PATCH] crypto: blowfish: Fixed a multi line macro issue

2011-04-08 Thread Herbert Xu
On Wed, Apr 06, 2011 at 11:49:20PM -0700, Aditya Shevade wrote: > Fixed a multi line macro with do-while loop. > Fixed some other minor tab related issues. > > Signed-off-by: Aditya Shevade Your patch doesn't even build! -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP

Re: [PATCH 2/6] drivers/crypto/caam/caamalg.c: introduce missing kfree

2011-04-08 Thread Herbert Xu
On Fri, Apr 01, 2011 at 02:42:05PM -0500, Kim Phillips wrote: > On Fri, 1 Apr 2011 16:23:43 +0200 > Julia Lawall wrote: > > > Error handling code following a kmalloc should free the allocated data. > > > Signed-off-by: Julia Lawall > > --- > > Acked-by: Kim Phillips Patch applied. Thanks! -

Re: [PATCH] crypto: add S5PV210 advanced crypto engine support.

2011-04-08 Thread Herbert Xu
On Sat, Apr 02, 2011 at 08:11:18PM +0300, Vladimir Zapolskiy wrote: > This change adds support for AES encrypting and decrypting using > advanced crypto engine found on Samsung S5PV210 and S5PC110 SoCs. > > Signed-off-by: Vladimir Zapolskiy Patch applied. Thanks! -- Email: Herbert Xu Home Pag