RE: [PATCH] crypto: padlock - Add SHA-1/256 module for VIA Nano

2011-03-23 Thread BrillyWu
Thanks for your guide, it's just my mailer's malfunction. I have made a test and it can work now. Please check it. Add new SHA-1/256 module that never needs any fallback and just calls the PadLock hardware instruction supported from VIA Nano processors to implement the "update" and "final" functi

Re: [PATCH] crypto: padlock - Add SHA-1/256 module for VIA Nano

2011-03-23 Thread Herbert Xu
On Tue, Mar 22, 2011 at 04:52:33PM +0800, Herbert Xu wrote: > On Tue, Mar 22, 2011 at 02:10:13PM +0800, brill...@viatech.com.cn wrote: > > Add new SHA-1/256 module that never needs any fallback and just calls > > the > > PadLock hardware instruction supported from VIA Nano processors to > > impleme

[PATCH] picoxcell-crypto: fix possible status FIFO overflow

2011-03-23 Thread Jamie Iles
The SPAcc's have 2 equally sized FIFO's - a command FIFO and a status FIFO. The command FIFO takes the requests that are to be performed and the status FIFO reports the results. It is possible to get into the situation where there are more free spaces in the command FIFO than the status FIFO if w

Re: [PATCH] crypto: caam - de-CHIP-ify device tree compatibles

2011-03-23 Thread Herbert Xu
On Tue, Mar 15, 2011 at 06:59:51PM -0600, Grant Likely wrote: > On Tue, Mar 15, 2011 at 04:52:20PM -0500, Kim Phillips wrote: > > - all the integration parameters have been captured by the binding. > > - the block name really uniquely identifies this hardware. > > > > Some advocate putting SoC nam

Re: [patch] crypto: caam - ARRAY_SIZE() vs sizeof()

2011-03-23 Thread Herbert Xu
On Tue, Mar 15, 2011 at 05:20:37PM -0500, Kim Phillips wrote: > On Tue, 15 Mar 2011 09:59:55 +0300 > Dan Carpenter wrote: > > > ARRAY_SIZE() was intended here instead of sizeof(). sizeof() is four > > times larger than ARRAY_SIZE(). outstr is normally 256 chars so > > printing garbage to it co

Re: [patch] crypto: caam - dereferencing ERR_PTR on allocation failure

2011-03-23 Thread Herbert Xu
On Tue, Mar 15, 2011 at 05:20:34PM -0500, Kim Phillips wrote: > On Tue, 15 Mar 2011 09:57:47 +0300 > Dan Carpenter wrote: > > > t_alg is an ERR_PTR here so we can't dereference it. > > > > Signed-off-by: Dan Carpenter > > --- > > Acked-by: Kim Phillips Applied. -- Email: Herbert Xu Home Pa

Re: [PATCH] crypto: caam - standardize device tree naming convention to utilize '-vX.Y'

2011-03-23 Thread Herbert Xu
On Mon, Mar 14, 2011 at 05:42:47PM -0500, Kim Phillips wrote: > Help clarify that the number trailing in compatible nomenclature > is the version number of the device, i.e., change: > > "fsl,p4080-sec4.0", "fsl,sec4.0"; > > to: > > "fsl,p4080-sec-v4.0", "fsl,sec-v4.0"; > > Signed-off-by: Kim Ph