[patch] crypto: caam - dereferencing ERR_PTR on allocation failure

2011-03-14 Thread Dan Carpenter
t_alg is an ERR_PTR here so we can't dereference it. Signed-off-by: Dan Carpenter --- This doesn't compile for me. Sorry. diff --git a/drivers/crypto/caam/caamalg.c b/drivers/crypto/caam/caamalg.c index d7fe3d3..a27b6d3 100644 --- a/drivers/crypto/caam/caamalg.c +++ b/drivers/crypto/caam/caamal

[PATCH] crypto: caam - standardize device tree naming convention to utilize '-vX.Y'

2011-03-14 Thread Kim Phillips
Help clarify that the number trailing in compatible nomenclature is the version number of the device, i.e., change: "fsl,p4080-sec4.0", "fsl,sec4.0"; to: "fsl,p4080-sec-v4.0", "fsl,sec-v4.0"; Signed-off-by: Kim Phillips Cc: Kumar Gala Cc: Steve Cornelius --- .../devicetree/bindings/crypto/f

Re: [PATCH 0/2] Add struct crypto_alg->cra_check_optimized for crc32c_intel

2011-03-14 Thread Nicholas A. Bellinger
On Sun, 2011-03-13 at 17:01 +0800, Herbert Xu wrote: > On Thu, Mar 10, 2011 at 02:05:17AM -0800, Nicholas A. Bellinger wrote: > > > > We are still expecting the libcrypto consumer (iscsi_target_mod.ko) to > > call the arch independent crypto_alloc_hash("crc32c", ...) in order to > > have libcrypto

Re: [RFC v2 PATCH 1/9] crypto: authencesn - Add algorithm to handle IPsec extended sequence numbers

2011-03-14 Thread Steffen Klassert
On Mon, Mar 14, 2011 at 05:39:07PM +0800, Herbert Xu wrote: > > > > Not sure if I get you right, but we do not set this flag here. > > We use it to mask the flags we got from the request, so we pass > > this flag to the ahash algorithm just if it was set by the > > original aead request. > > Inde

Re: [RFC v2 PATCH 1/9] crypto: authencesn - Add algorithm to handle IPsec extended sequence numbers

2011-03-14 Thread Herbert Xu
On Mon, Mar 14, 2011 at 09:37:41AM +0100, Steffen Klassert wrote: > On Sun, Mar 13, 2011 at 02:30:17PM +0800, Herbert Xu wrote: > > On Tue, Mar 08, 2011 at 11:04:58AM +0100, Steffen Klassert wrote: > > > > > > + return crypto_authenc_esn_genicv(req, iv, CRYPTO_TFM_REQ_MAY_SLEEP); > > > > BTW, we s

Re: [RFC v2 PATCH 1/9] crypto: authencesn - Add algorithm to handle IPsec extended sequence numbers

2011-03-14 Thread Steffen Klassert
On Sun, Mar 13, 2011 at 02:30:17PM +0800, Herbert Xu wrote: > On Tue, Mar 08, 2011 at 11:04:58AM +0100, Steffen Klassert wrote: > > > > + return crypto_authenc_esn_genicv(req, iv, CRYPTO_TFM_REQ_MAY_SLEEP); > > BTW, we should get rid of these MAY_SLEEP flags. Originally I > included them for th