Re: [PATCH v1.3 4/4] keys: add new key-type encrypted

2010-11-16 Thread Mimi Zohar
On Tue, 2010-11-16 at 17:50 +, David Howells wrote: > Mimi Zohar wrote: > > > I actually like keyctl requiring 'trusted:' or 'user:'. Forcing the > > user to indicate which type of key they want, is actually good - no > > misunderstandings. > > You still need to prefix the description of a

Re: [PATCH v1.3 4/4] keys: add new key-type encrypted

2010-11-16 Thread David Howells
Mimi Zohar wrote: > No, this just updates the name of the key used to encrypt/decrypt the > encrypted key. For example, the encrypted key evm-key is initially > encrypted/decrypted using 'kmk-trusted'. After the update, it is > encrypted/decrypted with 'kmk'. Both now are trusted keys. Gotcha.

Re: [PATCH v1.3 4/4] keys: add new key-type encrypted

2010-11-16 Thread Mimi Zohar
On Tue, 2010-11-16 at 17:50 +, David Howells wrote: > Mimi Zohar wrote: > > > I actually like keyctl requiring 'trusted:' or 'user:'. Forcing the > > user to indicate which type of key they want, is actually good - no > > misunderstandings. > > You still need to prefix the description of a

Re: [PATCH v1.3 4/4] keys: add new key-type encrypted

2010-11-16 Thread David Howells
Mimi Zohar wrote: > I actually like keyctl requiring 'trusted:' or 'user:'. Forcing the > user to indicate which type of key they want, is actually good - no > misunderstandings. You still need to prefix the description of a user-defined key so that you don't collide with other people who're al

Re: [PATCH 3/7] omap-sham: OMAP macros corrected

2010-11-16 Thread Tony Lindgren
* Dmitry Kasatkin [101110 09:20]: > Signed-off-by: Dmitry Kasatkin > --- > arch/arm/mach-omap2/devices.c |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c > index beac46c..79dbf04 100644 > --- a/arch/ar

Re: [PATCH 1/7] crypto: updates omap sham device related platform code

2010-11-16 Thread Tony Lindgren
* Dmitry Kasatkin [101110 09:20]: > - registration with multi OMAP kernels support > - clocks > > Signed-off-by: Dmitry Kasatkin > --- > arch/arm/mach-omap2/clock2420_data.c |2 +- > arch/arm/mach-omap2/clock2430_data.c |2 +- > arch/arm/mach-omap2/clock3xxx_data.c |

Re: [PATCH 1/5] crypto: omap-aes: change in prevention of OCP bus error

2010-11-16 Thread Tony Lindgren
Hi, * Dmitry Kasatkin [101110 09:18]: > Suggested to use udelay() instead of nop as on the higher > core frequencies it might not be enough time. > > Signed-off-by: Dmitry Kasatkin > --- > drivers/crypto/omap-aes.c | 10 ++ > 1 files changed, 6 insertions(+), 4 deletions(-) > > diff