Re: [PATCH 1/1] crypto: api.c: doc on crypto_alg_lookup, crypto_larval_lookup, and crypto_alg_mod_lookup

2010-11-06 Thread Herbert Xu
Allyn, Mark A wrote: > > I was making an assumption that larval is shorthand for large value as there > is nothing meaningful in google except for a type of wormlike form. Larval means not fully grown in this context, i.e., the algorithm that we've constructed will be filled in later to become

Re: [PATCH 4/4] crypto: algif_skcipher - User-space interface for skcipher operations

2010-11-06 Thread Herbert Xu
Martin Willi wrote: > Hi Herbert, > > I did a proof-of-concept implementation for our crypto library, the > interface looks good so far. All our hash, hmac, xcbc and cipher test > vectors matched. > >> + sg_assign_page(sg + i, alloc_page(GFP_KERNEL)); > > Every skcipher oper

[PATCH] Crypto: Makefile: Makefile clean up

2010-11-06 Thread Tracey Dent
Changed Makefile to use -y instead of -objs. Signed-off-by: Tracey Dent --- crypto/Makefile | 14 +++--- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git a/crypto/Makefile b/crypto/Makefile index 423b7de..40a9e43 100644 --- a/crypto/Makefile +++ b/crypto/Makefile @@ -3,32 +

Re: [PATCH 4/4] crypto: algif_skcipher - User-space interface for skcipher operations

2010-11-06 Thread Martin Willi
Hi Herbert, I did a proof-of-concept implementation for our crypto library, the interface looks good so far. All our hash, hmac, xcbc and cipher test vectors matched. > + sg_assign_page(sg + i, alloc_page(GFP_KERNEL)); Every skcipher operation leaks memory on my box (this pag