Re: RFC: Crypto API User-interface

2010-09-07 Thread Christoph Hellwig
On Tue, Sep 07, 2010 at 04:57:04PM +0200, Nikos Mavrogiannopoulos wrote: > Or that someone is not really aware of some cryptographic uses. > Embedded systems have crypto accelerators in hardware available > through kernel device drivers. In the systems I worked the > accelerators via a crypto devic

Re: RFC: Crypto API User-interface

2010-09-07 Thread Nikos Mavrogiannopoulos
On Tue, Sep 7, 2010 at 4:06 PM, Christoph Hellwig wrote: >> This is what I am proposing for the Crypto API user-interface. > > Can you explain why we would ever want a userspace interface to it? > > doing crypto in kernel for userspace consumers sis simply insane. > It's computational intensive co

Re: RFC: Crypto API User-interface

2010-09-07 Thread Christoph Hellwig
On Tue, Sep 07, 2010 at 10:52:03AM -0400, Miloslav Trmac wrote: > Because in the real world people want both certification, features _and_ > performance. If all they cared about is certification they could just as > well buy a pencil. Okay Mr Smartass. Please put away your crackpipe and get do

Re: RFC: Crypto API User-interface

2010-09-07 Thread Miloslav Trmac
- "Christoph Hellwig" wrote: > On Tue, Sep 07, 2010 at 10:34:25AM -0400, Miloslav Trmac wrote: > > - Don't use a FD for associated data that is limited to 16? bytes > > > > - Don't use file descriptors for input data at all, if it makes the > interface so complex. > > Calling into the kern

Re: RFC: Crypto API User-interface

2010-09-07 Thread Christoph Hellwig
On Tue, Sep 07, 2010 at 10:34:25AM -0400, Miloslav Trmac wrote: > - Don't use a FD for associated data that is limited to 16? bytes > > - Don't use file descriptors for input data at all, if it makes the interface > so complex. Calling into the kernel for 16 bytes of crypto is a braindead idea t

Re: RFC: Crypto API User-interface

2010-09-07 Thread Miloslav Trmac
- "Herbert Xu" wrote: > On Tue, Sep 07, 2010 at 10:34:25AM -0400, Miloslav Trmac wrote: > > > > > > > /* These may also be set through sendmsg(2) cmsgs. */ > > > > > op = ALG_AEAD_OP_ENCRYPT; > > > > > setsockopt(opfd, SOL_ALG, ALG_AEAD_OP, op, sizeof(op)); > > > > > se

Re: RFC: Crypto API User-interface

2010-09-07 Thread Nikos Mavrogiannopoulos
On Tue, Sep 7, 2010 at 4:11 PM, Herbert Xu wrote: >> > This is what I am proposing for the Crypto API user-interface. >> >> Can you explain why we would ever want a userspace interface to it? >> >> doing crypto in kernel for userspace consumers sis simply insane. >> It's computational intensive c

Re: RFC: Crypto API User-interface

2010-09-07 Thread Herbert Xu
On Tue, Sep 07, 2010 at 10:24:27AM -0400, Christoph Hellwig wrote: > > I don't think they matter in practice. We have less than a handfull > of drivers for them, and with CPUs gaining proper instructions they > are even less useful. In addition any sane PCI card should just > allow userspace map

Re: RFC: Crypto API User-interface

2010-09-07 Thread Herbert Xu
On Tue, Sep 07, 2010 at 10:34:25AM -0400, Miloslav Trmac wrote: > > > > > /* These may also be set through sendmsg(2) cmsgs. */ > > > > op = ALG_AEAD_OP_ENCRYPT; > > > > setsockopt(opfd, SOL_ALG, ALG_AEAD_OP, op, sizeof(op)); > > > > setsockopt(opfd, SOL_ALG, ALG_AEA

Re: RFC: Crypto API User-interface

2010-09-07 Thread Miloslav Trmac
- "Herbert Xu" wrote: > On Tue, Sep 07, 2010 at 07:27:47AM -0400, Miloslav Trmac wrote: > > Hello, > > - "Herbert Xu" wrote: > > > First of all let's have a quick look at what the user-space side > > > looks like for AEAD: > > > > > > /* Each listen call generates one or more fds for i

Re: RFC: Crypto API User-interface

2010-09-07 Thread Christoph Hellwig
On Tue, Sep 07, 2010 at 10:11:12PM +0800, Herbert Xu wrote: > FWIW I don't care about user-space using kernel software crypto at > all. It's the security people that do. And since when did we care about their crack pipe dreams? > The purpose of the user-space API is to export the hardware crypto

Re: RFC: Crypto API User-interface

2010-09-07 Thread Herbert Xu
On Tue, Sep 07, 2010 at 10:06:46AM -0400, Christoph Hellwig wrote: > On Tue, Sep 07, 2010 at 04:42:13PM +0800, Herbert Xu wrote: > > Hi: > > > > This is what I am proposing for the Crypto API user-interface. > > Can you explain why we would ever want a userspace interface to it? > > doing crypto

Re: RFC: Crypto API User-interface

2010-09-07 Thread Herbert Xu
On Tue, Sep 07, 2010 at 07:27:47AM -0400, Miloslav Trmac wrote: > Hello, > - "Herbert Xu" wrote: > > First of all let's have a quick look at what the user-space side > > looks like for AEAD: > > > > /* Each listen call generates one or more fds for input/output > > * that behave like

Re: RFC: Crypto API User-interface

2010-09-07 Thread Christoph Hellwig
On Tue, Sep 07, 2010 at 04:42:13PM +0800, Herbert Xu wrote: > Hi: > > This is what I am proposing for the Crypto API user-interface. Can you explain why we would ever want a userspace interface to it? doing crypto in kernel for userspace consumers sis simply insane. It's computational intensive

Re: RFC: Crypto API User-interface

2010-09-07 Thread Miloslav Trmac
Hello, - "Herbert Xu" wrote: > First of all let's have a quick look at what the user-space side > looks like for AEAD: > > /* Each listen call generates one or more fds for input/output >* that behave like pipes. >*/ > listen(tfmfd, 0); > /* fd for encryption

Re: RFC: Crypto API User-interface

2010-09-07 Thread Tomas Mraz
On Tue, 2010-09-07 at 16:42 +0800, Herbert Xu wrote: > Hi: > > This is what I am proposing for the Crypto API user-interface. > > Note that this is the interface for operations. There will be > a separate interface (most likely netlink) for configuring crypto > algorithms, e.g., picking a speci

RFC: Crypto API User-interface

2010-09-07 Thread Herbert Xu
Hi: This is what I am proposing for the Crypto API user-interface. Note that this is the interface for operations. There will be a separate interface (most likely netlink) for configuring crypto algorithms, e.g., picking a specific AES implementation as the system default. First of all let's ha