[BUGFIX] Fix AES-NI CTR optimization compiling failure with gas 2.16.1

2010-03-11 Thread Huang Ying
Andrew Morton reported that AES-NI CTR optimization failed to compile with gas 2.16.1, the error message is as follow: arch/x86/crypto/aesni-intel_asm.S: Assembler messages: arch/x86/crypto/aesni-intel_asm.S:752: Error: suffix or operands invalid for `movq' arch/x86/crypto/aesni-intel_asm.S:753:

Converting mac80211 CCMP to packet-at-a-time processing

2010-03-11 Thread Pavel Roskin
Hello! The CCMP encryption in mac80211 uses crypto API to encrypt 16 bytes at a time. I believe this is not the best approach if hardware acceleration is used. The ixp4xx_crypto driver doesn't even provide the "aes" ciphers. It only provides block ciphers, such as "cbc(des)". It would be much

Re: [PATCH] crypto: Add AES-NI accelerated CTR mode

2010-03-11 Thread Herbert Xu
On Thu, Mar 11, 2010 at 12:15:10PM -0800, Andrew Morton wrote: > > > + movq TCTR_LOW, INC > > + movq CTR, TCTR_LOW > > ^^ these two lines don't assemble with gas 2.16.1: > > arch/x86/crypto/aesni-intel_asm.S: Assembler messages: > arch/x86/crypto/aesni-intel_asm.S:752: Error: suffix or operan

Re: [PATCH] crypto: Add AES-NI accelerated CTR mode

2010-03-11 Thread Andrew Morton
On Mon, 01 Mar 2010 14:14:36 +0800 Huang Ying wrote: > To take advantage of the hardware pipeline implementation of AES-NI > instructions. CTR mode cryption is implemented in ASM to schedule > multiple AES-NI instructions one after another. This way, some latency > of AES-NI instruction can be el