Async hash reentrancy

2010-03-01 Thread Uri Simchoni
Hi, I'd like to add sha1/hmac-sha1 support to the Marvell CESA driver. I couldn't see an ahash driver that I can use as a reference. Is there such a driver? There's a thing I'm not sure I understand, and that's the init-update-final mechanism. I know what it's for (as in other APIs, e.g. OpenSS

Re: [PATCH v1] compiler: prevent dead store elimination

2010-03-01 Thread Andi Kleen
On Sun, Feb 28, 2010 at 09:15:11PM -0800, Arjan van de Ven wrote: > On Sat, 27 Feb 2010 21:47:42 +0100 > Roel Kluin wrote: > > +void secure_bzero(void *p, size_t n) > > +{ > > + memset(p, 0, n); > > + ARRAY_PREVENT_DSE(p, n); > > +} > > +EXPORT_SYMBOL(secure_bzero); > > > please don't introd

Re: tip: origin tree boot crash

2010-03-01 Thread Steffen Klassert
Hi. On Mon, Mar 01, 2010 at 08:50:24AM +0100, Ingo Molnar wrote: > > Hi, > > * Herbert Xu wrote: > > > crypto: pcrypt - Add pcrypt crypto parallelization wrapper > > -tip testing started triggering the following frequent boot crash yesterday, > on 64-bit x86: > > | calling pcrypt_i

Re: Suspect bug in the authenc module

2010-03-01 Thread Steffen Klassert
On Sat, Feb 27, 2010 at 12:14:15PM +0100, Roberto Sassu wrote: > Hello > > i'm trying to use the authenc module and i wrote a small kernel module that > simply encrypts/decrypts a fixed data using the hmac(sha1) as authentication > algorithm and cbc(aes) as encryption algorithm. > The used plat

Re: [PATCH v1] compiler: prevent dead store elimination

2010-03-01 Thread Alexey Dobriyan
On Mon, Mar 1, 2010 at 11:32 AM, Mikael Pettersson wrote: > Arjan van de Ven writes: >  > On Sat, 27 Feb 2010 21:47:42 +0100 >  > Roel Kluin wrote: >  > > +void secure_bzero(void *p, size_t n) >  > > +{ >  > > +  memset(p, 0, n); >  > > +  ARRAY_PREVENT_DSE(p, n); >  > > +} >  > > +EXPORT_SYMBOL(

Re: [PATCH v1] compiler: prevent dead store elimination

2010-03-01 Thread Mikael Pettersson
Arjan van de Ven writes: > On Sat, 27 Feb 2010 21:47:42 +0100 > Roel Kluin wrote: > > +void secure_bzero(void *p, size_t n) > > +{ > > + memset(p, 0, n); > > + ARRAY_PREVENT_DSE(p, n); > > +} > > +EXPORT_SYMBOL(secure_bzero); > > > please don't introduce bzero again to the kernel;

Re: [PATCH v2] compiler: prevent dead store elimination

2010-03-01 Thread Mikael Pettersson
Roel Kluin writes: > Due to optimization A call to memset() may be removed as a dead store when ___^ lower-case a > the buffer is not used after its value is overwritten. The new function > secure_bzero() ensures a section of memory is padded with zeroes. > > >From the G

[PATCH] crypto, Speed testing support for ghash

2010-03-01 Thread Huang Ying
Because ghash needs setkey, the setkey and keysize template support for test_hash_speed is added. Signed-off-by: Huang Ying --- crypto/tcrypt.c | 122 +++- crypto/tcrypt.h |1 2 files changed, 78 insertions(+), 45 deletions(-) --- a/cryp