RE: [PATCH] to fix vmac test fails on s390

2010-02-20 Thread Wang, Shane
This patch is to fix the vmac algorithm, add more test cases for vmac, and fix the test failure on some big endian system like s390. Signed-off-by: Shane Wang crypto/testmgr.h | 64 +++-- crypto/vmac.c| 77 ++--- 2

Re: [PATCH 1/1] crypto: Partial revert of whitespace changes

2010-02-20 Thread Herbert Xu
On Sat, Feb 20, 2010 at 11:05:09PM +0100, Richard Hartmann wrote: > This commit fixes my previous patches in the way Herbert Xu asked me to. > > Signed-off-by: Richard Hartmann I think I wasn't very clear. You should only send incremental patches for stuff that I have already merged. As these

[PATCH 1/1] crypto: Partial revert of whitespace changes

2010-02-20 Thread Richard Hartmann
This commit fixes my previous patches in the way Herbert Xu asked me to. Signed-off-by: Richard Hartmann --- crypto/seed.c |2 +- crypto/tcrypt.c |4 +- crypto/wp512.c | 114 +++--- crypto/xcbc.c |4 +- 4 files changed, 62 inserti

Re: [PATCH 05/19] crypto: proc - Fix checkpatch errors

2010-02-20 Thread Herbert Xu
On Sat, Feb 20, 2010 at 11:26:46AM +0100, Richard Hartmann wrote: > > Another workflow question: > Does LKML as a whole prefer rebased patches, patches on top of the > old one or does not one care as long as it's clear what to apply in what > order? > Or does everyone have a different opionion, in

Re: [PATCH 05/19] crypto: proc - Fix checkpatch errors

2010-02-20 Thread Richard Hartmann
On Sat, Feb 20, 2010 at 03:48, Herbert Xu wrote: >> In this case, please hold seed, tcrypt, wp512 & xcbc. I will >> refactor them. > > OK. Another workflow question: Does LKML as a whole prefer rebased patches, patches on top of the old one or does not one care as long as it's clear what to appl