Re: crypto_remove_spawns: BUG: unable to handle kernel NULL pointer dereference at 0000000000000018

2010-02-16 Thread Herbert Xu
On Tue, Feb 16, 2010 at 09:31:39PM +0200, Alexey Dobriyan wrote: > > Which codepath exactly? When a spawn is created the instance associated with it will have a zero-initialised cra_users entry. > BTW, CBC or AES aren't used, just loaded. Can you boot without aes/cbc loaded and see if it gets au

Re: converting sync driver to async

2010-02-16 Thread Herbert Xu
On Tue, Feb 16, 2010 at 06:06:37PM +0200, avital sela wrote: > Hello, > > I have written sha and aes HW accelerator drivers for our custom > drivers (thanks for your patient help) and they work great. > To exploit the full potential of the HW I want to port them to the > ASYNC interface and have s

Re: crypto_remove_spawns: BUG: unable to handle kernel NULL pointer dereference at 0000000000000018

2010-02-16 Thread Alexey Dobriyan
On Tue, Feb 16, 2010 at 08:02:03PM +0800, Herbert Xu wrote: > On Mon, Feb 15, 2010 at 10:14:08AM +0200, Alexey Dobriyan wrote: > > > > Yes, ipcomp bug triggers almost immediately. > > Anyway, this is just description of what I do. > > Can you see if this patch makes it go away? > > This can happ

Warning: E-mail viruses detected

2010-02-16 Thread MailScanner
Our e-mail content detector has just been triggered by a message you sent: To: off...@ccihr.ro Subject: Re: Notify Date: Tue Feb 16 18:51:12 2010 One or more of the attachments (data.rtf.scr, document.zip) are on the list of unacceptable attachments for this site and will not have been deliv

converting sync driver to async

2010-02-16 Thread avital sela
Hello, I have written sha and aes HW accelerator drivers for our custom drivers (thanks for your patient help) and they work great. To exploit the full potential of the HW I want to port them to the ASYNC interface and have some questions. 1. Using my current setup I see the following results (mea

Re: [PATCH] crypto/arc4: convert this stream cipher into a block cipher

2010-02-16 Thread Herbert Xu
On Fri, Feb 12, 2010 at 09:42:28AM +0100, Sebastian Andrzej Siewior wrote: > > -static void arc4_crypt(struct crypto_tfm *tfm, u8 *out, const u8 *in) > +static void arc4_ivsetup(struct arc4_ctx *ctx, u8 *iv) > { > - struct arc4_ctx *ctx = crypto_tfm_ctx(tfm); > + if (unlikely(!ctx->new_key

Re: [PATCH] to fix vmac test fails on s390

2010-02-16 Thread Herbert Xu
On Thu, Feb 11, 2010 at 11:18:08AM +0800, Wang, Shane wrote: > > static struct hash_testvec aes_vmac128_tv_template[] = { > { > + .key= "\x00\x01\x02\x03\x04\x05\x06\x07" > + "\x08\x09\x0a\x0b\x0c\x0d\x0e\x0f", > + .plaintext = NULL, > +#ifde

Re: [PATCH 1/1] CRYPTO: Fix checkpatch errors & warnings in cipher.c

2010-02-16 Thread Herbert Xu
On Tue, Feb 16, 2010 at 01:06:27PM +0100, Richard Hartmann wrote: > > One more question on workflow, though.. I have been checking > http://git.kernel.org/?p=linux/kernel/git/herbert/crypto-2.6.git;a=summary > for updates, but obviously, this was the wrong place. You should check the cryptodev-2.

Re: [PATCH 1/1] CRYPTO: Fix checkpatch errors & warnings in cipher.c

2010-02-16 Thread Richard Hartmann
On Tue, Feb 16, 2010 at 13:00, Herbert Xu wrote: > For the crypto tree at least I've got all your patches so you > don't have to resend. OK, thank you very much. Expect more patches, in this case :) One more question on workflow, though.. I have been checking http://git.kernel.org/?p=linux/kern

Re: crypto_remove_spawns: BUG: unable to handle kernel NULL pointer dereference at 0000000000000018

2010-02-16 Thread Herbert Xu
On Mon, Feb 15, 2010 at 10:14:08AM +0200, Alexey Dobriyan wrote: > > Yes, ipcomp bug triggers almost immediately. > Anyway, this is just description of what I do. Can you see if this patch makes it go away? This can happen when you're unloading aes just as an algorithm that uses aes (such as cbc

Re: [PATCH 1/1] CRYPTO: Fix checkpatch errors & warnings in cipher.c

2010-02-16 Thread Herbert Xu
On Tue, Feb 16, 2010 at 12:56:15PM +0100, Richard Hartmann wrote: > > Thus, I wanted to check if I should wait some more or what the general > consensus of action in the crypto subtree is. > > And yes, I am aware that janitor work, and thus my patches, is very low > priority. For the crypto tree

Re: [PATCH 1/1] CRYPTO: Fix checkpatch errors & warnings in cipher.c

2010-02-16 Thread Richard Hartmann
On Thu, Feb 11, 2010 at 05:46, Herbert Xu wrote: >> Should I re-send the patch or is it less noise & hassle if I just leave >> it this way? > > You don't have to resend it. GregKH said that I should just re-send all patches after a week. OTOH, I am not sure if this is not a little bit too agress