Re: crypto_remove_spawns: BUG: unable to handle kernel NULL pointer dereference at 0000000000000018

2010-02-14 Thread Alexey Dobriyan
On Mon, Feb 15, 2010 at 7:27 AM, Herbert Xu wrote: > Is this reproducible every time you unload aes_x86_64 after boot? No, what I do is 1. setup ipcomp in tunnel mode _in fresh netns_ and immediately exit 2. modprobe/rmmod all modules (not much) ~1 hour of this workload and it hits sometimes wi

Re: crypto_remove_spawns: BUG: unable to handle kernel NULL pointer dereference at 0000000000000018

2010-02-14 Thread Herbert Xu
On Sun, Feb 14, 2010 at 07:45:07PM +0200, Alexey Dobriyan wrote: > BUG: unable to handle kernel NULL pointer dereference at 0018 > IP: [] crypto_remove_spawns+0xd4/0x340 > PGD bdc48067 PUD bc954067 PMD 0 > Oops: [#1] PREEMPT SMP DEBUG_PAGEALLOC > last sysfs file: > /sys/devices/p

Re: [PATCH] crypto/arc4: convert this stream cipher into a block cipher

2010-02-14 Thread Herbert Xu
On Sun, Feb 14, 2010 at 09:42:54PM +0100, Sebastian Andrzej Siewior wrote: > * Sebastian Andrzej Siewior | 2010-02-12 09:42:28 [+0100]: > > >+static void arc4_ivsetup(struct arc4_ctx *ctx, u8 *iv) > > { > >-struct arc4_ctx *ctx = crypto_tfm_ctx(tfm); > >+if (unlikely(!ctx->new_key)) > > T

Re: [PATCH] crypto/arc4: convert this stream cipher into a block cipher

2010-02-14 Thread Sebastian Andrzej Siewior
* Sebastian Andrzej Siewior | 2010-02-12 09:42:28 [+0100]: >+static void arc4_ivsetup(struct arc4_ctx *ctx, u8 *iv) > { >- struct arc4_ctx *ctx = crypto_tfm_ctx(tfm); >+ if (unlikely(!ctx->new_key)) That should be likely(). Do you want me resend the whole thing? Haven't noticed anything

crypto_remove_spawns: BUG: unable to handle kernel NULL pointer dereference at 0000000000000018

2010-02-14 Thread Alexey Dobriyan
BUG: unable to handle kernel NULL pointer dereference at 0018 IP: [] crypto_remove_spawns+0xd4/0x340 PGD bdc48067 PUD bc954067 PMD 0 Oops: [#1] PREEMPT SMP DEBUG_PAGEALLOC last sysfs file: /sys/devices/pci:00/:00:1f.2/host0/target0:0:0/0:0:0:0/block/sda/uevent CPU 0 Pid: