Re: crypto_shash_update & CRYPTO_TFM_REQ_MAY_SLEEP

2010-02-08 Thread Herbert Xu
Dmitry Kasatkin wrote: > > One interesting issue > > Many clients in the kernel set CRYPTO_TFM_REQ_MAY_SLEEP to desc.flags. > It is used by crypto_yeld(). That flag is really only meaningful for synchronous implementations. For hardware crypto that is asynchronous, you can simply ignore it in

Re: [PATCH] dm-crypt: disable block encryption with arc4

2010-02-08 Thread Herbert Xu
Mikulas Patocka wrote: > > You should rather add a flag CRYPTO_ALG_CHANGES_STATE to determine that a > cipher can't be used to encrypt disks. No, please see my reply in the previous thread. What we should do is fix arc4. I just haven't got around to doing it yet. As to blacklisting algorithm

Re: Async Crypto API

2010-02-08 Thread Herbert Xu
On Tue, Feb 02, 2010 at 03:46:58PM +0200, Dmitry Kasatkin wrote: > in sync API final() does not have any data. > > Is async driver also should ignore req->src in final() call? Yes req->src can be ignored in final. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~

Re: Async Crypto API

2010-02-08 Thread Herbert Xu
On Tue, Feb 02, 2010 at 02:17:51PM +0200, Dmitry Kasatkin wrote: > Hi, > > In the case when finup() is not used, just update/update/../final > driver finalize calculation from the final function. > > It takes a time and if it may not sleep, can final() also return > EINPROGRESS? Sure, final can

Re: LZO irreversible output?

2010-02-08 Thread Nigel Cunningham
Hi Bill. Bill Davidsen wrote: > I would hope someone will look at the real problem, though, that LZO > isn't working properly. I have to assume that either the kernel > decompress is broken or that the page you have given is invalid, and the > error lies in the compression. > > It doesn't look as