Re: Crypto API

2010-01-13 Thread Herbert Xu
Dmitry Kasatkin wrote: > > I develop some drivers for crypto HW and met some difficulties. > Some algorithm functions are called behind crypto_kmap() > > data = crypto_kmap(sg_page(sg), 0); > > It will do inc_preempt_count(); > > I try to use DMA controller to perform memory transfers and try

Re: [PATCH 3/4] crypto: md5 - Add export support

2010-01-13 Thread Max Vozeler
On Wed, Jan 13, 2010 at 08:52:39PM +1100, Herbert Xu wrote: > On Mon, Dec 28, 2009 at 06:59:14PM +, Max Vozeler wrote: > > This patch adds export support to md5. The exported type is > > defined by struct md5_state. > > > > This is modeled after the equivalent change to sha1_generic, > > exce

Re: [PATCH 1/4] dm-crypt: clarify cipher vs. cipher mode

2010-01-13 Thread Max Vozeler
Hi Richard, On Mon, Jan 11, 2010 at 10:28:39PM +0100, Richard Zidlicky wrote: > On Mon, Jan 04, 2010 at 04:25:42PM +0100, Max Vozeler wrote: > > + > > +These modes have two main characteristics compared to regular CBC > > +with sector IV. The first is implemented in dm-crypt, the second > > +is im

Re: Crypto test results unused?

2010-01-13 Thread Krzysztof Halasa
Herbert Xu writes: >> I think we need a way to differentiate between "really unknown" and >> "failed", do we need another flag for it? > > It doesn't matter. We test all algorithms at registration time. > So unknown means failed except during registration. So should we change "selftest: unknown

Re: [PATCH 3/4] crypto: md5 - Add export support

2010-01-13 Thread Herbert Xu
On Mon, Dec 28, 2009 at 06:59:14PM +, Max Vozeler wrote: > This patch adds export support to md5. The exported type is > defined by struct md5_state. > > This is modeled after the equivalent change to sha1_generic, > except only export is added for now. > > Signed-off-by: Max Vozeler > Cc:

Re: PATCH crypto/zlib: Allow Z_OK return value from zlib_deflate

2010-01-13 Thread Herbert Xu
On Wed, Dec 23, 2009 at 08:01:57PM +0800, Herbert Xu wrote: > > Hmm, it seems that the semantics of the final function isn't > quite right. It was never meant to be called multiple times. > > Let me see if we can fix this up without touching the interface. How about this patch? So now the final

Re: Userspace API /dev/crypto

2010-01-13 Thread Emanuele Cesena
On Tue, 2010-01-12 at 21:37 +0100, Linus Walleij wrote: > Has there been some/any progress on the userspace API since, or > is this up for grabs? > As far as I know the most recent advance is: "Add CryptoAPI User Interface Support v8" http://marc.info/?t=12269647651&r=1&w=2 I recommend you to