Re: [PATCH] xfrm: Fix truncation length of authentication algorithms installed via PF_KEY

2009-12-11 Thread David Miller
From: Martin Willi Date: Wed, 9 Dec 2009 17:11:15 +0100 > Commit 4447bb33f09444920a8f1d89e1540137429351b6 breaks installation of > authentication algorithms via PF_KEY, as the state specific truncation > length is not installed with the algorithms default truncation length. > This patch initiali

Re: CRYPTO_TFM_REQ_MASK and CRYPTO_TFM_RES_MASK

2009-12-11 Thread Dimitrios Siganos
After sending the email, I realised what's happening... crypto_cipher_setkey seems to be used that way only when a child cipher is used by another (parent) cipher as a way to delegate work. It seems that crypto_cipher_setkey accepts a number of request flags CRYPTO_TFM_REQ_* which must be pass

CRYPTO_TFM_REQ_MASK and CRYPTO_TFM_RES_MASK

2009-12-11 Thread Dimitrios Siganos
Hi, Could someone explain what the masks CRYPTO_TFM_REQ_MASK and CRYPTO_TFM_RES_MASK do and why they must be manipulated before and after crypto_cipher_setkey(...)? Here is an example use (from crypto_pcbc_setkey): crypto_cipher_clear_flags(child, CRYPTO_TFM_REQ_MASK); crypto_cipher_set

Re: [PATCH 3/12] crypto: Correct size given to memset

2009-12-11 Thread Herbert Xu
On Wed, Dec 09, 2009 at 08:23:09PM +0100, Julia Lawall wrote: > From: Julia Lawall > > Memset should be given the size of the structure, not the size of the pointer. > > The semantic patch that makes this change is as follows: > (http://coccinelle.lip6.fr/) > > // > @@ > type T; > T *x; > expr

Re: [PATCH] geode: PTR_ERR return of wrong pointer in fallback_init_cip()

2009-12-11 Thread Herbert Xu
On Mon, Dec 07, 2009 at 03:14:33PM +0100, Roel Kluin wrote: > Return the PTR_ERR of the correct pointer. > > Signed-off-by: Roel Kluin Patch applied. Thank you. -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: