Re: [PATCH -v4] crypto: Add PCLMULQDQ accelerated GHASH implementation

2009-11-01 Thread Ingo Molnar
* Herbert Xu wrote: > - pshufb BSWAP, DATA > + # pshufb BSWAP, DATA > + .byte 0x66, 0x0f, 0x38, 0x00, 0xc5 A cleanup request: mind creating two macros for this PSHUFB MMX/SSE instruction in arch/x86/include/asm/i387.h, instead of open-coding the .byte sequences in ~6 places? ( Af

Re: [PATCH -v4] crypto: Add PCLMULQDQ accelerated GHASH implementation

2009-11-01 Thread Herbert Xu
On Sat, Oct 31, 2009 at 05:30:15PM -0700, Andrew Morton wrote: > > x86_64 allmodconfig, GNU assembler 2.16.1: > > arch/x86/crypto/ghash-clmulni-intel_asm.S: Assembler messages: > arch/x86/crypto/ghash-clmulni-intel_asm.S:103: Error: no such instruction: > `pshufb %xmm5,%xmm0' > arch/x86/crypto/g