Re: [PATCH 0/3] enhance RNG api with flags to allow for different operational modes

2009-09-16 Thread Herbert Xu
On Wed, Sep 16, 2009 at 12:04:56PM -0400, Neil Horman wrote: > > So the question is, how do I make this RNG fips compliant without > breaking some subset of users out there that rely on the predictability of the > CPRNG? The solution I've come up with is a dynamic flag. This patch series W

Re: [PATCH] arm: new W macro to WORD_ACCESS

2009-09-16 Thread Catalin Marinas
On Wed, 2009-09-16 at 19:58 +0200, Sebastian Andrzej Siewior wrote: > As reported by Frans Pop the new global macro W on ARM which is included > via > |arch/arm/include/asm/uaccess.h:20 > |include/linux/uaccess.h:5 > |include/linux/crypto.h:26 > |crypto/cast6.c:23 > > leads to a build error becaus

Re: [PATCH 3/3] augment CPRNG to correctly implement continuous test for FIPS, and support TEST_MODE flags

2009-09-16 Thread Jarod Wilson
On 09/16/2009 12:25 PM, Neil Horman wrote: patch 3/3: modify cprng to make contnuity check fips compliant and allow for a disabling of the continuity test when the RNG is placed in FIPS mode Signed-off-by: Neil Horman Acked-by: Jarod Wilson -- Jarod Wilson ja...@redhat.com -- To unsubscribe

Re: [PATCH 2/3] augment the testmgr code to set TEST_MODE flag on all rng instances

2009-09-16 Thread Jarod Wilson
On 09/16/2009 12:13 PM, Neil Horman wrote: patch 2/3: Update testmgr code to place any rng it tests in TEST_MODE This patch instructs the testmgr code to place all rng allocations that it makes into test mode, so that in the event that it has internal mechanisms that may affect the testing of th

Re: [PATCH 0/3] enhance RNG api with flags to allow for different operational modes

2009-09-16 Thread Jarod Wilson
On 09/16/2009 12:04 PM, Neil Horman wrote: Hey all- Ok, so I've got a story behind this one. It was recently called to my attention that the ansi cprng is missing an aspect of its compliance requrements for FIPS-140. Specifically, its missing a behavior in its continuous test. When the

Re: [PATCH 1/3] add RNG api calls to set common flags

2009-09-16 Thread Jarod Wilson
On 09/16/2009 12:11 PM, Neil Horman wrote: patch 1/3: Add flags infrastructure to rng api This patch adds api calls for get/set flags calls to the crypto rng api. This api allows algorithm implementations to register calls to respond to flag settings that are global and common to all rng's. If

Re: [PATCH] arm: new W macro to WORD_ACCESS

2009-09-16 Thread Russell King - ARM Linux
On Wed, Sep 16, 2009 at 07:58:12PM +0200, Sebastian Andrzej Siewior wrote: > leads to a build error because the crypto/cast6.c defines a function > which is named W. W has nothing to do with the access size, so this change makes it _really_ confusing. What it's about is telling the compiler to us

[PATCH] arm: new W macro to WORD_ACCESS

2009-09-16 Thread Sebastian Andrzej Siewior
As reported by Frans Pop the new global macro W on ARM which is included via |arch/arm/include/asm/uaccess.h:20 |include/linux/uaccess.h:5 |include/linux/crypto.h:26 |crypto/cast6.c:23 leads to a build error because the crypto/cast6.c defines a function which is named W. Reported-by: Frans Pop S

Re: [PATCH 3/3] augment CPRNG to correctly implement continuous test for FIPS, and support TEST_MODE flags

2009-09-16 Thread Neil Horman
patch 3/3: modify cprng to make contnuity check fips compliant and allow for a disabling of the continuity test when the RNG is placed in FIPS mode Signed-off-by: Neil Horman ansi_cprng.c | 56 +++- 1 file changed, 51 insertions(+), 5 delet

Re: [PATCH 2/3] augment the testmgr code to set TEST_MODE flag on all rng instances

2009-09-16 Thread Neil Horman
patch 2/3: Update testmgr code to place any rng it tests in TEST_MODE This patch instructs the testmgr code to place all rng allocations that it makes into test mode, so that in the event that it has internal mechanisms that may affect the testing of the RNG, they won't affect the outcome of the t

Re: [PATCH 1/3] add RNG api calls to set common flags

2009-09-16 Thread Neil Horman
patch 1/3: Add flags infrastructure to rng api This patch adds api calls for get/set flags calls to the crypto rng api. This api allows algorithm implementations to register calls to respond to flag settings that are global and common to all rng's. If a given algorithm has no external flags that

[PATCH 0/3] enhance RNG api with flags to allow for different operational modes

2009-09-16 Thread Neil Horman
Hey all- Ok, so I've got a story behind this one. It was recently called to my attention that the ansi cprng is missing an aspect of its compliance requrements for FIPS-140. Specifically, its missing a behavior in its continuous test. When the CPRNG produces random blocks, the firrst bloc

Re: Build error on arm in crypto/cast6.c

2009-09-16 Thread Frans Pop
On Wednesday 16 September 2009, Frans Pop wrote: > $ git describe master > v2.6.31-4547-g0cb583f > > gcc version 4.3.2 > > crypto/cast6.c:372:39: error: macro "W" passed 2 arguments, but takes just 1 > crypto/cast6.c:372: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ > before ‘{’ token

Build error on arm in crypto/cast6.c

2009-09-16 Thread Frans Pop
$ git describe master v2.6.31-4547-g0cb583f gcc version 4.3.2 crypto/cast6.c:372:39: error: macro "W" passed 2 arguments, but takes just 1 crypto/cast6.c:372: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘{’ token crypto/cast6.c:413:16: error: macro "W" passed 2 arguments, but