Re: [dm-crypt] cryptsetup with arc4 cipher

2009-08-06 Thread Stelios Bounanos
> On Thu, 06 Aug 2009 09:46:59 +0200, Milan Broz said: > Sebastian Andrzej Siewior wrote: >> Don't use this as a block cipher in dm-crypt, it is a bad idea. >> >> The long story: >> ARC4 is a stream cipher and not a block cipher. Its internal state is >> reseted in setkey() and every crypto

Re: [dm-crypt] cryptsetup with arc4 cipher

2009-08-06 Thread Herbert Xu
On Thu, Aug 06, 2009 at 10:38:05AM +0200, Sebastian Andrzej Siewior wrote: > > Herbert, any concern to inroduce > #define CRYPTO_ALG_TYPE_STREAM_CIPHER 0x0007 > and split block cipher from stream cipher? > So no one would mix them up since dm-crypt for instance will look just > for block

Re: [dm-crypt] cryptsetup with arc4 cipher

2009-08-06 Thread Sebastian Andrzej Siewior
* Milan Broz | 2009-08-06 09:46:59 [+0200]: >yes, I understand why this happens. I do not want to use stream cipher, >but apparently users will do that:-) So once they discover that they have salsa20 in kernel they see another problem. >My question was why crypto allows this setting? Well, WLAN i

Re: [dm-crypt] cryptsetup with arc4 cipher

2009-08-06 Thread Milan Broz
Sebastian Andrzej Siewior wrote: > Don't use this as a block cipher in dm-crypt, it is a bad idea. > > The long story: > ARC4 is a stream cipher and not a block cipher. Its internal state is > reseted in setkey() and every crypto request (encrypt/decrypt don't > matter) update the internal state

Re: [PATCH -v2 5/5] crypto: Add PCLMULQDQ accelerated GHASH implementation

2009-08-06 Thread Huang Ying
On Thu, 2009-08-06 at 15:17 +0800, Herbert Xu wrote: > On Mon, Aug 03, 2009 at 03:45:31PM +0800, Huang Ying wrote: > > PCLMULQDQ is used to accelerate the most time-consuming part of GHASH, > > carry-less multiplication. More information about PCLMULQDQ can be > > found at: > > > > http://software

Re: [PATCH -v2 5/5] crypto: Add PCLMULQDQ accelerated GHASH implementation

2009-08-06 Thread Herbert Xu
On Mon, Aug 03, 2009 at 03:45:31PM +0800, Huang Ying wrote: > PCLMULQDQ is used to accelerate the most time-consuming part of GHASH, > carry-less multiplication. More information about PCLMULQDQ can be > found at: > > http://software.intel.com/en-us/articles/carry-less-multiplication-and-its-usage

Re: [PATCH -v2 4/5] x86: Move kernel_fpu_using to irq_is_fpu_using in asm/i387.h

2009-08-06 Thread Herbert Xu
On Wed, Aug 05, 2009 at 11:27:02PM -0700, H. Peter Anvin wrote: > Herbert Xu wrote: >> >> Peter, do you want to apply this patch in your tree or would >> you prefer for it to go through my tree along with the rest of >> the series? >> > > I'll take it tomorrow... want to double-check that we don't