Re: [PATCH 2/2] crypto/ansi prng: alloc cipher just in in init()

2009-06-29 Thread Neil Horman
On Mon, Jun 29, 2009 at 11:48:21PM +0200, Sebastian Andrzej Siewior wrote: > * Sebastian Andrzej Siewior | 2009-06-29 23:45:08 [+0200]: > > >From: Sebastian Andrzej Siewior > > > >As reported by Eric Sesterhenn the re-allocation of the cipher in reset leads > > Neil, the patches are untested. Co

Re: [PATCH 2/2] crypto/ansi prng: alloc cipher just in in init()

2009-06-29 Thread Sebastian Andrzej Siewior
* Sebastian Andrzej Siewior | 2009-06-29 23:45:08 [+0200]: >From: Sebastian Andrzej Siewior > >As reported by Eric Sesterhenn the re-allocation of the cipher in reset leads Neil, the patches are untested. Could you please verify them? Sebastian -- To unsubscribe from this list: send the line "u

[PATCH 2/2] crypto/ansi prng: alloc cipher just in in init()

2009-06-29 Thread Sebastian Andrzej Siewior
From: Sebastian Andrzej Siewior As reported by Eric Sesterhenn the re-allocation of the cipher in reset leads to: |BUG: sleeping function called from invalid context at kernel/rwsem.c:21 |in_atomic(): 1, irqs_disabled(): 0, pid: 4926, name: modprobe |INFO: lockdep is turned off. |Pid: 4926, comm:

[PATCH 1/2] crypto/ansi prng: use just a BH lock

2009-06-29 Thread Sebastian Andrzej Siewior
From: Sebastian Andrzej Siewior the current code uses a mix of sping_lock() & spin_lock_irqsave(). This can lead to deadlock with the correct timming & cprng_get_random() + cprng_reset() sequence. I've converted them to bottom half locks since all three user grab just a BH lock so this runs proba

Re: Bug when modprobing tcrypt

2009-06-29 Thread Neil Horman
On Mon, Jun 29, 2009 at 04:07:04PM +0200, Sebastian Andrzej Siewior wrote: > * Eric Sesterhenn | 2009-06-29 15:17:05 [+0200]: > > >[ 122.967099] BUG: sleeping function called from invalid context at > >kernel/rwsem.c:21 > >[ 122.967398] in_atomic(): 1, irqs_disabled(): 0, pid: 4926, name: > >mod

Re: Bug when modprobing tcrypt

2009-06-29 Thread Sebastian Andrzej Siewior
* Eric Sesterhenn | 2009-06-29 15:17:05 [+0200]: >[ 122.967099] BUG: sleeping function called from invalid context at >kernel/rwsem.c:21 >[ 122.967398] in_atomic(): 1, irqs_disabled(): 0, pid: 4926, name: >modprobe >[ 122.967643] INFO: lockdep is turned off. >[ 122.967858] Pid: 4926, comm: mod

[PATCH 2/2] pcrypt: Add pcrypt crypto parallelization wrapper

2009-06-29 Thread Steffen Klassert
This patch adds a parallel crypto template that takes a crypto algorithm and converts it to process the crypto transforms in parallel. For the moment only aead is supported. Signed-off-by: Steffen Klassert --- crypto/Kconfig| 13 ++ crypto/Makefile |2 + crypto/pcrypt

[PATCH 1/2] padata: generic interface for parallel processing

2009-06-29 Thread Steffen Klassert
This patch introduces an interface to process data objects in parallel. On request it is possible to serialize again. The parallelized objects return after serialization in the same order as they were before the parallelization. Signed-off-by: Steffen Klassert --- include/linux/interrupt.h |

Re: [RFC] [PATCH 2/5] aead: Add generic aead wrapper interface

2009-06-29 Thread Steffen Klassert
On Mon, Jun 29, 2009 at 07:59:50PM +0800, Herbert Xu wrote: > > OK. Can you send me the patches you used against the current > cryptodev tree (I only just pushed so give it an hour or so)? > I'll see if I can reproduce it here. > I'll send the remaining two patches in reply to this mail. The st

Bug when modprobing tcrypt

2009-06-29 Thread Eric Sesterhenn
Hi, i can repeatedly trigger the following bug when modprobing tcrypt to test the crypto algorithms with todays -git [ 122.967099] BUG: sleeping function called from invalid context at kernel/rwsem.c:21 [ 122.967398] in_atomic(): 1, irqs_disabled(): 0, pid: 4926, name: modprobe [ 122.967643] I

Re: [RFC] [PATCH 2/5] aead: Add generic aead wrapper interface

2009-06-29 Thread Herbert Xu
On Mon, Jun 29, 2009 at 01:04:10PM +0200, Steffen Klassert wrote: > > I applied your patch on top of the last pcrypt patchset, but > unfortunately it does not change anything here. > > If I do > modprobe tcrypt alg='pcrypt(authenc(hmac(sha1-generic),cbc(aes-generic)))' > type=3 > > it instantiat

Re: [RFC] [PATCH 3/5] eseqiv: Add support for aead algorithms

2009-06-29 Thread Steffen Klassert
On Thu, Jun 25, 2009 at 06:46:02PM +0800, Herbert Xu wrote: > On Mon, Jun 08, 2009 at 09:10:46AM +0200, Steffen Klassert wrote: > > This adds eseqiv support for aead algorithms, this is usefull > > for aead algorithms that need eseqiv as it's default IV generator. > > > > Signed-off-by: Steffen Kl

Re: [RFC] [PATCH 2/5] aead: Add generic aead wrapper interface

2009-06-29 Thread Steffen Klassert
On Thu, Jun 25, 2009 at 02:51:12PM +0800, Herbert Xu wrote: > > OK, the patch I just posted to the list should fix the problem. > > I was able to test it suing > > modprobe tcrypt alg='pcrypt(authenc(hmac(sha1-generic),cbc(aes-generic)))' > type=3 > I applied your patch on top of the last pcr